From patchwork Wed Mar 15 14:41:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 9625821 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 061696048C for ; Wed, 15 Mar 2017 14:41:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EDF3A28647 for ; Wed, 15 Mar 2017 14:41:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E2DA42864D; Wed, 15 Mar 2017 14:41:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 81AC828647 for ; Wed, 15 Mar 2017 14:41:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 11F816E8FC; Wed, 15 Mar 2017 14:41:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5DCC26E8E6 for ; Wed, 15 Mar 2017 14:41:21 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OMV00GWS24RCP50@mailout3.w1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 15 Mar 2017 14:41:15 +0000 (GMT) Received: from eusmges1.samsung.com (unknown [203.254.199.239]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170315144114eucas1p19be1387daaa4873329ae483b1c81befa~sFTB3usBA0136601366eucas1p1U; Wed, 15 Mar 2017 14:41:14 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1.samsung.com (EUCPMTA) with SMTP id A8.FC.16908.D8259C85; Wed, 15 Mar 2017 14:41:17 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170315144113eucas1p19ef427bc9c629ba8ed9571bf1e1e3bb3~sFTBJFPqK0087700877eucas1p1G; Wed, 15 Mar 2017 14:41:13 +0000 (GMT) X-AuditID: cbfec7ef-f79d26d00000420c-2b-58c9528dae7e Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id E0.63.10233.69259C85; Wed, 15 Mar 2017 14:41:26 +0000 (GMT) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OMV00GPG24OBF60@eusync2.samsung.com>; Wed, 15 Mar 2017 14:41:13 +0000 (GMT) From: Andrzej Hajda To: Inki Dae Subject: [PATCH v3 01/10] drm/exynos: simplify completion event handling Date: Wed, 15 Mar 2017 15:41:01 +0100 Message-id: <1489588870-7785-2-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <1489588870-7785-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsWy7djP87q9QScjDOa3cFncWneO1WLjjPWs Fle+vmezmHR/AovFm7drmCzOn9/AbjHj/D4mi7VH7rI7cHhsWtXJ5nG/+ziTx5b+u+wefVtW MXp83iQXwBrFZZOSmpNZllqkb5fAldE87RBTwR6uio9fb7E3MDZydjFyckgImEhMnjyXBcIW k7hwbz1bFyMXh5DAMkaJz+d2s0M4nxkl2o8uY4Pp+HFhOSNc1aNfz1kgnP+MEhPO/mEEqWIT 0JT4u/kmWIeIgLLEqn3tYKOYBTYwSdyc/RysSFjAQ+L+0Waw5SwCqhIHjl5gBrF5BZwkbkx7 AHWUnMTNc51gcU4BZ4n152YzQcR/s0kcupnfxcgBZMtKbDrADBF2kZh49iFUq7DEq+Nb2CFs GYnLk7vBDpUQ6GaU+NR/gh3CmcIo8e/DDKhua4nDxy+ygtjMAnwSk7ZNZ4ZYwCvR0SYEUeIh MWP/X6ihjhKX/zZBg2Iao8Tp48fYJjDKLGBkWMUoklpanJueWmyoV5yYW1yal66XnJ+7iREY z6f/HX+/g/Fpc8ghRgEORiUe3gm+JyOEWBPLiitzDzFKcDArifDe8AcK8aYkVlalFuXHF5Xm pBYfYpTmYFES59274Eq4kEB6YklqdmpqQWoRTJaJg1OqgXFex4Ib53fttxK5e/nrO8t35w4p vbl5uef7kSuuUkrlS75uXmG8Y7rBWsEyEw35XgchyaSdMWLx1nleX1T+NamHLv4poOIb7JF5 cMaMlrVCP9pEgovvZ54tTZmsuFffm8Ha7XVx7OSUkyGPSuUW53cGuXTHX6qT35FT/SJ/iube pXkMctuWvFViKc5INNRiLipOBAC5az754wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t/xK7rTgk5GGBy/ZmRxa905VouNM9az Wlz5+p7NYtL9CSwWb96uYbI4f34Du8WM8/uYLNYeucvuwOGxaVUnm8f97uNMHlv677J79G1Z xejxeZNcAGuUm01GamJKapFCal5yfkpmXrqtUmiIm66FkkJeYm6qrVKErm9IkJJCWWJOKZBn ZIAGHJwD3IOV9O0S3DKapx1iKtjDVfHx6y32BsZGzi5GTg4JAROJHxeWM0LYYhIX7q1n62Lk 4hASWMIoMe/qMRaQhJBAI5PE2ivRIDabgKbE38032UBsEQFliVX72tlBGpgFNjBJ3O07yQqS EBbwkLh/tBmsmUVAVeLA0QvMIDavgJPEjWkPWCC2yUncPNcJFucUcJZYf242E8QyJ4lXzYeZ JjDyLmBkWMUoklpanJueW2ykV5yYW1yal66XnJ+7iREY1tuO/dyyg7HrXfAhRgEORiUe3gm+ JyOEWBPLiitzDzFKcDArifDuCwQK8aYkVlalFuXHF5XmpBYfYjQFOmois5Rocj4w5vJK4g1N DM0tDY2MLSzMjYyUxHmnfrgSLiSQnliSmp2aWpBaBNPHxMEp1cA4Z902M48v8mmPli5eLem7 1ftVVf9sD/uvxxcEOT3kkH2jq/n0XX595sq1HxZHSKja3w5aaLx6a3smS3eT6LaE/FPpBs3i ihNi1098crOI+1H+W9ZnVeuPVCi+U71rmmK27tUknQBWBhExmRDZOR4MLKz2qaY8Gk+mn21V 95v1TrXs5EGG+SFKLMUZiYZazEXFiQAo6bgYgQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170315144113eucas1p19ef427bc9c629ba8ed9571bf1e1e3bb3 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170315144113eucas1p19ef427bc9c629ba8ed9571bf1e1e3bb3 X-RootMTR: 20170315144113eucas1p19ef427bc9c629ba8ed9571bf1e1e3bb3 References: <1489588870-7785-1-git-send-email-a.hajda@samsung.com> Cc: Javier Martinez Canillas , linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, Marek Szyprowski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP All Exynos CRTC drivers shouldn't fail at referencing vblank events, alternate path is actually dead code. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index 0620d3c..9184974 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c @@ -105,16 +105,15 @@ void exynos_crtc_handle_event(struct exynos_drm_crtc *exynos_crtc) struct drm_pending_vblank_event *event = crtc->state->event; unsigned long flags; - if (event) { - crtc->state->event = NULL; - spin_lock_irqsave(&crtc->dev->event_lock, flags); - if (drm_crtc_vblank_get(crtc) == 0) - drm_crtc_arm_vblank_event(crtc, event); - else - drm_crtc_send_vblank_event(crtc, event); - spin_unlock_irqrestore(&crtc->dev->event_lock, flags); - } + if (!event) + return; + crtc->state->event = NULL; + + WARN_ON(drm_crtc_vblank_get(crtc) != 0); + spin_lock_irqsave(&crtc->dev->event_lock, flags); + drm_crtc_arm_vblank_event(crtc, event); + spin_unlock_irqrestore(&crtc->dev->event_lock, flags); } static void exynos_drm_crtc_destroy(struct drm_crtc *crtc)