| Message ID | 1511924469-11448-2-git-send-email-david@lechnology.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 28, 2017 at 09:01:08PM -0600, David Lechner wrote: > This adds a new device tree binding for Sitronix ST7735R display panels, > such as the Adafruit 1.8" TFT. > > Signed-off-by: David Lechner <david@lechnology.com> > --- > .../bindings/display/sitronix,st7735r.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sitronix,st7735r.txt Acked-by: Rob Herring <robh@kernel.org>
Den 29.11.2017 04.01, skrev David Lechner: > This adds a new device tree binding for Sitronix ST7735R display panels, > such as the Adafruit 1.8" TFT. > > Signed-off-by: David Lechner <david@lechnology.com> > --- > .../bindings/display/sitronix,st7735r.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sitronix,st7735r.txt > > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt > new file mode 100644 > index 0000000..bbb8ba6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt > @@ -0,0 +1,35 @@ > +Sitronix ST7735R display panels > + > +This binding is for display panels using a Sitronix ST7735R controller in SPI > +mode. > + > +Required properties: > +- compatible: "sitronix,st7735r-jd-t18003-t01" > +- dc-gpios: Display data/command selection (D/CX) > +- reset-gpios: Reset signal (RSTX) I'm wondering if this should be optional. Even though the display needs the reset line to be driven, it doesn't have to be so by a gpio, I believe you can even get away with just using a resistor as a reset circuit. Not terribly important, it's up to you. Noralf. > + > +The node for this driver must be a child node of a SPI controller, hence > +all mandatory properties described in ../spi/spi-bus.txt must be specified. > + > +Optional properties: > +- rotation: panel rotation in degrees counter clockwise (0,90,180,270) > +- backlight: phandle of the backlight device attached to the panel > + > +Example: > + > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&gpio 44 GPIO_ACTIVE_HIGH>; > + } > + > + ... > + > + display@0{ > + compatible = "sitronix,st7735r-jd-t18003-t01"; > + reg = <0>; > + spi-max-frequency = <32000000>; > + dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>; > + rotation = <270>; > + backlight = &backlight; > + };
On 12/08/2017 03:41 PM, Noralf Trønnes wrote: > > Den 29.11.2017 04.01, skrev David Lechner: >> This adds a new device tree binding for Sitronix ST7735R display panels, >> such as the Adafruit 1.8" TFT. >> >> Signed-off-by: David Lechner <david@lechnology.com> >> --- >> .../bindings/display/sitronix,st7735r.txt | 35 >> ++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> >> diff --git >> a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> new file mode 100644 >> index 0000000..bbb8ba6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> @@ -0,0 +1,35 @@ >> +Sitronix ST7735R display panels >> + >> +This binding is for display panels using a Sitronix ST7735R >> controller in SPI >> +mode. >> + >> +Required properties: >> +- compatible: "sitronix,st7735r-jd-t18003-t01" >> +- dc-gpios: Display data/command selection (D/CX) >> +- reset-gpios: Reset signal (RSTX) > > I'm wondering if this should be optional. > > Even though the display needs the reset line to be driven, it doesn't > have to be so by a gpio, I believe you can even get away with just > using a resistor as a reset circuit. > > Not terribly important, it's up to you. > It can be made optional later if needed, so I'm going to leave it as-is.
diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt new file mode 100644 index 0000000..bbb8ba6 --- /dev/null +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt @@ -0,0 +1,35 @@ +Sitronix ST7735R display panels + +This binding is for display panels using a Sitronix ST7735R controller in SPI +mode. + +Required properties: +- compatible: "sitronix,st7735r-jd-t18003-t01" +- dc-gpios: Display data/command selection (D/CX) +- reset-gpios: Reset signal (RSTX) + +The node for this driver must be a child node of a SPI controller, hence +all mandatory properties described in ../spi/spi-bus.txt must be specified. + +Optional properties: +- rotation: panel rotation in degrees counter clockwise (0,90,180,270) +- backlight: phandle of the backlight device attached to the panel + +Example: + + backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&gpio 44 GPIO_ACTIVE_HIGH>; + } + + ... + + display@0{ + compatible = "sitronix,st7735r-jd-t18003-t01"; + reg = <0>; + spi-max-frequency = <32000000>; + dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>; + rotation = <270>; + backlight = &backlight; + };
This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner <david@lechnology.com> --- .../bindings/display/sitronix,st7735r.txt | 35 ++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/sitronix,st7735r.txt