From patchwork Thu Feb 15 19:33:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10223475 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2EEC46055C for ; Thu, 15 Feb 2018 19:33:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F226294D2 for ; Thu, 15 Feb 2018 19:33:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 13F7F294D9; Thu, 15 Feb 2018 19:33:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8A898294D2 for ; Thu, 15 Feb 2018 19:33:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B3256E131; Thu, 15 Feb 2018 19:33:42 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on060a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::60a]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF2626E131 for ; Thu, 15 Feb 2018 19:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HPgP6vys6xq+PcGdMubrGpGQXt/62i1Fx2yPCP9kmdk=; b=Xf06FoUScXeOAwVKBUACXcmDGFVdluYjZJojp4Mll6D7lNYWHb7/GQQSpF6PqrsuqXKXm2zikUEj+WHlcRB+gT80kxMRfIPxuJLi6Ph8Nt/gKpRU60RGVPPsmzm4z35GryFRSNWQeKiP0W90qyhXaohsybUTjvq0OK+miZFforI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0801MB1256.eurprd08.prod.outlook.com (2603:10a6:4:a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Thu, 15 Feb 2018 19:33:37 +0000 From: Alexandru Gheorghe To: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH] drm: mali-dp: Report underrun and axi bus errors Date: Thu, 15 Feb 2018 19:33:15 +0000 Message-Id: <1518723195-16069-1-git-send-email-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: CWXP265CA0035.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:2d::23) To DB6PR0801MB1256.eurprd08.prod.outlook.com (2603:10a6:4:a::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 78052f37-1a8d-4850-081d-08d574ab02a7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR0801MB1256; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0801MB1256; 3:6DhB8ihujDJv1uhwKFBUkZRMnSUAY9uePptZtm/Vmnx3EbLPgrXjwF4l4D2OlKtDm2gsNBGwYKhJisPEAx+FxiU/GzkHmdUqFWCxA5VWutUThso82il0VNm41sP+9PCKT9+lbo8YwAx7g1BdB80lhXjwmiEm9ixxs54atrA2mv1rHs7is1kOm5yJ7uw1cQP30ZLtWbcdUwkJiyrrRtsfankeLmQMdWfJOdoC+s5DBRiySx7uQAtFkcy8g8o+tUmB; 25:H6ZEKVBd04LjmqhUy8J+Nh7MfuoYL933vyR6rcGZagB0gxwBtbFkH4YltA88ZQHM4ZQHhV2/qrqrZtSVgUSprQUnr3olPnStYLTvC3XfID5e0muNhck8OU/Qde4VCNniifEP2Ef+AUd/JCPO6/CFycEvX8C1pp4Poh1CrDqiqjWuxtATG03AFcVpX9ZtOy+S5STZhPzTfdiLUcJS3bPoMqs6QNSkXihrLI7vaigmly3Bcgddl0pFToyK+nYw5L5VT9QdfweYjp6FKUexZnXYwW7FQuQTkZ7sLUq7vpiRAScFW+VTm684zj98VSSFmH2HDJOoe5PNareuU1RFqdmKFw==; 31:mGzaHH6JC7M/q1JTeR5Fiqry1s5GI55TT4jV2BxGJubC4uhWskz1kCbb2tfhJu1TPwLIaloqRmjsMXKeQQ5HjJwUqNj+/IgW9LPhk0lvZJfsbDADXxdfIMsYcWef0tBj767W5hLjTfHjfXdY7nGMbiCfRag+lWLjoRm4Ef4jleKL4K2A/WJkrIABbLrpFE1XKA/CzcprT1Fv6KQ81oxXjtqCixglZrwScAnHcv1emKo= X-MS-TrafficTypeDiagnostic: DB6PR0801MB1256: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; DB6PR0801MB1256; 20:mni901Q56apxZJjPBGvLOBko+9m5atHbFOB0453S0L0mEutbIEdFIuaylEjJPpqQskyhhnCfK9oGjOjS5ypzvHvxiaXTPdUuoKpXw+TSNHe2ZUC7StWdsnlML7by268hW4saO+LCRDfJtFkPHxJdRI9Zf2vHaYF/zNS2DbSPdMo=; 4:YEykwzSvHyR8F9DlR7kGkpBqb4UXR8G99KUeBzoDYzhvOnAgEfj+PWv9oSqQR3sBduzpa2y7Bf8KiVtPY/GKVb7luUop5AFmEeev/OhxFjdpSUmuH6G/r00xBkDpJRC/y0+LPnGFNpSQOXgji7DIsOeOBUQBmJd7vJDRZ27duunWOHEaoxSfL293vhMI6XkYOZF/frKsMnnjoXktThirpsNJtibHG7NgDeVBLm9UwDr4x5minvrIlr9hd8SEWippwX+19+goPxNaOi4BuDvXfnRDyiK9qiUQOc3sNkH/uvrPwe/zfnBnmvOtc39TCeOi X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3231101)(944501161)(3002001)(93006095)(93001095)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:DB6PR0801MB1256; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0801MB1256; X-Forefront-PRVS: 058441C12A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(376002)(346002)(39860400002)(396003)(366004)(189003)(199004)(50466002)(26005)(7736002)(81166006)(81156014)(8676002)(6486002)(86362001)(72206003)(305945005)(6666003)(47776003)(6116002)(66066001)(3846002)(48376002)(2906002)(106356001)(25786009)(478600001)(4326008)(5660300001)(105586002)(316002)(68736007)(36756003)(52116002)(51416003)(7696005)(386003)(53936002)(16526019)(16586007)(1857600001)(8936002)(50226002)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0801MB1256; H:e114479-lin.cambridge.arm.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0801MB1256; 23:C64JseAMuK2Et9ElJGn9ID1sx6OCyyyELM/JYcf?= =?us-ascii?Q?AlEKVArg8Eu4Ix3++0++ohKsEP4JXY4hGRSyJMs+EMrZBfIHMk5sOJOP3Au5?= =?us-ascii?Q?i1q41HX/anf0m98G40lWbj4k8v6sGMFE3g/DFV7QlosfS0pYdGPXPIX3dPbW?= =?us-ascii?Q?9SmQfUjq2JJpC9rH0b183fsTewhAQLAuoc5jk0Oghzz9m53cP8/EfNxnYB8D?= =?us-ascii?Q?JQ3V3HpBnSAZcjRuLSkCMLZuadBYDGPw7yHlOgFo0RqUG29r8tXPHcelSOJe?= =?us-ascii?Q?n2kFh0WKpa4U9LqfrTjl/n5q2OJvmwlvqTNc/9Iz5vWBvc5WAvkLsqFI5ioE?= =?us-ascii?Q?c7QMsrnBFcRtroKZiUK9GbjuOKfWwk/J9xqzzdO0rqnnXcDPvCg0+XGni+pu?= =?us-ascii?Q?h0bpJP8fJ6ywZydVTPOV2J/y06Ozou/aNLfCXdzS0M/19LNB2wXFyq/fcZqr?= =?us-ascii?Q?n8+LlT1XM5+jYxsFUYyDtESJjof/Rr0q9y8P6i0LJuk7H4ZUD+mX9EDfSCtY?= =?us-ascii?Q?Fo5EvTdjqd8NRgwnGaoH8GTLckJjk8KqmG9WGM9w3s7hf/Wzx8chfhVe4mxf?= =?us-ascii?Q?vJtYpy3vx862AXeaJfZcG4FZ+XcFMVUrrhLyXN6sEu8IV7v75idlQZXB2xUY?= =?us-ascii?Q?o+ukM59yZtdEo34UKD30l9HhS4bMOO25J6rMjH01zlPhgl7t6MYGTKxF/Win?= =?us-ascii?Q?MKkMWTRUhXRQQ51piVZkAWEwMRtPHKTF8XFCTI6Sh2j/JdV8eQGR6goTx/Ed?= =?us-ascii?Q?xF7f3Vc3JJVEzOyPV4CFy6lJlQk/USG3jahepJUGI91u1MeRnj4hrX5N+/1O?= =?us-ascii?Q?ReUGzXO6e7coQ4MUIiNXYPzH9ASIloXmD/X2lBUG2my2cKepMo/nEVfFN7P+?= =?us-ascii?Q?NvdFD6Z/GsbHJ3plmiap3zxUt4xkIae0Gh7cv/Fwor/proeCtHz/4DXayJj4?= =?us-ascii?Q?zgeRrUA/5+H5yZ026k31qkVzLzC4Qsn7TAAqCFo9a6RU2/SqMQge8auPBmiL?= =?us-ascii?Q?sd2lsqCKI8e+ObA7LxH6klf44n3ZKUvXJYaaZUSvAS3Gf17DDTOiqJML8O7p?= =?us-ascii?Q?ceo/7S9s=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0801MB1256; 6:bh8Sp88iKnrPy2EfzAXIVS8pFcTmdCnzbqarex4rLOFQnXUz8WEQwd4vW79/mg8XU+nrnJRsJX6JVwzrl9qorM+mpw/Sev58CuyYuRqpl2j+pumvKPffLIBgFAFEGJje8EDxVjemf5dPvZ7+nUQPCSEme49UbZ3wyhJY24GzsnHFbuVwfHBT3W9udS189MpjYJxs78Re0BPzyasv+L0GzBj+PCD8WYG/RNkP5OReMfUHJT4pXjNUewJmnZvXnwLnqzeSQItNCmbM4bsEnBbsZLDzI6mImRER6k1LD4KxcwWCwnZo5WUZnTCQIZkYORuhr2AdqRHhNm2iYihj8BMzAu1Prsq+I7FH//DYVbpQEP8=; 5:huqLRco+Yudo0bzRRtglWLK5fqNu/+/cUzaHvTWaoEi3IHStFjU7quG7J7OwcFG0djyaLASSYv5w8gq8na7djh43LGFwaIeCi11hSLnL8ISuTNsOmiiLsPiA7PdN2XrXMkqqn5ltYwrvINjuQBXPDcXba6M8AAMm0n1664yQiAY=; 24:TV3tMJkvrsWmSk0FhdGYH1y06BkBMCnKpjAAKcmefPuTIvhvqvEz1GenUj7iomtbwHAgl211VNNDPic9BJWiXWuofF6HpFv8AaUNvExEFEQ=; 7:QYCGmy919bR/sOSxd9wtB0B6GCVM5GyAFsP0W+1lJ1ppDzMCRSIXTRYJNxVGDFltLaGGfQ7stnr/9zSowntCsaMoO9tTM55NYKD2IZp25zAEH0AMnAAwO+6w8dZnFHYgX81CqojytoQfSaCmP2XRXDQXsN80iAX3w0GqvEVUs5NrCMo0g2ZtZiiSI7ZgTgIgmXWP60waVSliVYgh3A5KbW0MNURSKeqLKRqn2nhLMy/GRxqNP6gwxrmvQH+WY8ro SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2018 19:33:37.2711 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78052f37-1a8d-4850-081d-08d574ab02a7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1256 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Alexandru Gheorghe Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Errors will be reported in /sys/kernel/debug/tracing/trace, still not noisy enough, but better than silently ignoring them. E.g: -0 [000] d.h1 183.851864: malidp_de_irq: error occurred DE_STATUS is 0x00000001 surfaceflinger-803 [000] d.h1 197.993003: malidp_de_irq: error occurred DE_STATUS is 0x00000001 surfaceflinger-803 [000] d.h1 213.595119: malidp_de_irq: error occurred DE_STATUS is 0x00000001 surfaceflinger-803 [000] d.h. 217.754371: malidp_de_irq: error occurred DE_STATUS is 0x00000001 surfaceflinger-803 [000] d.h. 217.820848: malidp_de_irq: error occurred DE_STATUS is 0x00000001 surfaceflinger-803 [000] d.h. 217.854034: malidp_de_irq: error occurred DE_STATUS is 0x00000001 Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_hw.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c index 2bfb542..8e7d49f 100644 --- a/drivers/gpu/drm/arm/malidp_hw.c +++ b/drivers/gpu/drm/arm/malidp_hw.c @@ -797,6 +797,9 @@ static irqreturn_t malidp_de_irq(int irq, void *arg) if (status & de->vsync_irq) drm_crtc_handle_vblank(&malidp->crtc); + if (status & ~de->vsync_irq & de->irq_mask) + trace_printk("error occurred DE_STATUS is 0x%08X\n", status); + malidp_hw_clear_irq(hwdev, MALIDP_DE_BLOCK, status); return (ret == IRQ_NONE) ? IRQ_HANDLED : ret; @@ -880,6 +883,9 @@ static irqreturn_t malidp_se_irq(int irq, void *arg) status &= mask; /* ToDo: status decoding and firing up of VSYNC and page flip events */ + if (status & ~se->vsync_irq & se->irq_mask) + trace_printk("error occurred SE_STATUS is 0x%08X\n", status); + malidp_hw_clear_irq(hwdev, MALIDP_SE_BLOCK, status); return IRQ_HANDLED;