From patchwork Thu Feb 22 16:02:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10235833 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3B1FE602DC for ; Thu, 22 Feb 2018 16:03:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3340828B0F for ; Thu, 22 Feb 2018 16:03:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2753A28E43; Thu, 22 Feb 2018 16:03:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8806728B0F for ; Thu, 22 Feb 2018 16:03:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C3DD96EE6C; Thu, 22 Feb 2018 16:03:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0060.outbound.protection.outlook.com [104.47.0.60]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6DB7D6EE6C for ; Thu, 22 Feb 2018 16:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=19PJ+7wQJ+JmyNovTMkV2+JLiKutQ5obB0ehU6ZQXBs=; b=D7zVZgDSVivGGeVSeBxrb8DaXW7W7CDt31U0br3D/SYKig09a72jlpheBsGpluxlzl/SF54Itttzm0PvtXNy3RQqYogfug6WYzyYk08ZHbV7AHh/KkOOXIN2q+dgwUj+SZIPNJVX8hQ9oHdj9u+b4GHOtBQhO1LJF6XA6DtJsyg= Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by HE1PR0801MB1258.eurprd08.prod.outlook.com (2603:10a6:3:39::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Thu, 22 Feb 2018 16:03:13 +0000 From: Alexandru Gheorghe To: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH] drm: mali-dp: Log internal errors Date: Thu, 22 Feb 2018 16:02:37 +0000 Message-Id: <1519315357-9245-1-git-send-email-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: HE1PR09CA0050.eurprd09.prod.outlook.com (2603:10a6:7:3c::18) To HE1PR0801MB1258.eurprd08.prod.outlook.com (2603:10a6:3:39::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 93812e23-f1b0-41ad-1e6d-08d57a0dc704 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR0801MB1258; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1258; 3:sI01dIXEEzyEU6j/sb7D4frhuIiMw+mj0T+7//RAzsF0s507Z5k+mCTVbRmcXERqd3U8uznkCJa3JQE4BOoVUIlrAtsjQMYQmZMxA2o/M/7hyBR4G/rmZlVq0oAl1HNKO4mYLyY+Z4B1PawY884KlbArO0vZXkxQG46PojE8b6u9XvYCa+JktVJBHAb5Xv4kMCYfHhMfeZ7kMtv9rYwLuSWtYeDvN8LIKcf92P6UFvidDxflHNeOHidF4CinhsxU; 25:oLdWnJ5TGKJLivlP2dgVqfLGL0Wf8+L59LTQe4qeqN8vOT1gs9LbOB9lqHQCbsmnAFQdENBoTkYcZlvjLYmtKTJUvmVSdsypPmOzCKaG3UEZbbpObSLJAXab1Ld8jRAE0BRKCQBy45OQtQC+KUNegv7cazXSaRFlihMgQVRNfJS7VAEzwzZkVBhjSNx3nSEJNcDoNjCpCUledaIVKyamuc57xqsBVj7ojSN1WbWaVPYDaxwvYQVUDW3A+QMxfGb3bQbnGAxXXtEHcSRW00FMQ1pP/vaOMFhMBKO62iyrFwQRZciYATJf/fcuiTsFhFVbBmEhB9bSZklOBr68lDV6gA==; 31:CIfQ0KMEF1NX6E0SfVgZQsgzr7mjEBtW3n+eLRAApVA7SgJj9O4lb7aU9AxGRZsy0fi/yvXRmKLMTDIUdvrDfj5uoKre/2bGPWgrTq6aOa/5RLh8W495fIdTmRqAeflGu29HFJf5E7BOeF2Vh9wTwBPUMT/GZWxd7L1LvSsoAuC3/zHMIIuH6y5tC57lTwq7FFKXSz8KJ8kFJG01Nz40ivqKw1aUiEv934Ga/XFhZ1E= X-MS-TrafficTypeDiagnostic: HE1PR0801MB1258: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1258; 20:3PD4KZUyBqF57/exABw4pAWEi4824hxRetMB27Yofxi+0ZV82/N1R8YShDMIRfpLrw85MqtwxZAuDoNGYj27uz+45uYN602V1Wo4gtEie5Cq+JqRugbM20wW/86KQt77CB5N1C6f09/FGkPN611a9uiyM4n8fNMdvnp8nGb+gqo=; 4:P+0HmC3IM5UCRbi4PWRXUIbzYWQVFPdPyK4aLwbfn0BN8Rwylt99YL4/yQJQN/DtIH6dOV2rY4NSJtXGBn5RriL2YZKAK7cfBAZegaTfjutXw81C55SxZr/FRRxMuvQNAMHEXIG4qe5BAyPzytdirjsjZFEn3LC05TVSOV6PYdcCObtIhW2dBT7Y8/HsXuNU+RSo/XQsXBlH6bD69/1VByNdokyZgYwbKe0wsIchvlMXGnEtbGampeZKp9v5DqaIDFteJRHbGyuNPAqXef3Ye6VefpBWn6zVWAQ/LgCTegjCEOhyIZBddDeEkKvZnfeeVgTwlqDq/AZN1d9QdhMTJUms6KwUTSzVZqAYaKBA9Bzg5XkLz01Ao9Y/3HiFnNGO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(211171220733660)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001080)(6040501)(2401047)(5005006)(8121501046)(10201501046)(3231162)(944501161)(52105095)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:HE1PR0801MB1258; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB1258; X-Forefront-PRVS: 059185FE08 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(39380400002)(366004)(346002)(396003)(199004)(189003)(48376002)(50466002)(106356001)(316002)(16586007)(68736007)(6116002)(3846002)(25786009)(47776003)(105586002)(81156014)(8676002)(8936002)(81166006)(4326008)(2906002)(305945005)(51416003)(52116002)(7696005)(26005)(6346003)(16526019)(7736002)(1857600001)(50226002)(5660300001)(386003)(97736004)(66066001)(53936002)(6486002)(86362001)(72206003)(36756003)(6666003)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1258; H:e114479-lin.cambridge.arm.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0801MB1258; 23:yv+KE63PoV72K5gLFIMHbzU/9WEzo0i9jdHb7e4?= =?us-ascii?Q?UWUJ0mgzwL7hYd3icDNRbAnhwcrwc5j9kqZ94eey+iULyfOVdWlo/4iEsqUp?= =?us-ascii?Q?W4mjvfYefDNeQgZPdZ2GZ/a+hAixCSsPPofp4LWpdzom07kc4zRNOnXCElm4?= =?us-ascii?Q?7jgiYyeQ5QYJnfYTZCsEgv5jlsk03EbXxc1e87pOk7rJV158icJOA7MuW4Ow?= =?us-ascii?Q?TEeivySVBXAVN9p+xY3VfebteGfsYcxcl28YdqdobtTgr8RM9VRr2s9QHF5V?= =?us-ascii?Q?TYfp+f3x/3GEJLPrVObLi7R18TEsKJnBdMwuw8CQbR5IPK5L5dwsOmTL8+sQ?= =?us-ascii?Q?K9nSegPyYsSOkWL+VV4pi9Ra1t06FVI34N+sHtwiUpzcltwcLu4DwkRiBE1S?= =?us-ascii?Q?Lh8/FBc8xTWpoafSZHpO8Q8NR3B7gDzYMbtKrSb4P+QXDs9LFdhQWTHOmp9j?= =?us-ascii?Q?0SjDPH6KzVXebPyP6YyiFaNJKWrrjmGxVDeV3Ziuhe6kln6PzSyFroagCzhx?= =?us-ascii?Q?fDG1CKPcoQUO8gFY8LaZM5aeyLkDu4bxShT/EIFHUxjt2hA4bnbRCXU0hzlE?= =?us-ascii?Q?dmwWYQxvQcMOOwr4YXTY0N8lMljiGM2WX+AIxTprecGUAx1VD5zTizxg4KHg?= =?us-ascii?Q?4MCR2LL8BBwhKMcFHlrb79XXxsZ8ZJ2LRgWTz8fTwgdrLKFX6Spn+gD8gMLm?= =?us-ascii?Q?Lg/jGROcg56HKpGBfSeS5yI05aC+ZNMirMj0y1Z+yr2kE/HtGWu/ZPCuqA9h?= =?us-ascii?Q?r0X6bhlRRo30e8ooHy8+cVo+T4uOu1uQMt0HRP8e50fZIsOdfKFGSbUgOfcY?= =?us-ascii?Q?T8kn7mUZgoQuexB5YGzrVCVQNoPM836tUcJWFsIOMjNo8tCVy9AXEg4nU4IT?= =?us-ascii?Q?YIkHAcC4PyEpF3OaT7YiF+VNUvb7Xp5p5wUGAGDBAPZU2MmRloYR07Dp0877?= =?us-ascii?Q?qGXkQ1URTAAozQJVw9L1bsu/jAGArdBMgcMk8Lac0b2QA6rcnOnA8d0U7riU?= =?us-ascii?Q?AjDuGTTZ74pvMNhk+KI9ZD55w/Z+T90Lzd9dr9N3JdWmKgDUroJh+UuDk+LP?= =?us-ascii?Q?HysPYxy0=3D?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1258; 6:TRQ4cmUd34Ajz7QnHgDWvELf7j4JvtTAQ+5Ec+/PFrCDdSKW+ubNyVH1OSA1dOGstGh9x+Y6MKLmhoJp0EJJjV3Jt8Cf2lcD76BxmxmHCKv1PoPKAPwv01Ag6qvk9x6YKpneSwjKVK3mP+PrN5z45f5BUfDCEMk+SV8mlW39BKli+t8mq0DvD4wyQ7tvR65azK/8CQvxRhNnsAqDCvaLHMKuwQNs3ZKQfWGhV4QmII/NJuQAvCGNvGzvqv/wqRFhmyoOPBDZqh6VBu2x3hS2/wAUU4ymHmT1qKqgxyoCceTr9bJ7Tiu6MEuJsIgvmuKpd3oe06o+V9MYk2yV+wqsbB+5jKiAb9lIDqNmSZuV70M=; 5:UzeKTn0OPZt7hn1zOXPR3J4zZAStdATjFCLE56Vg/2IRnyzWXmoThdH1dM634mdcvfOxFqO63I8I6I1kQr4f+z6qxVdI8jSD4P8aOVqVfqpbKQO9+zUx4+RFWOeXpEsiJ6uXRztwBzMGL7A0JvBfqrPqrP/5weGTTLhJC7qub1s=; 24:iVjQc8UkcZby+gWhcGu45LUaPKXbYiYm5PecrxkcO3VId7msFvQWg89mHtiy5snLI+Xx9PNZJCXyYd4TyqxKa7VZqS5hsZiXIXZgcV5DqHs=; 7:ERKlobQQbZ3v9fA85txnUdhSi6mhTYTQRI9OeVY92qO/LNJ1kLG6E9b+ryWVoiqb3/ECCmcZL9LyYWZVJLluIyftK+rrCeX1n/NHwZ6clv+WAoontNt7JRJmJUF6LiBB746pF4Dh6emtbBvgWpuliZ3BSQd4k+O2S1uZhFvjukxilBIXZ/YGf/08QDE9Bo4e/Aev9SoVCMljW9nYUPdHq3eIMObCYC3Mh1npfY7cKn7qLVCY4uO51mSwxBMMctn9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2018 16:03:13.0361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93812e23-f1b0-41ad-1e6d-08d57a0dc704 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1258 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Alexandru Gheorghe Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Alexandru Gheorghe Status register contains a lot of bits for reporting internal errors inside mali-dp. Currently, we just silently ignore all of the erorrs, that doesn't help when we are investigating different bugs, especially on the FPGA models which have a lot of constrains, so we could easily end up in AXI or underrun errors. Add a new KConfig option called CONFIG_DRM_MALI_DISPLAY_DEBUG, which enables the logging of the errors present in the status register. Errors will be reported in /sys/kernel/debug/tracing/trace, still not noisy enough, but better than silently ignoring them. E.g: -0 [000] d.h1 2387.240042: malidp_de_irq: error occurred at vblank 596 DE_STATUS is 0x00000001 -0 [000] d.h1 2387.256703: malidp_de_irq: error occurred at vblank 597 DE_STATUS is 0x00000001 -0 [000] d.h1 2387.273458: malidp_de_irq: error occurred at vblank 598 DE_STATUS is 0x00000001 -0 [000] d.h1 2387.290035: malidp_de_irq: error occurred at vblank 599 DE_STATUS is 0x00000001 In addition to that, I removed the setting of MALIDP550_SE_IRQ_AXI_ERR bit in the irq_mask, since that bit doesn't exist. Signed-off-by: Alexandru Gheorghe Acked-by: Liviu Dudau --- drivers/gpu/drm/arm/Kconfig | 10 +++++++++ drivers/gpu/drm/arm/malidp_hw.c | 45 ++++++++++++++++++++++++++++++++------- drivers/gpu/drm/arm/malidp_hw.h | 1 + drivers/gpu/drm/arm/malidp_regs.h | 6 ++++++ 4 files changed, 54 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 9a18e1b..c1e6fc8 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -40,3 +40,13 @@ config DRM_MALI_DISPLAY of the hardware. If compiled as a module it will be called mali-dp. + +config DRM_MALI_DISPLAY_DEBUG + bool "Enable mali display debugging" + default n + depends on DRM_MALI_DISPLAY + select FTRACE + help + Enable this option to log internal errors that happened during + processing of a frame. Errors will be reported in + /sys/kernel/debug/tracing/trace. diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c index 2bfb542..7d3b2e2 100644 --- a/drivers/gpu/drm/arm/malidp_hw.c +++ b/drivers/gpu/drm/arm/malidp_hw.c @@ -632,10 +632,16 @@ const struct malidp_hw malidp_device[MALIDP_MAX_DEVICES] = { MALIDP500_DE_IRQ_VSYNC | MALIDP500_DE_IRQ_GLOBAL, .vsync_irq = MALIDP500_DE_IRQ_VSYNC, + .err_mask = MALIDP_DE_IRQ_UNDERRUN | + MALIDP500_DE_IRQ_AXI_ERR | + MALIDP500_DE_IRQ_SATURATION, }, .se_irq_map = { .irq_mask = MALIDP500_SE_IRQ_CONF_MODE, .vsync_irq = 0, + .err_mask = MALIDP500_SE_IRQ_INIT_BUSY | + MALIDP500_SE_IRQ_AXI_ERROR | + MALIDP500_SE_IRQ_OVERRUN, }, .dc_irq_map = { .irq_mask = MALIDP500_DE_IRQ_CONF_VALID, @@ -669,10 +675,15 @@ const struct malidp_hw malidp_device[MALIDP_MAX_DEVICES] = { .irq_mask = MALIDP_DE_IRQ_UNDERRUN | MALIDP550_DE_IRQ_VSYNC, .vsync_irq = MALIDP550_DE_IRQ_VSYNC, + .err_mask = MALIDP_DE_IRQ_UNDERRUN | + MALIDP550_DE_IRQ_SATURATION | + MALIDP550_DE_IRQ_AXI_ERR, }, .se_irq_map = { - .irq_mask = MALIDP550_SE_IRQ_EOW | - MALIDP550_SE_IRQ_AXI_ERR, + .irq_mask = MALIDP550_SE_IRQ_EOW, + .err_mask = MALIDP550_SE_IRQ_AXI_ERR | + MALIDP550_SE_IRQ_OVR | + MALIDP550_SE_IRQ_IBSY, }, .dc_irq_map = { .irq_mask = MALIDP550_DC_IRQ_CONF_VALID, @@ -707,10 +718,20 @@ const struct malidp_hw malidp_device[MALIDP_MAX_DEVICES] = { MALIDP650_DE_IRQ_DRIFT | MALIDP550_DE_IRQ_VSYNC, .vsync_irq = MALIDP550_DE_IRQ_VSYNC, + .err_mask = MALIDP_DE_IRQ_UNDERRUN | + MALIDP650_DE_IRQ_DRIFT | + MALIDP550_DE_IRQ_SATURATION | + MALIDP550_DE_IRQ_AXI_ERR | + MALIDP650_DE_IRQ_ACEV1 | + MALIDP650_DE_IRQ_ACEV2 | + MALIDP650_DE_IRQ_ACEG | + MALIDP650_DE_IRQ_AXIEP, }, .se_irq_map = { - .irq_mask = MALIDP550_SE_IRQ_EOW | - MALIDP550_SE_IRQ_AXI_ERR, + .irq_mask = MALIDP550_SE_IRQ_EOW, + .err_mask = MALIDP550_SE_IRQ_AXI_ERR | + MALIDP550_SE_IRQ_OVR | + MALIDP550_SE_IRQ_IBSY, }, .dc_irq_map = { .irq_mask = MALIDP550_DC_IRQ_CONF_VALID, @@ -793,10 +814,15 @@ static irqreturn_t malidp_de_irq(int irq, void *arg) return ret; mask = malidp_hw_read(hwdev, MALIDP_REG_MASKIRQ); - status &= mask; + /* keep the status of the enabled interrupts, plus the error bits */ + status &= (mask | de->err_mask); if (status & de->vsync_irq) drm_crtc_handle_vblank(&malidp->crtc); - +#ifdef CONFIG_DRM_MALI_DISPLAY_DEBUG + if (status & de->err_mask) + trace_printk("error occurred at vblank %llu DE_STATUS is 0x%08X\n", + drm_crtc_vblank_count(&malidp->crtc), status); +#endif malidp_hw_clear_irq(hwdev, MALIDP_DE_BLOCK, status); return (ret == IRQ_NONE) ? IRQ_HANDLED : ret; @@ -874,9 +900,12 @@ static irqreturn_t malidp_se_irq(int irq, void *arg) status = malidp_hw_read(hwdev, hw->map.se_base + MALIDP_REG_STATUS); if (!(status & se->irq_mask)) return IRQ_NONE; - +#ifdef CONFIG_DRM_MALI_DISPLAY_DEBUG + if (status & se->err_mask) + trace_printk("error occurred at vblank %llu SE_STATUS is 0x%08X\n", + drm_crtc_vblank_count(&malidp->crtc), status); +#endif mask = malidp_hw_read(hwdev, hw->map.se_base + MALIDP_REG_MASKIRQ); - status = malidp_hw_read(hwdev, hw->map.se_base + MALIDP_REG_STATUS); status &= mask; /* ToDo: status decoding and firing up of VSYNC and page flip events */ diff --git a/drivers/gpu/drm/arm/malidp_hw.h b/drivers/gpu/drm/arm/malidp_hw.h index b0690eb..909b76e 100644 --- a/drivers/gpu/drm/arm/malidp_hw.h +++ b/drivers/gpu/drm/arm/malidp_hw.h @@ -52,6 +52,7 @@ struct malidp_format_id { struct malidp_irq_map { u32 irq_mask; /* mask of IRQs that can be enabled in the block */ u32 vsync_irq; /* IRQ bit used for signaling during VSYNC */ + u32 err_mask; /* mask of bits in status register that represent errors */ }; struct malidp_layer { diff --git a/drivers/gpu/drm/arm/malidp_regs.h b/drivers/gpu/drm/arm/malidp_regs.h index 2039f85..ec53811 100644 --- a/drivers/gpu/drm/arm/malidp_regs.h +++ b/drivers/gpu/drm/arm/malidp_regs.h @@ -53,6 +53,8 @@ #define MALIDP550_DE_IRQ_AXI_ERR (1 << 16) #define MALIDP550_SE_IRQ_EOW (1 << 0) #define MALIDP550_SE_IRQ_AXI_ERR (1 << 16) +#define MALIDP550_SE_IRQ_OVR (1 << 17) +#define MALIDP550_SE_IRQ_IBSY (1 << 18) #define MALIDP550_DC_IRQ_CONF_VALID (1 << 0) #define MALIDP550_DC_IRQ_CONF_MODE (1 << 4) #define MALIDP550_DC_IRQ_CONF_ACTIVE (1 << 16) @@ -60,6 +62,10 @@ #define MALIDP550_DC_IRQ_SE (1 << 24) #define MALIDP650_DE_IRQ_DRIFT (1 << 4) +#define MALIDP650_DE_IRQ_ACEV1 (1 << 17) +#define MALIDP650_DE_IRQ_ACEV2 (1 << 18) +#define MALIDP650_DE_IRQ_ACEG (1 << 19) +#define MALIDP650_DE_IRQ_AXIEP (1 << 28) /* bit masks that are common between products */ #define MALIDP_CFG_VALID (1 << 0)