diff mbox

[hwc,v2,01/18] drm_hwcomposer: vsyncworker: Fix uninitialized enabled_ field

Message ID 1523460149-1740-2-git-send-email-alexandru-cosmin.gheorghe@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alexandru-Cosmin Gheorghe April 11, 2018, 3:22 p.m. UTC 
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
---
 vsyncworker.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Robert Foss April 16, 2018, 10:30 a.m. UTC | #1 
Hey Alexandru,

Feel free to add:
Signed-off-by: Robert Foss <robert.foss@collabora.com>


Rob.

On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote:
> Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> ---
>   vsyncworker.cpp | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/vsyncworker.cpp b/vsyncworker.cpp
> index 3ad16fe..3bfe4be 100644
> --- a/vsyncworker.cpp
> +++ b/vsyncworker.cpp
> @@ -35,6 +35,7 @@ VSyncWorker::VSyncWorker()
>       : Worker("vsync", HAL_PRIORITY_URGENT_DISPLAY),
>         drm_(NULL),
>         display_(-1),
> +      enabled_(false),
>         last_timestamp_(-1) {
>   }
>   
>
Alexandru-Cosmin Gheorghe April 16, 2018, 12:18 p.m. UTC | #2 
On Mon, Apr 16, 2018 at 12:30:13PM +0200, Robert Foss wrote:

Hi Rob,

Thanks for the review.

> Hey Alexandru,
> 
> Feel free to add:
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>

Should I re-send this 3 patches or could you just pushed them to
master and adding your SoB in the process?
 
> 
> Rob.
> 
> On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote:
> >Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> >---
> >  vsyncworker.cpp | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/vsyncworker.cpp b/vsyncworker.cpp
> >index 3ad16fe..3bfe4be 100644
> >--- a/vsyncworker.cpp
> >+++ b/vsyncworker.cpp
> >@@ -35,6 +35,7 @@ VSyncWorker::VSyncWorker()
> >      : Worker("vsync", HAL_PRIORITY_URGENT_DISPLAY),
> >        drm_(NULL),
> >        display_(-1),
> >+      enabled_(false),
> >        last_timestamp_(-1) {
> >  }
> >
Sean Paul April 17, 2018, 1:45 p.m. UTC | #3 
On Mon, Apr 16, 2018 at 01:18:53PM +0100, Alexandru-Cosmin Gheorghe wrote:
> On Mon, Apr 16, 2018 at 12:30:13PM +0200, Robert Foss wrote:
> 
> Hi Rob,
> 
> Thanks for the review.
> 
> > Hey Alexandru,
> > 
> > Feel free to add:
> > Signed-off-by: Robert Foss <robert.foss@collabora.com>
> >
> 
> Should I re-send this 3 patches or could you just pushed them to
> master and adding your SoB in the process?

I've pushed patches 1 & 3 with Robert's Ack. I'll review the rest this morning
at which time you can send a v2 with the unapplied patches. Alternatively, if
you want to try out the new gitlab flow, you can send v2 via a merge request
there.

Sean

>  
> > 
> > Rob.
> > 
> > On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote:
> > >Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> > >---
> > >  vsyncworker.cpp | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > >diff --git a/vsyncworker.cpp b/vsyncworker.cpp
> > >index 3ad16fe..3bfe4be 100644
> > >--- a/vsyncworker.cpp
> > >+++ b/vsyncworker.cpp
> > >@@ -35,6 +35,7 @@ VSyncWorker::VSyncWorker()
> > >      : Worker("vsync", HAL_PRIORITY_URGENT_DISPLAY),
> > >        drm_(NULL),
> > >        display_(-1),
> > >+      enabled_(false),
> > >        last_timestamp_(-1) {
> > >  }
> > >
> 
> -- 
> Cheers,
> Alex G
Alexandru-Cosmin Gheorghe April 17, 2018, 2:09 p.m. UTC | #4 
On Tue, Apr 17, 2018 at 09:45:06AM -0400, Sean Paul wrote:
> On Mon, Apr 16, 2018 at 01:18:53PM +0100, Alexandru-Cosmin Gheorghe wrote:
> > On Mon, Apr 16, 2018 at 12:30:13PM +0200, Robert Foss wrote:
> > 
> > Hi Rob,
> > 
> > Thanks for the review.
> > 
> > > Hey Alexandru,
> > > 
> > > Feel free to add:
> > > Signed-off-by: Robert Foss <robert.foss@collabora.com>
> > >
> > 
> > Should I re-send this 3 patches or could you just pushed them to
> > master and adding your SoB in the process?
> 
> I've pushed patches 1 & 3 with Robert's Ack. I'll review the rest this morning
> at which time you can send a v2 with the unapplied patches. Alternatively, if
> you want to try out the new gitlab flow, you can send v2 via a merge request
> there.

Thanks.

I'm all for trying new things. So, I will give gitlab flow a chance.

> 
> Sean
> 
> >  
> > > 
> > > Rob.
> > > 
> > > On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote:
> > > >Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> > > >---
> > > >  vsyncworker.cpp | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > >diff --git a/vsyncworker.cpp b/vsyncworker.cpp
> > > >index 3ad16fe..3bfe4be 100644
> > > >--- a/vsyncworker.cpp
> > > >+++ b/vsyncworker.cpp
> > > >@@ -35,6 +35,7 @@ VSyncWorker::VSyncWorker()
> > > >      : Worker("vsync", HAL_PRIORITY_URGENT_DISPLAY),
> > > >        drm_(NULL),
> > > >        display_(-1),
> > > >+      enabled_(false),
> > > >        last_timestamp_(-1) {
> > > >  }
> > > >
> > 
> > -- 
> > Cheers,
> > Alex G
> 
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
diff mbox

Patch

diff --git a/vsyncworker.cpp b/vsyncworker.cpp
index 3ad16fe..3bfe4be 100644
--- a/vsyncworker.cpp
+++ b/vsyncworker.cpp
@@ -35,6 +35,7 @@  VSyncWorker::VSyncWorker()
     : Worker("vsync", HAL_PRIORITY_URGENT_DISPLAY),
       drm_(NULL),
       display_(-1),
+      enabled_(false),
       last_timestamp_(-1) {
 }