mbox series

[GIT,PULL] etnaviv-next for 4.21

Message ID 1544784250.3137.43.camel@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL] etnaviv-next for 4.21 | expand

Pull-request

https://git.pengutronix.de/git/lst/linux etnaviv/next

Message

Lucas Stach Dec. 14, 2018, 10:44 a.m. UTC
Hi Dave,

nothing major this time, mostly some cleanups that were found on the
way of reworking the code in preparation for new feature additions.

Regards,
Lucas

The following changes since commit 6fce3a406108ee6c8a61e2a33e52e9198a626ea0:

  drm/etnaviv: fix bogus fence complete check in timeout handler (2018-11-05 18:14:48 +0100)

are available in the Git repository at:

  https://git.pengutronix.de/git/lst/linux etnaviv/next

for you to fetch changes up to dea492e0cfcbe8ca592406fefc7ceeaf53f63380:

  drm/etnaviv: remove lastctx member from gpu struct (2018-12-11 12:35:07 +0100)

----------------------------------------------------------------
Lucas Stach (5):
      drm/etnaviv: kill active fence tracking
      drm/etnaviv: consolidate hardware fence handling in etnaviv_gpu
      drm/etnaviv: remove unnecessary local irq disable
      drm/etnaviv: replace header include with forward declaration
      drm/etnaviv: remove lastctx member from gpu struct

Thomas Zimmermann (1):
      drm/etnaviv: Replace drm_dev_unref with drm_dev_put

 drivers/gpu/drm/etnaviv/etnaviv_buffer.c |  2 --
 drivers/gpu/drm/etnaviv/etnaviv_drv.c    | 16 +++++-----------
 drivers/gpu/drm/etnaviv/etnaviv_drv.h    | 11 -----------
 drivers/gpu/drm/etnaviv/etnaviv_gpu.c    | 37 ++++++++++++++++---------------------
 drivers/gpu/drm/etnaviv/etnaviv_gpu.h    | 12 ++----------
 5 files changed, 23 insertions(+), 55 deletions(-)

Comments

Daniel Vetter Dec. 14, 2018, 10:11 p.m. UTC | #1
On Fri, Dec 14, 2018 at 11:44:10AM +0100, Lucas Stach wrote:
> Hi Dave,
> 
> nothing major this time, mostly some cleanups that were found on the
> way of reworking the code in preparation for new feature additions.

dim: dea492e0cfcbe8ca592406fefc7ceeaf53f63380 is lacking review
dim: ead5bd82cc3785e68d83cb6a3922e6c91de454e3 is lacking review
dim: 2ef0ebf5cc6b4b40999fe64de1a39c7c68068ecf is lacking review

First two are simple enough that I'm not too lazy to review them, but 3rd
looks like not entirely trivial.  Please get one of the other etnaviv
folks to ack it.

Thanks, Daniel

> 
> Regards,
> Lucas
> 
> The following changes since commit 6fce3a406108ee6c8a61e2a33e52e9198a626ea0:
> 
>   drm/etnaviv: fix bogus fence complete check in timeout handler (2018-11-05 18:14:48 +0100)
> 
> are available in the Git repository at:
> 
>   https://git.pengutronix.de/git/lst/linux etnaviv/next
> 
> for you to fetch changes up to dea492e0cfcbe8ca592406fefc7ceeaf53f63380:
> 
>   drm/etnaviv: remove lastctx member from gpu struct (2018-12-11 12:35:07 +0100)
> 
> ----------------------------------------------------------------
> Lucas Stach (5):
>       drm/etnaviv: kill active fence tracking
>       drm/etnaviv: consolidate hardware fence handling in etnaviv_gpu
>       drm/etnaviv: remove unnecessary local irq disable
>       drm/etnaviv: replace header include with forward declaration
>       drm/etnaviv: remove lastctx member from gpu struct
> 
> Thomas Zimmermann (1):
>       drm/etnaviv: Replace drm_dev_unref with drm_dev_put
> 
>  drivers/gpu/drm/etnaviv/etnaviv_buffer.c |  2 --
>  drivers/gpu/drm/etnaviv/etnaviv_drv.c    | 16 +++++-----------
>  drivers/gpu/drm/etnaviv/etnaviv_drv.h    | 11 -----------
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c    | 37 ++++++++++++++++---------------------
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.h    | 12 ++----------
>  5 files changed, 23 insertions(+), 55 deletions(-)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter Dec. 17, 2018, 9:50 a.m. UTC | #2
On Fri, Dec 14, 2018 at 11:11:05PM +0100, Daniel Vetter wrote:
> On Fri, Dec 14, 2018 at 11:44:10AM +0100, Lucas Stach wrote:
> > Hi Dave,
> > 
> > nothing major this time, mostly some cleanups that were found on the
> > way of reworking the code in preparation for new feature additions.
> 
> dim: dea492e0cfcbe8ca592406fefc7ceeaf53f63380 is lacking review
> dim: ead5bd82cc3785e68d83cb6a3922e6c91de454e3 is lacking review
> dim: 2ef0ebf5cc6b4b40999fe64de1a39c7c68068ecf is lacking review
> 
> First two are simple enough that I'm not too lazy to review them, but 3rd
> looks like not entirely trivial.  Please get one of the other etnaviv
> folks to ack it.

Ack here is good enough, so I can add it to the merge commit. Just in case
there's confusion whether I want a rebase or something silly like that :-)
-Daniel

> 
> Thanks, Daniel
> 
> > 
> > Regards,
> > Lucas
> > 
> > The following changes since commit 6fce3a406108ee6c8a61e2a33e52e9198a626ea0:
> > 
> >   drm/etnaviv: fix bogus fence complete check in timeout handler (2018-11-05 18:14:48 +0100)
> > 
> > are available in the Git repository at:
> > 
> >   https://git.pengutronix.de/git/lst/linux etnaviv/next
> > 
> > for you to fetch changes up to dea492e0cfcbe8ca592406fefc7ceeaf53f63380:
> > 
> >   drm/etnaviv: remove lastctx member from gpu struct (2018-12-11 12:35:07 +0100)
> > 
> > ----------------------------------------------------------------
> > Lucas Stach (5):
> >       drm/etnaviv: kill active fence tracking
> >       drm/etnaviv: consolidate hardware fence handling in etnaviv_gpu
> >       drm/etnaviv: remove unnecessary local irq disable
> >       drm/etnaviv: replace header include with forward declaration
> >       drm/etnaviv: remove lastctx member from gpu struct
> > 
> > Thomas Zimmermann (1):
> >       drm/etnaviv: Replace drm_dev_unref with drm_dev_put
> > 
> >  drivers/gpu/drm/etnaviv/etnaviv_buffer.c |  2 --
> >  drivers/gpu/drm/etnaviv/etnaviv_drv.c    | 16 +++++-----------
> >  drivers/gpu/drm/etnaviv/etnaviv_drv.h    | 11 -----------
> >  drivers/gpu/drm/etnaviv/etnaviv_gpu.c    | 37 ++++++++++++++++---------------------
> >  drivers/gpu/drm/etnaviv/etnaviv_gpu.h    | 12 ++----------
> >  5 files changed, 23 insertions(+), 55 deletions(-)
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
Christian Gmeiner Dec. 17, 2018, 10:09 a.m. UTC | #3
Am Fr., 14. Dez. 2018 um 11:44 Uhr schrieb Lucas Stach <l.stach@pengutronix.de>:
>
> Hi Dave,
>
> nothing major this time, mostly some cleanups that were found on the
> way of reworking the code in preparation for new feature additions.
>
> Regards,
> Lucas
>
> The following changes since commit 6fce3a406108ee6c8a61e2a33e52e9198a626ea0:
>
>   drm/etnaviv: fix bogus fence complete check in timeout handler (2018-11-05 18:14:48 +0100)
>
> are available in the Git repository at:
>
>   https://git.pengutronix.de/git/lst/linux etnaviv/next
>
> for you to fetch changes up to dea492e0cfcbe8ca592406fefc7ceeaf53f63380:
>
>   drm/etnaviv: remove lastctx member from gpu struct (2018-12-11 12:35:07 +0100)
>
> ----------------------------------------------------------------
> Lucas Stach (5):
..
>       drm/etnaviv: remove unnecessary local irq disable
>       drm/etnaviv: replace header include with forward declaration
>       drm/etnaviv: remove lastctx member from gpu struct
>

I did not found these three patches via google or in my in-box. Where
they ever send to any ml?

greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info
Lucas Stach Dec. 17, 2018, 3:37 p.m. UTC | #4
Hi Christian,

Am Montag, den 17.12.2018, 11:09 +0100 schrieb Christian Gmeiner:
> Am Fr., 14. Dez. 2018 um 11:44 Uhr schrieb Lucas Stach <l.stach@pengu
> tronix.de>:
> > 
> > Hi Dave,
> > 
> > nothing major this time, mostly some cleanups that were found on
> > the
> > way of reworking the code in preparation for new feature additions.
> > 
> > Regards,
> > Lucas
> > 
> > The following changes since commit
> > 6fce3a406108ee6c8a61e2a33e52e9198a626ea0:
> > 
> >   drm/etnaviv: fix bogus fence complete check in timeout handler
> > (2018-11-05 18:14:48 +0100)
> > 
> > are available in the Git repository at:
> > 
> >   https://git.pengutronix.de/git/lst/linux etnaviv/next
> > 
> > for you to fetch changes up to
> > dea492e0cfcbe8ca592406fefc7ceeaf53f63380:
> > 
> >   drm/etnaviv: remove lastctx member from gpu struct (2018-12-11
> > 12:35:07 +0100)
> > 
> > ----------------------------------------------------------------
> > Lucas Stach (5):
> 
> ..
> >       drm/etnaviv: remove unnecessary local irq disable
> >       drm/etnaviv: replace header include with forward declaration
> >       drm/etnaviv: remove lastctx member from gpu struct
> > 
> 
> I did not found these three patches via google or in my in-box. Where
> they ever send to any ml?

I'm pretty sure I did hit send on those, but also can't find a trace of
them anywhere, so seems they have been eaten by whatever likes little
patches before hitting the MLs. Unfortunately silence in response to
etnaviv kernel patches isn't something totally unusual, so I didn't
realize this in time. :-/

I've just re-sent those patches.

Regards,
Lucas
Daniel Vetter Dec. 17, 2018, 4:24 p.m. UTC | #5
On Mon, Dec 17, 2018 at 04:37:21PM +0100, Lucas Stach wrote:
> Hi Christian,
> 
> Am Montag, den 17.12.2018, 11:09 +0100 schrieb Christian Gmeiner:
> > Am Fr., 14. Dez. 2018 um 11:44 Uhr schrieb Lucas Stach <l.stach@pengu
> > tronix.de>:
> > > 
> > > Hi Dave,
> > > 
> > > nothing major this time, mostly some cleanups that were found on
> > > the
> > > way of reworking the code in preparation for new feature additions.
> > > 
> > > Regards,
> > > Lucas
> > > 
> > > The following changes since commit
> > > 6fce3a406108ee6c8a61e2a33e52e9198a626ea0:
> > > 
> > >   drm/etnaviv: fix bogus fence complete check in timeout handler
> > > (2018-11-05 18:14:48 +0100)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   https://git.pengutronix.de/git/lst/linux etnaviv/next
> > > 
> > > for you to fetch changes up to
> > > dea492e0cfcbe8ca592406fefc7ceeaf53f63380:
> > > 
> > >   drm/etnaviv: remove lastctx member from gpu struct (2018-12-11
> > > 12:35:07 +0100)
> > > 
> > > ----------------------------------------------------------------
> > > Lucas Stach (5):
> > 
> > ..
> > >       drm/etnaviv: remove unnecessary local irq disable
> > >       drm/etnaviv: replace header include with forward declaration
> > >       drm/etnaviv: remove lastctx member from gpu struct
> > > 
> > 
> > I did not found these three patches via google or in my in-box. Where
> > they ever send to any ml?
> 
> I'm pretty sure I did hit send on those, but also can't find a trace of
> them anywhere, so seems they have been eaten by whatever likes little
> patches before hitting the MLs. Unfortunately silence in response to
> etnaviv kernel patches isn't something totally unusual, so I didn't
> realize this in time. :-/
> 
> I've just re-sent those patches.

Since they all have r-b tags now I'll assume you're going to send me a new
pull with those added?
-Daniel