From patchwork Wed Feb 27 16:24:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 10832659 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A97BD1575 for ; Thu, 28 Feb 2019 08:29:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 956BE2D548 for ; Thu, 28 Feb 2019 08:29:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8720B2D55E; Thu, 28 Feb 2019 08:29:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 25B2A2D5F9 for ; Thu, 28 Feb 2019 08:29:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D5266E154; Thu, 28 Feb 2019 08:29:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from esa5.microchip.iphmx.com (esa5.microchip.iphmx.com [216.71.150.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id 006AD6E0E5 for ; Wed, 27 Feb 2019 16:31:49 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.58,420,1544511600"; d="scan'208";a="25323669" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Feb 2019 09:24:43 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.107) with Microsoft SMTP Server (TLS) id 14.3.352.0; Wed, 27 Feb 2019 09:24:42 -0700 Received: from MWHPR11MB1549.namprd11.prod.outlook.com (10.172.54.17) by MWHPR11MB1806.namprd11.prod.outlook.com (10.175.53.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.21; Wed, 27 Feb 2019 16:24:40 +0000 Received: from MWHPR11MB1549.namprd11.prod.outlook.com ([fe80::54fe:95ed:b0cf:55a6]) by MWHPR11MB1549.namprd11.prod.outlook.com ([fe80::54fe:95ed:b0cf:55a6%8]) with mapi id 15.20.1643.022; Wed, 27 Feb 2019 16:24:40 +0000 From: To: , , , , , , , , , Subject: [PATCH 6/7] drm: atmel-hlcdc: enable sys_clk during initalization. Thread-Topic: [PATCH 6/7] drm: atmel-hlcdc: enable sys_clk during initalization. Thread-Index: AQHUzrjwAYRRhdyfPkqrFMqRJO5EaA== Date: Wed, 27 Feb 2019 16:24:40 +0000 Message-ID: <1551284609-14594-7-git-send-email-claudiu.beznea@microchip.com> References: <1551284609-14594-1-git-send-email-claudiu.beznea@microchip.com> In-Reply-To: <1551284609-14594-1-git-send-email-claudiu.beznea@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR08CA0112.eurprd08.prod.outlook.com (2603:10a6:800:d4::14) To MWHPR11MB1549.namprd11.prod.outlook.com (2603:10b6:301:c::17) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5153c137-2c2e-4142-5950-08d69cd012ce x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:MWHPR11MB1806; x-ms-traffictypediagnostic: MWHPR11MB1806: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; MWHPR11MB1806; 23:wU4N65EdWtaeha6HAdZE4GkSWr67vyjIHRXluDQ?= =?iso-8859-1?q?vBElUgZuwdd+nI4?= =?iso-8859-1?q?8b3VtRR65PKp7YqNADPhVBEuKuQm+qW0R/ZZGwWEEiYzkmM7pFJEa9hhjvql?= =?iso-8859-1?q?QWze0kfCqTYkqFrCxYGeHZrFrvcoIEc14ZRTTYD/nsiZg53mi885VvGgnt5A?= =?iso-8859-1?q?Vu4m5/EnLpQmzCoAYMChiHrhhNincZrfL5BEtRILNS1MjoUOzA0uFImznzKo?= =?iso-8859-1?q?IUP4bGRsfM/M+WAXrPDNizPj82FXCTPdGCdJ8jwo9fI3sQJNwGqnddHC1KU5?= =?iso-8859-1?q?ogfYMPzRupEY+/0BE3dETqk6LhUfy1kSzey+1XPenS61r9OGYmGs2bbQeiXP?= =?iso-8859-1?q?J7HeOtHgco2/hOQ99zkSAMoaZG/pzWE7kit9WOyUIQsuoCetbfWAFZvJ3xGj?= =?iso-8859-1?q?dUG0Pas0XtMFMUsZzDLiT+sizjY2E64rv9Im8lf1dROU0U+lGVynf1UkBu0m?= =?iso-8859-1?q?FFaQYGq1gKsrf878PxFvVvHACx9J3LQMjNwN+F4du8V01KUdf9f+seGIoyhF?= =?iso-8859-1?q?9e3h4HIDDFzxvHRM7Mr1GAusS3jg8gH+5ODxQZoUSqpu9hyEpx1JnusiiOvs?= =?iso-8859-1?q?3XQQOZKAfgAhXFMFz31+/Bk6IQ5t7rZtYF3zOi5O37I7IZhZ+kj8QX+Y43UM?= =?iso-8859-1?q?/tLTE1wBQBxDorXwV3EZP55+TGL4pCk10FAXROR3YW9qsUva1nZlA7qcm6KZ?= =?iso-8859-1?q?7VN8ceUzM6xwGa7DGsiq3KxBpn4jZrXxCpXSmwTZBPKGRBYdmAswu6RgO0bC?= =?iso-8859-1?q?VZuBDs/Simmv1gHuoubyu8Nnbwxaf5E6uOtgtxJV2fFObquInQqKdH4oLRkx?= =?iso-8859-1?q?w2SctuhRdkAq3QGQkdcN73xOoZEtO61b68cejrxFMjhF1H7sdyVwln8cmyCX?= =?iso-8859-1?q?B1JFDIHEheW4kZnBuCIvM+XOWuWrOvdE97C57v+jjJIu2+Ebg8b/KWjzBg8g?= =?iso-8859-1?q?R5syWUM16gdptWTB5oCHaK2+aHu0ZA0mVVhkfrRx0ICYUQZBhKgV3wCk3PVG?= =?iso-8859-1?q?BuJ7kOQ//wFbUvrmc51e7cPtVi8ss7ItY35X2qGNJiOC/8ny+74Oj8JuGvD8?= =?iso-8859-1?q?n2JqNKc5VypBmjhde/O0xDiVohSMZplXL1Z9ik6biuwGZ8pqjsmZMd4KfHFR?= =?iso-8859-1?q?j9qh4OrMBUVwCDexsdnNARmtyyfyL6vTR2V/CvjhNC8m+B5YyLqBvhEzl4CX?= =?iso-8859-1?q?vpjXEhY3ei7N6LhYw8gDt1iqPDaY0R7MkPWsSLzGup7AhsZdTDDadV+naIJA?= =?iso-8859-1?q?iHDbQgOOJnGgV8yFqIuvzE5/gecEYyPafpJ7cAx0b4K4l/f7lvV5pfIY4Ez8?= =?iso-8859-1?q?ZcgCxcuSQSM4c3pSY78U0v1oKkoFcQ?= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(396003)(366004)(136003)(376002)(189003)(199004)(11346002)(105586002)(25786009)(6436002)(8936002)(36756003)(4326008)(66066001)(6486002)(486006)(476003)(76176011)(50226002)(52116002)(186003)(107886003)(72206003)(99286004)(478600001)(2616005)(7416002)(68736007)(110136005)(14454004)(2201001)(71190400001)(6116002)(6506007)(86362001)(446003)(71200400001)(386003)(97736004)(8676002)(3846002)(53936002)(81156014)(54906003)(14444005)(81166006)(256004)(2501003)(316002)(305945005)(6512007)(7736002)(26005)(102836004)(2906002)(106356001)(5660300002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR11MB1806; H:MWHPR11MB1549.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xEo9pd9SV4OiaKgDnXpvzSdbDr7jWKC34+OGPJBB2w2mjVNt6c1QoAWoqUGlTJ8nBE9Z3FtKSZqQ9Cg37IDQy1EEXJsvMIJb585Tk1LY5+1WpsrYWUZKjJdcfWf3UXLquB2wxrR1702lXXjpb8ga18ZNMX4mIMAcIljQAikUdyrFxee+tvWlqW5LE7IshvZ2wWT+Eu9HqDs306b8F7jL0WhSV11qsUzNbink73rUXvm0GSczk6mAeeCztJVe8aItj3rnqd0EeKlQL2Xn78tG+1S/hc7/4aw0BsWgBL2OgROi5g+wOpS7Nc4dWFc9C/Set9C7FIyhI7hg75l3ExQVGkTmilUC9xrHS6iO8J6GdfkfphXJzDIjNi0HPC6C1bn8Gvdxbv6p2YrZMjbtnwQ/Zg7Cc2pSIW2z+pml2x+UrfE= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5153c137-2c2e-4142-5950-08d69cd012ce X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 16:24:35.4217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1806 X-OriginatorOrg: microchip.com X-Mailman-Approved-At: Thu, 28 Feb 2019 08:28:56 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f2LlApE9KLEwvJ1Xgh4TXz5Ls7//fcDvuKAIwlZx2AU=; b=W51+FEil8MeZFAnmu3A49xgTeULdwIRsFHPKknqgzzvjEIdE/Hopt9qVXmyy+U4PQjIu04Q4LcrkrwOJMBznNd6eSlprKVCiIjdY+692yp38mcAJEsmwb8A4cvNAXNXSymzIABkZAYjioXauP972Qd6LYI5VBz2ZVmuNNIiTi1I= X-Mailman-Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Claudiu.Beznea@microchip.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sandeep.Sheriker@microchip.com, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Sandeep Sheriker Mallikarjun For SAM9X60 SoC, sys_clk is through lcd_gclk clock source and this needs to be enabled before enabling lcd_clk. Signed-off-by: Sandeep Sheriker Mallikarjun [claudiu.beznea@microchip.com: add fixed_clksrc checks] Signed-off-by: Claudiu Beznea --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c index 0be13eceedba..8bf51f853721 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -625,10 +625,18 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) dc->hlcdc = dev_get_drvdata(dev->dev->parent); dev->dev_private = dc; + if (dc->desc->fixed_clksrc) { + ret = clk_prepare_enable(dc->hlcdc->sys_clk); + if (ret) { + dev_err(dev->dev, "failed to enable sys_clk\n"); + goto err_destroy_wq; + } + } + ret = clk_prepare_enable(dc->hlcdc->periph_clk); if (ret) { dev_err(dev->dev, "failed to enable periph_clk\n"); - goto err_destroy_wq; + goto err_sys_clk_disable; } pm_runtime_enable(dev->dev); @@ -664,6 +672,9 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) err_periph_clk_disable: pm_runtime_disable(dev->dev); clk_disable_unprepare(dc->hlcdc->periph_clk); +err_sys_clk_disable: + if (dc->desc->fixed_clksrc) + clk_disable_unprepare(dc->hlcdc->sys_clk); err_destroy_wq: destroy_workqueue(dc->wq); @@ -688,6 +699,8 @@ static void atmel_hlcdc_dc_unload(struct drm_device *dev) pm_runtime_disable(dev->dev); clk_disable_unprepare(dc->hlcdc->periph_clk); + if (dc->desc->fixed_clksrc) + clk_disable_unprepare(dc->hlcdc->sys_clk); destroy_workqueue(dc->wq); } @@ -805,6 +818,8 @@ static int atmel_hlcdc_dc_drm_suspend(struct device *dev) regmap_read(regmap, ATMEL_HLCDC_IMR, &dc->suspend.imr); regmap_write(regmap, ATMEL_HLCDC_IDR, dc->suspend.imr); clk_disable_unprepare(dc->hlcdc->periph_clk); + if (dc->desc->fixed_clksrc) + clk_disable_unprepare(dc->hlcdc->sys_clk); return 0; } @@ -814,6 +829,8 @@ static int atmel_hlcdc_dc_drm_resume(struct device *dev) struct drm_device *drm_dev = dev_get_drvdata(dev); struct atmel_hlcdc_dc *dc = drm_dev->dev_private; + if (dc->desc->fixed_clksrc) + clk_prepare_enable(dc->hlcdc->sys_clk); clk_prepare_enable(dc->hlcdc->periph_clk); regmap_write(dc->hlcdc->regmap, ATMEL_HLCDC_IER, dc->suspend.imr);