| Message ID | 1554103457-29595-1-git-send-email-yannick.fertre@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/stm: ltdc: update planes at next vblank to avoid partial refresh | expand |
Dear Yannick, Thank you for your patch, works fine, Acked-by: Philippe Cornu <philippe.cornu@st.com> Philippe :-) On 4/1/19 9:24 AM, Yannick Fertré wrote: > Plane updates must be synchronized on vblank with the shadow register mechanism > to avoid partial refresh on screen. > > Signed-off-by: Yannick Fertré <yannick.fertre@st.com> > --- > drivers/gpu/drm/stm/ltdc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index b1741a9..c2d0800 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc, > /* Enable IRQ */ > reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE); > > - /* Immediately commit the planes */ > - reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR); > + /* Commit shadow registers = update planes at next vblank */ > + reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR); > > /* Enable LTDC */ > reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN); >
Le lun. 1 avr. 2019 à 11:22, Philippe CORNU <philippe.cornu@st.com> a écrit : > > Dear Yannick, > Thank you for your patch, works fine, > > Acked-by: Philippe Cornu <philippe.cornu@st.com> > Applied on drm-misc-next, Thanks, Benjamin > Philippe :-) > > On 4/1/19 9:24 AM, Yannick Fertré wrote: > > Plane updates must be synchronized on vblank with the shadow register mechanism > > to avoid partial refresh on screen. > > > > Signed-off-by: Yannick Fertré <yannick.fertre@st.com> > > --- > > drivers/gpu/drm/stm/ltdc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > > index b1741a9..c2d0800 100644 > > --- a/drivers/gpu/drm/stm/ltdc.c > > +++ b/drivers/gpu/drm/stm/ltdc.c > > @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc, > > /* Enable IRQ */ > > reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE); > > > > - /* Immediately commit the planes */ > > - reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR); > > + /* Commit shadow registers = update planes at next vblank */ > > + reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR); > > > > /* Enable LTDC */ > > reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN); > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index b1741a9..c2d0800 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc, /* Enable IRQ */ reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE); - /* Immediately commit the planes */ - reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR); + /* Commit shadow registers = update planes at next vblank */ + reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR); /* Enable LTDC */ reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
Plane updates must be synchronized on vblank with the shadow register mechanism to avoid partial refresh on screen. Signed-off-by: Yannick Fertré <yannick.fertre@st.com> --- drivers/gpu/drm/stm/ltdc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)