From patchwork Mon Jun 3 06:31:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lowry Li (Arm Technology China)" X-Patchwork-Id: 10972395 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D1DF2933 for ; Mon, 3 Jun 2019 06:31:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C029328852 for ; Mon, 3 Jun 2019 06:31:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B474028861; Mon, 3 Jun 2019 06:31:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 65E8928852 for ; Mon, 3 Jun 2019 06:31:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7392E8969E; Mon, 3 Jun 2019 06:31:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on060b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::60b]) by gabe.freedesktop.org (Postfix) with ESMTPS id EECBF8969E for ; Mon, 3 Jun 2019 06:31:56 +0000 (UTC) Received: from VI1PR08MB5488.eurprd08.prod.outlook.com (52.133.246.150) by VI1PR08MB4605.eurprd08.prod.outlook.com (20.178.13.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.17; Mon, 3 Jun 2019 06:31:54 +0000 Received: from VI1PR08MB5488.eurprd08.prod.outlook.com ([fe80::ada6:12ed:65d0:4629]) by VI1PR08MB5488.eurprd08.prod.outlook.com ([fe80::ada6:12ed:65d0:4629%4]) with mapi id 15.20.1922.025; Mon, 3 Jun 2019 06:31:54 +0000 From: "Lowry Li (Arm Technology China)" To: Liviu Dudau , "james qian wang (Arm Technology China)" , "maarten.lankhorst@linux.intel.com" , "seanpaul@chromium.org" , "airlied@linux.ie" , Brian Starkey Subject: [PATCH v1 2/2] drm/komeda: Adds komeda_kms_drop_master Thread-Topic: [PATCH v1 2/2] drm/komeda: Adds komeda_kms_drop_master Thread-Index: AQHVGdYIJROjMKA2IkGllIHYR3H/0A== Date: Mon, 3 Jun 2019 06:31:54 +0000 Message-ID: <1559543462-32264-3-git-send-email-lowry.li@arm.com> References: <1559543462-32264-1-git-send-email-lowry.li@arm.com> In-Reply-To: <1559543462-32264-1-git-send-email-lowry.li@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [113.29.88.7] x-clientproxiedby: HK0PR01CA0060.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::24) To VI1PR08MB5488.eurprd08.prod.outlook.com (2603:10a6:803:137::22) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 1.9.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ce025073-05f2-4da8-7caa-08d6e7ed2b28 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR08MB4605; x-ms-traffictypediagnostic: VI1PR08MB4605: nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:67; x-forefront-prvs: 0057EE387C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(376002)(346002)(366004)(39860400002)(189003)(199004)(102836004)(6512007)(36756003)(110136005)(26005)(54906003)(486006)(256004)(386003)(186003)(14444005)(6506007)(99286004)(446003)(11346002)(55236004)(52116002)(66446008)(66476007)(53936002)(66946007)(64756008)(68736007)(4326008)(6636002)(2616005)(476003)(76176011)(73956011)(66556008)(86362001)(72206003)(14454004)(478600001)(25786009)(6486002)(5660300002)(50226002)(2906002)(8936002)(316002)(2501003)(81156014)(81166006)(66066001)(8676002)(7736002)(6436002)(6116002)(71200400001)(71190400001)(3846002)(305945005)(2201001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4605; H:VI1PR08MB5488.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: O714nvBvVGfxVKj9xGJOtSM24yBtik+2Dv0SxCPWFlLEV8XwAmk1fFNz13evzm7z6D+B95OvEKDsC2BQC4TbFfjOzbbyUMGvjxw5bWg7n0JjmMXMAZERYzd2tgnKGniNt+SU6K3bN2aFDUoMcGAn2iiUg9hrQdFwuOxPEvbs2PDw9+PwjPnnSQtVk2KEQoiC0HIF+JLVM1Yt2aRxmfTB9Dm3qkX9HvOWFnPUIq1202zQMexba7hhQVSd6tIREVifSr/Idb9n5m3ljUY4dGkOK7QXHBemZ537rVcEW3Ff6ldcxph9yQPbWNRWnucFzq9hut0qRArwzddfIdMZH7so/q2XcYTeT6Ch2kTIRb0OPIytgRHbQMmmQaeuzGn6+TR3kNKmYuRZsNdGwJ7KGWJurhTn9TkbXhhkVEvCghYTA80= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce025073-05f2-4da8-7caa-08d6e7ed2b28 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2019 06:31:54.2096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lowry.Li@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4605 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9tozB7RgQ21imy9KivQaH+Savx9XekgE6jkQuEEJGk=; b=ZV8pK5q8Yairm7Oi9Nuek8pU4cUrji/dWCsyCF08u2pdlip326NwqJ0fUHlo/X96XA1auFXVAHw8v/Jb5tdvX0TJgiidPQJQeL5LAjStsidQWtAKpNoDgKiSRPivotzmu5ZkDEBHwyWaxCzaFB3fsoV94hWVe8NJ3DfprRspmP0= X-Mailman-Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Lowry.Li@arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ayan Halder , "Jonathan Chai \(Arm Technology China\)" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Julien Yin \(Arm Technology China\)" , nd Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The komeda internal resources (pipelines) are shared between crtcs, and resources release by disable_crtc. This commit is working for once user forgot disabling crtc like app quit abnomally, and then the resources can not be used by another crtc. Adds drop_master to shutdown the device and make sure all the komeda resources have been released and can be used for the next usage. Signed-off-by: Lowry Li (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c index 8543860..647bce5 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -54,11 +54,24 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) return status; } +/* Komeda internal resources (pipelines) are shared between crtcs, and resources + * are released by disable_crtc. But if user forget disabling crtc like app quit + * abnormally, the resources can not be used by another crtc. + * Use drop_master to shutdown the device and make sure all the komeda resources + * have been released, and can be used for the next usage. + */ +static void komeda_kms_drop_master(struct drm_device *dev, + struct drm_file *file_priv) +{ + drm_atomic_helper_shutdown(dev); +} + static struct drm_driver komeda_kms_driver = { .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_PRIME | DRIVER_HAVE_IRQ, .lastclose = drm_fb_helper_lastclose, .irq_handler = komeda_kms_irq_handler, + .master_drop = komeda_kms_drop_master, .gem_free_object_unlocked = drm_gem_cma_free_object, .gem_vm_ops = &drm_gem_cma_vm_ops, .dumb_create = komeda_gem_cma_dumb_create,