From patchwork Thu Apr 30 20:26:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Souptick Joarder X-Patchwork-Id: 11522205 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3069A17EF for ; Fri, 1 May 2020 07:23:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F194208C3 for ; Fri, 1 May 2020 07:23:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AMJF0mMZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F194208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86DC26EBAA; Fri, 1 May 2020 07:23:42 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 607686E43D; Thu, 30 Apr 2020 20:18:57 +0000 (UTC) Received: by mail-pf1-x442.google.com with SMTP id 18so421512pfx.6; Thu, 30 Apr 2020 13:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=c6sNQQbXXpU5p2FuijRbtB6WLWnnDlNaexeMBmOH9os=; b=AMJF0mMZCNk2Aie4LhGSvy4Yz8R7SHPXqoWRRSAOz3mGEvgEKilOJKxXS8id9b2bLa 2TyI2vxvVgmfLzZzo8yTylejyILFUMIFiNpKAwEkh6axdilQdDkAym/zL0CQ+2qToaHn jWW6pZ6IKhzrPaHUBgDNIUwUXRUUprx17V4yYEY+N7nMd3q0kpczZIhDXs75wgAdroEz mv1MzrdBgMJb6BO2IaCTX99B60dnOEuJRnkas1LLa4xluStvlTqZHJik6SDh/mHJONZY q9whWQRov+7VO3rosvRJji6yxbZPfqnNSzh6agjnYFJuxq8gNzk8rxi1GRWU4vW/Z+8d EYhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=c6sNQQbXXpU5p2FuijRbtB6WLWnnDlNaexeMBmOH9os=; b=srtvIZsvWmB1N6QunXAk3YgE1puoYvfT08SGtfySg1kPqXN4zPOgbT7x8CRDIPQ2PI 0qtKprNQOdg+PLb97yrodDpeyo9/sAwMEoXD7mL+PuVx9VrP7pYG6YgNZSyDq2ak5WHj wkxUgbO8jixeFKLVZBgLUDJW/OFuEH3olkEcN3kgRJnCI9QdeN4Ag/IA8hPpEUlX8icz meOIAhCDufnfEamzFYbG3d5HrbHsdwfCz3Zs2bm5IIARsU9FVkF1Wsw0nnkTVUcCVgA5 1biky9Y8dwDqj5XD1qYY7eP3llu+kOP14XZBe4flYUlf9DbMiiSjTWZ/kogd4oMeorPB 2LAw== X-Gm-Message-State: AGi0PuYPE3PGtt7oEUjE1wDBuDqBs9Yvk49JObPVs7sLf26m2bydbkr4 m3DL5371UuK8umflSax8wD3HOTZsEDQ= X-Google-Smtp-Source: APiQypKPGdVlOsYhKcq1mKI7cuDudA78+0Dqfc8fvIvzCBbopM81voaAfO9uBe+SDndiAY1gpae/Sg== X-Received: by 2002:a63:5907:: with SMTP id n7mr652937pgb.439.1588277936882; Thu, 30 Apr 2020 13:18:56 -0700 (PDT) Received: from jordon-HP-15-Notebook-PC.domain.name ([122.167.43.171]) by smtp.gmail.com with ESMTPSA id 14sm523310pjd.36.2020.04.30.13.18.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Apr 2020 13:18:55 -0700 (PDT) From: Souptick Joarder To: bskeggs@redhat.com, airlied@linux.ie, daniel@ffwll.ch, tzimmermann@suse.de, alexander.deucher@amd.com, lyude@redhat.com, sam@ravnborg.org Subject: [PATCH] drm/nouveau/dispnv04: Remove dead code Date: Fri, 1 May 2020 01:56:53 +0530 Message-Id: <1588278413-21682-1-git-send-email-jrdr.linux@gmail.com> X-Mailer: git-send-email 1.9.1 X-Mailman-Approved-At: Fri, 01 May 2020 07:22:25 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, inux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Souptick Joarder MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" These are dead code since 3.10. If there is no plan to use it further, these can be removed forever. Signed-off-by: Souptick Joarder --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c index 1f08de4..ad0ef7d 100644 --- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c +++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c @@ -269,31 +269,11 @@ static void nv_crtc_calc_state_ext(struct drm_crtc *crtc, struct drm_display_mod horizStart = horizTotal - 5; horizEnd = horizTotal - 2; horizBlankEnd = horizTotal + 4; -#if 0 - if (dev->overlayAdaptor && drm->client.device.info.family >= NV_DEVICE_INFO_V0_CELSIUS) - /* This reportedly works around some video overlay bandwidth problems */ - horizTotal += 2; -#endif } if (mode->flags & DRM_MODE_FLAG_INTERLACE) vertTotal |= 1; -#if 0 - ErrorF("horizDisplay: 0x%X \n", horizDisplay); - ErrorF("horizStart: 0x%X \n", horizStart); - ErrorF("horizEnd: 0x%X \n", horizEnd); - ErrorF("horizTotal: 0x%X \n", horizTotal); - ErrorF("horizBlankStart: 0x%X \n", horizBlankStart); - ErrorF("horizBlankEnd: 0x%X \n", horizBlankEnd); - ErrorF("vertDisplay: 0x%X \n", vertDisplay); - ErrorF("vertStart: 0x%X \n", vertStart); - ErrorF("vertEnd: 0x%X \n", vertEnd); - ErrorF("vertTotal: 0x%X \n", vertTotal); - ErrorF("vertBlankStart: 0x%X \n", vertBlankStart); - ErrorF("vertBlankEnd: 0x%X \n", vertBlankEnd); -#endif - /* * compute correct Hsync & Vsync polarity */ @@ -492,14 +472,6 @@ static void nv_crtc_calc_state_ext(struct drm_crtc *crtc, struct drm_display_mod /* Except for rare conditions I2C is enabled on the primary crtc */ if (nv_crtc->index == 0) regp->crtc_eng_ctrl |= NV_CRTC_FSEL_I2C; -#if 0 - /* Set overlay to desired crtc. */ - if (dev->overlayAdaptor) { - NVPortPrivPtr pPriv = GET_OVERLAY_PRIVATE(dev); - if (pPriv->overlayCRTC == nv_crtc->index) - regp->crtc_eng_ctrl |= NV_CRTC_FSEL_OVERLAY; - } -#endif /* ADDRESS_SPACE_PNVM is the same as setting HCUR_ASI */ regp->cursor_cfg = NV_PCRTC_CURSOR_CONFIG_CUR_LINES_64 |