| Message ID | 1590991880-24273-1-git-send-email-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Tue, 2 Jun 2020 at 08:17, Liu Ying <victor.liu@nxp.com> wrote: > > This patch adds support for Kaohsiung Opto-Electronics Inc. > 10.1" TX26D202VM0BWA WUXGA(1920x1200) TFT LCD panel with LVDS interface. > The panel has dual LVDS channels. > > My panel is manufactured by US Micro Products(USMP). There is a tag at > the back of the panel, which indicates the panel type is 'TX26D202VM0BWA' > and it's made by KOE in Taiwan. > > The panel spec from USMP can be found at: > https://www.usmicroproducts.com/sites/default/files/datasheets/USMP-T101-192120NDU-A0.pdf > > The below panel spec from KOE is basically the same to the one from USMP. > However, the panel type 'TX26D202VM0BAA' is a little bit different. > It looks that the two types of panel are compatible with each other. > http://www.koe.j-display.com/upload/product/TX26D202VM0BAA.pdf > > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index b6ecd15..7c222ec 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2200,6 +2200,37 @@ static const struct panel_desc koe_tx14d24vm1bpa = { > }, > }; > > +static const struct display_timing koe_tx26d202vm0bwa_timing = { > + .pixelclock = { 151820000, 156720000, 159780000 }, > + .hactive = { 1920, 1920, 1920 }, > + .hfront_porch = { 105, 130, 142 }, > + .hback_porch = { 45, 70, 82 }, > + .hsync_len = { 30, 30, 30 }, > + .vactive = { 1200, 1200, 1200}, > + .vfront_porch = { 3, 5, 10 }, > + .vback_porch = { 2, 5, 10 }, > + .vsync_len = { 5, 5, 5 }, > +}; > + > +static const struct panel_desc koe_tx26d202vm0bwa = { > + .timings = &koe_tx26d202vm0bwa_timing, > + .num_timings = 1, > + .bpc = 8, > + .size = { > + .width = 217, > + .height = 136, > + }, > + .delay = { > + .prepare = 1000, > + .enable = 1000, > + .unprepare = 1000, > + .disable = 1000, Ouch 1s for each delay is huge. Nevertheless it matches the specs so, the series is: Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Sam, Thierry I assume you'll merge the series. Let me know if I should pick it up. -Emil
Hi Emil. On Tue, Jun 02, 2020 at 01:46:19PM +0100, Emil Velikov wrote: > On Tue, 2 Jun 2020 at 08:17, Liu Ying <victor.liu@nxp.com> wrote: > > > > This patch adds support for Kaohsiung Opto-Electronics Inc. > > 10.1" TX26D202VM0BWA WUXGA(1920x1200) TFT LCD panel with LVDS interface. > > The panel has dual LVDS channels. > > > > My panel is manufactured by US Micro Products(USMP). There is a tag at > > the back of the panel, which indicates the panel type is 'TX26D202VM0BWA' > > and it's made by KOE in Taiwan. > > > > The panel spec from USMP can be found at: > > https://www.usmicroproducts.com/sites/default/files/datasheets/USMP-T101-192120NDU-A0.pdf > > > > The below panel spec from KOE is basically the same to the one from USMP. > > However, the panel type 'TX26D202VM0BAA' is a little bit different. > > It looks that the two types of panel are compatible with each other. > > http://www.koe.j-display.com/upload/product/TX26D202VM0BAA.pdf > > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > Cc: Sam Ravnborg <sam@ravnborg.org> > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > > --- > > drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index b6ecd15..7c222ec 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -2200,6 +2200,37 @@ static const struct panel_desc koe_tx14d24vm1bpa = { > > }, > > }; > > > > +static const struct display_timing koe_tx26d202vm0bwa_timing = { > > + .pixelclock = { 151820000, 156720000, 159780000 }, > > + .hactive = { 1920, 1920, 1920 }, > > + .hfront_porch = { 105, 130, 142 }, > > + .hback_porch = { 45, 70, 82 }, > > + .hsync_len = { 30, 30, 30 }, > > + .vactive = { 1200, 1200, 1200}, > > + .vfront_porch = { 3, 5, 10 }, > > + .vback_porch = { 2, 5, 10 }, > > + .vsync_len = { 5, 5, 5 }, > > +}; > > + > > +static const struct panel_desc koe_tx26d202vm0bwa = { > > + .timings = &koe_tx26d202vm0bwa_timing, > > + .num_timings = 1, > > + .bpc = 8, > > + .size = { > > + .width = 217, > > + .height = 136, > > + }, > > + .delay = { > > + .prepare = 1000, > > + .enable = 1000, > > + .unprepare = 1000, > > + .disable = 1000, > Ouch 1s for each delay is huge. Nevertheless it matches the specs so, > the series is: > Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> > > Sam, Thierry I assume you'll merge the series. Let me know if I should > pick it up. I am quite busy with non-linux stuff these days so fine if you can pick them up. I like that simple panel patches are processed fast. I expect to have some hours for linux work friday or saturday, but no promises... Sam > > -Emil
On Tue, 2 Jun 2020 at 21:57, Sam Ravnborg <sam@ravnborg.org> wrote: > > Hi Emil. > > On Tue, Jun 02, 2020 at 01:46:19PM +0100, Emil Velikov wrote: > > On Tue, 2 Jun 2020 at 08:17, Liu Ying <victor.liu@nxp.com> wrote: > > > > > > This patch adds support for Kaohsiung Opto-Electronics Inc. > > > 10.1" TX26D202VM0BWA WUXGA(1920x1200) TFT LCD panel with LVDS interface. > > > The panel has dual LVDS channels. > > > > > > My panel is manufactured by US Micro Products(USMP). There is a tag at > > > the back of the panel, which indicates the panel type is 'TX26D202VM0BWA' > > > and it's made by KOE in Taiwan. > > > > > > The panel spec from USMP can be found at: > > > https://www.usmicroproducts.com/sites/default/files/datasheets/USMP-T101-192120NDU-A0.pdf > > > > > > The below panel spec from KOE is basically the same to the one from USMP. > > > However, the panel type 'TX26D202VM0BAA' is a little bit different. > > > It looks that the two types of panel are compatible with each other. > > > http://www.koe.j-display.com/upload/product/TX26D202VM0BAA.pdf > > > > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > Cc: Sam Ravnborg <sam@ravnborg.org> > > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > > > --- > > > drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++++++++ > > > 1 file changed, 34 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > > index b6ecd15..7c222ec 100644 > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > @@ -2200,6 +2200,37 @@ static const struct panel_desc koe_tx14d24vm1bpa = { > > > }, > > > }; > > > > > > +static const struct display_timing koe_tx26d202vm0bwa_timing = { > > > + .pixelclock = { 151820000, 156720000, 159780000 }, > > > + .hactive = { 1920, 1920, 1920 }, > > > + .hfront_porch = { 105, 130, 142 }, > > > + .hback_porch = { 45, 70, 82 }, > > > + .hsync_len = { 30, 30, 30 }, > > > + .vactive = { 1200, 1200, 1200}, > > > + .vfront_porch = { 3, 5, 10 }, > > > + .vback_porch = { 2, 5, 10 }, > > > + .vsync_len = { 5, 5, 5 }, > > > +}; > > > + > > > +static const struct panel_desc koe_tx26d202vm0bwa = { > > > + .timings = &koe_tx26d202vm0bwa_timing, > > > + .num_timings = 1, > > > + .bpc = 8, > > > + .size = { > > > + .width = 217, > > > + .height = 136, > > > + }, > > > + .delay = { > > > + .prepare = 1000, > > > + .enable = 1000, > > > + .unprepare = 1000, > > > + .disable = 1000, > > Ouch 1s for each delay is huge. Nevertheless it matches the specs so, > > the series is: > > Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> > > > > Sam, Thierry I assume you'll merge the series. Let me know if I should > > pick it up. > I am quite busy with non-linux stuff these days so fine if you can pick > them up. I like that simple panel patches are processed fast. > > I expect to have some hours for linux work friday or saturday, but no > promises... > Don't worry - once the DT maintainers ack 1/2, I'll merge the series. -Emil
Hi Emil. > > > > I expect to have some hours for linux work friday or saturday, but no > > promises... > > > Don't worry - once the DT maintainers ack 1/2, I'll merge the series. If it is in alphabetical order then we are good to go. For such simple patches we do not need DT maintainer ack. You can add my: r-b then you are fully covered. Sam > > -Emil
Hi Emil. > > + .width = 217, > > + .height = 136, > > + }, > > + .delay = { > > + .prepare = 1000, > > + .enable = 1000, > > + .unprepare = 1000, > > + .disable = 1000, > Ouch 1s for each delay is huge. Nevertheless it matches the specs so, > the series is: > Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> > > Sam, Thierry I assume you'll merge the series. Let me know if I should > pick it up. I went ahead and applied both patches to drm-misc-next. They are now pushed out. Sam > > -Emil
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index b6ecd15..7c222ec 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2200,6 +2200,37 @@ static const struct panel_desc koe_tx14d24vm1bpa = { }, }; +static const struct display_timing koe_tx26d202vm0bwa_timing = { + .pixelclock = { 151820000, 156720000, 159780000 }, + .hactive = { 1920, 1920, 1920 }, + .hfront_porch = { 105, 130, 142 }, + .hback_porch = { 45, 70, 82 }, + .hsync_len = { 30, 30, 30 }, + .vactive = { 1200, 1200, 1200}, + .vfront_porch = { 3, 5, 10 }, + .vback_porch = { 2, 5, 10 }, + .vsync_len = { 5, 5, 5 }, +}; + +static const struct panel_desc koe_tx26d202vm0bwa = { + .timings = &koe_tx26d202vm0bwa_timing, + .num_timings = 1, + .bpc = 8, + .size = { + .width = 217, + .height = 136, + }, + .delay = { + .prepare = 1000, + .enable = 1000, + .unprepare = 1000, + .disable = 1000, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .connector_type = DRM_MODE_CONNECTOR_LVDS, +}; + static const struct display_timing koe_tx31d200vm0baa_timing = { .pixelclock = { 39600000, 43200000, 48000000 }, .hactive = { 1280, 1280, 1280 }, @@ -3832,6 +3863,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "koe,tx14d24vm1bpa", .data = &koe_tx14d24vm1bpa, }, { + .compatible = "koe,tx26d202vm0bwa", + .data = &koe_tx26d202vm0bwa, + }, { .compatible = "koe,tx31d200vm0baa", .data = &koe_tx31d200vm0baa, }, {
This patch adds support for Kaohsiung Opto-Electronics Inc. 10.1" TX26D202VM0BWA WUXGA(1920x1200) TFT LCD panel with LVDS interface. The panel has dual LVDS channels. My panel is manufactured by US Micro Products(USMP). There is a tag at the back of the panel, which indicates the panel type is 'TX26D202VM0BWA' and it's made by KOE in Taiwan. The panel spec from USMP can be found at: https://www.usmicroproducts.com/sites/default/files/datasheets/USMP-T101-192120NDU-A0.pdf The below panel spec from KOE is basically the same to the one from USMP. However, the panel type 'TX26D202VM0BAA' is a little bit different. It looks that the two types of panel are compatible with each other. http://www.koe.j-display.com/upload/product/TX26D202VM0BAA.pdf Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Liu Ying <victor.liu@nxp.com> --- drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)