diff mbox series

[v2] drm/nouveau/kms: Remove set but not used 'ret'

Message ID 1600822510-7778-1-git-send-email-tiantao6@hisilicon.com (mailing list archive)
State New, archived
Headers show
Series [v2] drm/nouveau/kms: Remove set but not used 'ret' | expand

Commit Message

tiantao (H) Sept. 23, 2020, 12:55 a.m. UTC 
This addresses the following gcc warning with "make W=1":
drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_prepare’:
drivers/gpu/drm/nouveau/dispnv50/disp.c:1378:6: warning:
variable ‘ret’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
v2:Remove the braces around ret
---
 drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index b111fe2..abc4f46 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -1379,6 +1379,8 @@  nv50_mstm_prepare(struct nv50_mstm *mstm)
 
 	NV_ATOMIC(drm, "%s: mstm prepare\n", mstm->outp->base.base.name);
 	ret = drm_dp_update_payload_part1(&mstm->mgr);
+	if (ret)
+		NV_ATOMIC(drm, "failed to update payload %d\n", ret);
 
 	drm_for_each_encoder(encoder, mstm->outp->base.base.dev) {
 		if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) {