From patchwork Wed Apr 7 23:06:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Viro X-Patchwork-Id: 91232 Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o386XvtZ019353 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 8 Apr 2010 06:34:33 GMT Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1NzlH2-0000Co-Uy; Thu, 08 Apr 2010 06:31:32 +0000 Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.124] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1NzeKA-0003zI-8f for dri-devel@lists.sourceforge.net; Wed, 07 Apr 2010 23:06:18 +0000 X-ACL-Warn: Received: from zeniv.linux.org.uk ([195.92.253.2]) by sfi-mx-4.v28.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1NzeK8-0000xo-Uz for dri-devel@lists.sourceforge.net; Wed, 07 Apr 2010 23:06:18 +0000 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.69 #1 (Red Hat Linux)) id 1NzeJz-00081x-Du; Wed, 07 Apr 2010 23:06:07 +0000 Date: Thu, 8 Apr 2010 00:06:07 +0100 From: Al Viro To: Linus Torvalds Subject: Re: 2.6.34-rc3-git6: Reported regressions from 2.6.33 Message-ID: <20100407230607.GM30031@ZenIV.linux.org.uk> References: <6Pphclm24fK.A.lSF.qsPvLB@chimera> <20100407221941.GL30031@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-Spam-Score: 0.0 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. _SUMMARY_ X-Headers-End: 1NzeK8-0000xo-Uz X-Mailman-Approved-At: Thu, 08 Apr 2010 06:31:32 +0000 Cc: DRI , Linux SCSI List , Network Development , Linux Wireless List , Linux Kernel Mailing List , "Rafael J. Wysocki" , Linux ACPI , Andrew Morton , Kernel Testers List , Linux PM List , Maciej Rutecki X-BeenThere: dri-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Thu, 08 Apr 2010 06:34:33 +0000 (UTC) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index d79a7b3..fe0cd9e 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2068,8 +2068,7 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st case -EDQUOT: case -ENOSPC: case -EROFS: - lookup_instantiate_filp(nd, (struct dentry *)state, NULL); - return 1; + return PTR_ERR(state); default: goto out_drop; }