From patchwork Thu Apr 14 08:56:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joerg Roedel X-Patchwork-Id: 706611 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p3E8uYuW002712 for ; Thu, 14 Apr 2011 08:56:55 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF80E9F36B for ; Thu, 14 Apr 2011 01:56:33 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from 8bytes.org (8bytes.org [88.198.83.132]) by gabe.freedesktop.org (Postfix) with ESMTP id 870189E760 for ; Thu, 14 Apr 2011 01:56:25 -0700 (PDT) Received: by 8bytes.org (Postfix, from userid 1000) id 828C5258263; Thu, 14 Apr 2011 10:56:24 +0200 (CEST) Date: Thu, 14 Apr 2011 10:56:24 +0200 From: Joerg Roedel To: "H. Peter Anvin" Subject: Re: Linux 2.6.39-rc3 Message-ID: <20110414085624.GC18463@8bytes.org> References: <20110412090207.GE19819@8bytes.org> <20110412184433.GF19819@8bytes.org> <20110413064609.GA18777@elte.hu> <20110413172147.GI19819@8bytes.org> <4DA5F62F.3030504@kernel.org> <4DA654D6.2060103@zytor.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4DA654D6.2060103@zytor.com> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: Yinghai Lu , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, Tejun Heo , Linus Torvalds , Thomas Gleixner X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 14 Apr 2011 08:56:55 +0000 (UTC) On Wed, Apr 13, 2011 at 06:58:46PM -0700, H. Peter Anvin wrote: > On 04/13/2011 12:14 PM, Yinghai Lu wrote: > > > > so looks bios program wrong address to the radon card? > > > > Okay, staring at this, it definitely seems toxic to overlay the GART > over memory areas reserved by the BIOS. If I were to guess, I would say > that the problem here seems to be that the kernel thinks it is > overlaying 64 MiB of memory, but the actual GART is in fact 512 MiB in > size -- 131072 CPU pages -- which now overlaps the BIOS reserved areas. > > Alex D., could you comment on the "num cpu pages" bit? Okay, I tried the debug-patch from Yinghai (posted to the bugzilla): And this makes a difference, with this change on-top of -rc3 the box boots fine. So there seems to be some dependency between the GART base and the GTT base even when they are in different address spaces. Alex, can you comment on this? Regards, Joerg --- a/drivers/gpu/drm/radeon/radeon_device.c +++ b/drivers/gpu/drm/radeon/radeon_device.c @@ -325,6 +325,8 @@ void radeon_gtt_location(struct radeon_device *rdev, struct radeon_mc *mc) mc->gtt_size = size_bf; } mc->gtt_start = (mc->vram_start & ~mc->gtt_base_align) - mc->gtt_size; + if (mc->gtt_start == 0xa0000000) + mc->gtt_start = 0x80000000; } else { if (mc->gtt_size > size_af) { dev_warn(rdev->dev, "limiting GTT\n");