From patchwork Sat Aug 11 12:16:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Forest Bond X-Patchwork-Id: 1308291 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 828DBDF2D2 for ; Sat, 11 Aug 2012 12:45:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CAEBAA10EF for ; Sat, 11 Aug 2012 05:45:33 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 499 seconds by postgrey-1.32 at gabe; Sat, 11 Aug 2012 14:23:34 CEST Received: from storm.alittletooquiet.net (storm.alittletooquiet.net [67.23.28.199]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C2C89EF4D for ; Sat, 11 Aug 2012 05:23:33 -0700 (PDT) Received: by storm.alittletooquiet.net (Postfix, from userid 1000) id D209E28D49B; Sat, 11 Aug 2012 08:16:06 -0400 (EDT) Date: Sat, 11 Aug 2012 08:16:06 -0400 From: Forest Bond To: David Airlie Subject: [PATCH 3/3] gma500: Consider CRTC initially active. Message-ID: <20120811121606.GE3089@alittletooquiet.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120811121454.GC3089@alittletooquiet.net> Cc: dri-devel@lists.freedesktop.org, Alan Cox X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org From: Forest Bond This causes the pipe to be forced off prior to initial mode set, which roughly mirrors the behavior of the i915 driver. It fixes initial mode setting on my Intel DN2800MT (Cedarview) board. Without it, mode setting triggers an out-of-range error from the monitor for most modes, but only on initial configuration (i.e. they can be configured successfully from userspace after that). Signed-off-by: Forest Bond --- drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index 30dc22a..8033526 100644 --- a/drivers/gpu/drm/gma500/psb_intel_display.c +++ b/drivers/gpu/drm/gma500/psb_intel_display.c @@ -1362,6 +1362,9 @@ void psb_intel_crtc_init(struct drm_device *dev, int pipe, (struct drm_connector **) (psb_intel_crtc + 1); psb_intel_crtc->mode_set.num_connectors = 0; psb_intel_cursor_init(dev, psb_intel_crtc); + + /* Set to true so that the pipe is forced off on initial config. */ + psb_intel_crtc->active = true; } int psb_intel_get_pipe_from_crtc_id(struct drm_device *dev, void *data,