From patchwork Mon Apr 15 09:39:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 2444431 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 5C9533FD1A for ; Mon, 15 Apr 2013 09:41:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45E90E6130 for ; Mon, 15 Apr 2013 02:41:36 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id A5718E6100 for ; Mon, 15 Apr 2013 02:39:09 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 15 Apr 2013 02:39:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,474,1363158000"; d="scan'208";a="322424738" Received: from unknown (HELO cantiga.alporthouse.com) ([10.255.13.174]) by fmsmga002.fm.intel.com with SMTP; 15 Apr 2013 02:39:07 -0700 Received: by cantiga.alporthouse.com (sSMTP sendmail emulation); Mon, 15 Apr 2013 10:39:05 +0100 Date: Mon, 15 Apr 2013 10:39:05 +0100 From: 'Chris Wilson' To: "Ben Mesman (Bossers & Cnossen BV)" Subject: Re: [PATCH] drm/i915: no lvds quirk for hp t5740 Message-ID: <20130415093905.GC24925@cantiga.alporthouse.com> Mail-Followup-To: 'Chris Wilson' , "Ben Mesman (Bossers & Cnossen BV)" , Daniel Vetter , "dri-devel@lists.freedesktop.org" References: <2209078F92755E409EE9E33312D5D53804A5A222@VMBNCEX01.bnc.local> <1365769483-16706-1-git-send-email-ben@bnc.nl> <20130412124651.GE1408@cantiga.alporthouse.com> <2209078F92755E409EE9E33312D5D53804A5F484@VMBNCEX01.bnc.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2209078F92755E409EE9E33312D5D53804A5F484@VMBNCEX01.bnc.local> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "dri-devel@lists.freedesktop.org" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org On Mon, Apr 15, 2013 at 06:39:15AM +0000, Ben Mesman (Bossers & Cnossen BV) wrote: > Op vrijdag 12 april 2013 14:47 schreef Chris Wilson: > > On Fri, Apr 12, 2013 at 02:24:43PM +0200, Ben Mesman wrote: > > > Last year, a patch was made for the "HP t5740e Thin Client" (see > > > http://lists.freedesktop.org/archives/dri-devel/2012-May/023245.html). > > > This device reports an lvds panel, but does not really have one. > > > > > > The predecessor of this device is the "hp t5740", which also does not > > > have an lvds panel. This patch will add the same quirk for this device. > > > > > > Signed-off-by: Ben Mesman > > > --- > > > drivers/gpu/drm/i915/intel_lvds.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c > > > b/drivers/gpu/drm/i915/intel_lvds.c > > > index ca2d903..8a56d9b 100644 > > > --- a/drivers/gpu/drm/i915/intel_lvds.c > > > +++ b/drivers/gpu/drm/i915/intel_lvds.c > > > @@ -816,6 +816,14 @@ static const struct dmi_system_id intel_no_lvds[] = > > { > > > }, > > > { > > > .callback = intel_no_lvds_dmi_callback, > > > + .ident = "Hewlett-Packard hp t5740", > > > + .matches = { > > > + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett- > > Packard"), > > > + DMI_MATCH(DMI_PRODUCT_NAME, "hp t5740"), > > > + }, > > > + }, > > > > One thing to note is that the dmi matching routine uses strstr (as opposed to > > dmi_match() which uses strcmp!) so this rule should encompass the > > following rule for its offspring. > > I am sorry, I don't know what you are asking here. Is there something wrong with this patch? I meant you could adjust the t5470e rule to also catch t5470: dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds index ca2d903..e321f08 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -816,10 +816,10 @@ static const struct dmi_system_id intel_no_lvds[] = { }, { .callback = intel_no_lvds_dmi_callback, - .ident = "Hewlett-Packard HP t5740e Thin Client", + .ident = "Hewlett-Packard HP t5740 Thin Client", .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), - DMI_MATCH(DMI_PRODUCT_NAME, "HP t5740e Thin Client"), + DMI_MATCH(DMI_PRODUCT_NAME, "hp t5740"), -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________