diff mbox

drm/panel: simple: Fix bus flags for ortustech com43h4m85ulc

Message ID 20160826142402.7031-1-marex@denx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Marek Vasut Aug. 26, 2016, 2:24 p.m. UTC
This display expects DE pin to be active high, add the necessary flag.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Philipp Zabel Aug. 26, 2016, 3:58 p.m. UTC | #1
Hi Marek,

Am Freitag, den 26.08.2016, 16:24 +0200 schrieb Marek Vasut:
> This display expects DE pin to be active high, add the necessary flag.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3a7bdf1..f4c546d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1198,6 +1198,7 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
>  		.height = 93,
>  	},
>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

While at it, you could also add DRM_BUS_FLAG_PIXDATA_POSEDGE. The panel
expects pixel data to be driven with the rising edge of the pixel clock,
it samples on the falling edge.

regards
Philipp
Marek Vasut Aug. 26, 2016, 4:12 p.m. UTC | #2
On 08/26/2016 05:58 PM, Philipp Zabel wrote:
> Hi Marek,
> 
> Am Freitag, den 26.08.2016, 16:24 +0200 schrieb Marek Vasut:
>> This display expects DE pin to be active high, add the necessary flag.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Cc: Thierry Reding <treding@nvidia.com>
>> ---
>>  drivers/gpu/drm/panel/panel-simple.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 3a7bdf1..f4c546d 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -1198,6 +1198,7 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
>>  		.height = 93,
>>  	},
>>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
> 
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> 
> While at it, you could also add DRM_BUS_FLAG_PIXDATA_POSEDGE. The panel
> expects pixel data to be driven with the rising edge of the pixel clock,
> it samples on the falling edge.

Ah, let me add the flag and repost then.
diff mbox

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3a7bdf1..f4c546d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1198,6 +1198,7 @@  static const struct panel_desc ortustech_com43h4m85ulc = {
 		.height = 93,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
 };
 
 static const struct drm_display_mode qd43003c0_40_mode = {