| Message ID | 20160906144620.6322-7-maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Tue, Sep 6, 2016 at 10:46 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > The E231732 is a 7" panel with a resolution of 800x480. From what I could make out of an archived version of Netron's website (it's unreachable from my place), they are a manufacturer of printed ribbon cables, not LCD panels. This is probably a no-go. On the side, my A23 tablet's LCD ribbon cable only had a model name, which led me to multiple Aliexpress entries. ChenYu > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 85143d1b9b31..85e988b51fbe 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1136,6 +1136,29 @@ static const struct panel_desc nec_nl4827hc19_05b = { > .bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE, > }; > > +static const struct drm_display_mode netron_dy_e231732_mode = { > + .clock = 66000, > + .hdisplay = 1024, > + .hsync_start = 1024 + 160, > + .hsync_end = 1024 + 160 + 70, > + .htotal = 1024 + 160 + 70 + 90, > + .vdisplay = 600, > + .vsync_start = 600 + 127, > + .vsync_end = 600 + 127 + 20, > + .vtotal = 600 + 127 + 20 + 3, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc netron_dy_e231732 = { > + .modes = &netron_dy_e231732_mode, > + .num_modes = 1, > + .size = { > + .width = 154, > + .height = 87, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > +}; > + > static const struct display_timing okaya_rs800480t_7x0gp_timing = { > .pixelclock = { 30000000, 30000000, 40000000 }, > .hactive = { 800, 800, 800 }, > @@ -1644,6 +1667,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "shelly,sca07010-bfn-lnn", > .data = &shelly_sca07010_bfn_lnn, > }, { > + .compatible = "netron-dy,e231732", > + .data = &netron_dy_e231732, > + }, { > .compatible = "starry,kr122ea0sra", > .data = &starry_kr122ea0sra, > }, { > -- > 2.9.3 >
On Wed, Sep 07, 2016 at 12:01:56AM +0800, Chen-Yu Tsai wrote: > Hi, > > On Tue, Sep 6, 2016 at 10:46 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > The E231732 is a 7" panel with a resolution of 800x480. > > From what I could make out of an archived version of Netron's website > (it's unreachable from my place), they are a manufacturer of printed > ribbon cables, not LCD panels. This is probably a no-go. I don't know. I haven't been able to find any website for Netron DY, however, googling the part number I used find numerous matches on ebay and alibaba. Maxime
On Tue, Sep 06, 2016 at 04:46:17PM +0200, Maxime Ripard wrote: > The E231732 is a 7" panel with a resolution of 800x480. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) This is missing a device tree binding, but since this is a simple one I added it. The commit message also says the resolution is 800x480, which conflicts with what's in the display mode definition, so I've also fixed that up while at it. Thanks, Thierry
On Thu, Jan 26, 2017 at 10:54:56AM +0100, Thierry Reding wrote: > On Tue, Sep 06, 2016 at 04:46:17PM +0200, Maxime Ripard wrote: > > The E231732 is a 7" panel with a resolution of 800x480. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > --- > > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > This is missing a device tree binding, but since this is a simple one I > added it. The commit message also says the resolution is 800x480, which > conflicts with what's in the display mode definition, so I've also > fixed that up while at it. Sorry for that :/ Thanks a lot, Maxime
Hi, Le vendredi 09 septembre 2016 à 16:35 +0200, Maxime Ripard a écrit : > On Wed, Sep 07, 2016 at 12:01:56AM +0800, Chen-Yu Tsai wrote: > > Hi, > > > > On Tue, Sep 6, 2016 at 10:46 PM, Maxime Ripard > > <maxime.ripard@free-electrons.com> wrote: > > > The E231732 is a 7" panel with a resolution of 800x480. > > > > From what I could make out of an archived version of Netron's > > website > > (it's unreachable from my place), they are a manufacturer of printed > > ribbon cables, not LCD panels. This is probably a no-go. > > I don't know. I haven't been able to find any website for Netron DY, > however, googling the part number I used find numerous matches on ebay > and alibaba. While starting a port for the A13-based TZX-Q8-713B7 tablet, it appears that my LCD cable also has the Netron-DY E231732 marking, but is definitely different from the one on the SinA33. So I think Chen-Yu's comment was founded and "Netron DY E231732" does not reflect the panel name. Here are some details regarding the LCD cable on both devices: The SinA33 has a 1024x600 panel with the following markings: 7300101463 E231732 NETRON-DY <> 1 94V-0\1310 The TZX-Q8-713B7 has a 800x480 panel with the following markings: 7300101448 E231732 NETRON-DY <> 2 94V-0\1249 So it seems that the distinctive part of the name is 7300101463/7300101448. Also, it seems that various online shops list the panels with a name like "E231732 7300101463". So maybe we could change the bindings to have: - netron-dy,e231732-7300101463 - netron-dy,e231732-7300101448 What do you think? Does that make sense? We should probably also fallback netron-dy,e231732 to the sina33's panel in order to avoid breaking the ABI. Cheers,
Hi, On Wed, May 02, 2018 at 09:20:30AM +0200, Paul Kocialkowski wrote: > Le vendredi 09 septembre 2016 à 16:35 +0200, Maxime Ripard a écrit : > > On Wed, Sep 07, 2016 at 12:01:56AM +0800, Chen-Yu Tsai wrote: > > > Hi, > > > > > > On Tue, Sep 6, 2016 at 10:46 PM, Maxime Ripard > > > <maxime.ripard@free-electrons.com> wrote: > > > > The E231732 is a 7" panel with a resolution of 800x480. > > > > > > From what I could make out of an archived version of Netron's > > > website > > > (it's unreachable from my place), they are a manufacturer of printed > > > ribbon cables, not LCD panels. This is probably a no-go. > > > > I don't know. I haven't been able to find any website for Netron DY, > > however, googling the part number I used find numerous matches on ebay > > and alibaba. > > While starting a port for the A13-based TZX-Q8-713B7 tablet, it appears > that my LCD cable also has the Netron-DY E231732 marking, but is > definitely different from the one on the SinA33. So I think Chen-Yu's > comment was founded and "Netron DY E231732" does not reflect the panel > name. > > Here are some details regarding the LCD cable on both devices: > > The SinA33 has a 1024x600 panel with the following markings: > 7300101463 > E231732 > NETRON-DY <> 1 > 94V-0\1310 > > The TZX-Q8-713B7 has a 800x480 panel with the following markings: > 7300101448 > E231732 > NETRON-DY <> 2 > 94V-0\1249 > > So it seems that the distinctive part of the name is > 7300101463/7300101448. > > Also, it seems that various online shops list the panels with a name > like "E231732 7300101463". So maybe we could change the bindings to > have: > > - netron-dy,e231732-7300101463 > - netron-dy,e231732-7300101448 > > What do you think? Does that make sense? > > We should probably also fallback netron-dy,e231732 to the sina33's panel > in order to avoid breaking the ABI. That's kind of unfortunate, and maybe the netron part is just the vendor of the flex cable. In your case, I guess the best work around this would be to call it TZX-Q8-713B7-panel, if it's shipped with a single resolution. Maxime
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1b9b31..85e988b51fbe 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1136,6 +1136,29 @@ static const struct panel_desc nec_nl4827hc19_05b = { .bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE, }; +static const struct drm_display_mode netron_dy_e231732_mode = { + .clock = 66000, + .hdisplay = 1024, + .hsync_start = 1024 + 160, + .hsync_end = 1024 + 160 + 70, + .htotal = 1024 + 160 + 70 + 90, + .vdisplay = 600, + .vsync_start = 600 + 127, + .vsync_end = 600 + 127 + 20, + .vtotal = 600 + 127 + 20 + 3, + .vrefresh = 60, +}; + +static const struct panel_desc netron_dy_e231732 = { + .modes = &netron_dy_e231732_mode, + .num_modes = 1, + .size = { + .width = 154, + .height = 87, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, +}; + static const struct display_timing okaya_rs800480t_7x0gp_timing = { .pixelclock = { 30000000, 30000000, 40000000 }, .hactive = { 800, 800, 800 }, @@ -1644,6 +1667,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "shelly,sca07010-bfn-lnn", .data = &shelly_sca07010_bfn_lnn, }, { + .compatible = "netron-dy,e231732", + .data = &netron_dy_e231732, + }, { .compatible = "starry,kr122ea0sra", .data = &starry_kr122ea0sra, }, {
The E231732 is a 7" panel with a resolution of 800x480. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)