| Message ID | 20161017213321.8074-6-stefan@agner.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 17, 2016 at 02:33:21PM -0700, Stefan Agner wrote: > There is no need to request a CMA backed framebuffer if fbdev > emulation is not enabled. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > index e04efbe..3a5880c 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > @@ -87,7 +87,8 @@ static int fsl_dcu_load(struct drm_device *dev, unsigned long flags) > goto done; > dev->irq_enabled = true; > > - fsl_dcu_fbdev_init(dev); > + if (IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)) > + fsl_dcu_fbdev_init(dev); Totally not required, since this will all no-op out. Also, please nuke that fsl_dcu_fbdv_init wrapper seems like pointless indirection. And if there really is an issue with the cma helpers allocating an fb when they should, then the correct fix is to fix that in the helpers, not in the drivers. Nack. -Daniel > > return 0; > done: > -- > 2.10.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index e04efbe..3a5880c 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -87,7 +87,8 @@ static int fsl_dcu_load(struct drm_device *dev, unsigned long flags) goto done; dev->irq_enabled = true; - fsl_dcu_fbdev_init(dev); + if (IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)) + fsl_dcu_fbdev_init(dev); return 0; done:
There is no need to request a CMA backed framebuffer if fbdev emulation is not enabled. Signed-off-by: Stefan Agner <stefan@agner.ch> --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)