| Message ID | 20161021152620.3324407-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016.10.21 17:25:49 +0200, Arnd Bergmann wrote: > The newly added gvt code produces lots of serious warnings and errors > when either built on 32-bit x86, or built with ACPI disabled, e.g. > > drivers/gpu/drm/i915/gvt/gtt.c: In function ???read_pte64???: > drivers/gpu/drm/i915/gvt/gtt.c:277:2: error: left shift count >= width of type [-Werror] > drivers/gpu/drm/i915/gvt/gtt.c: In function ???gen8_gtt_get_pfn???: > drivers/gpu/drm/i915/gvt/gtt.c:360:3: error: left shift count >= width of type [-Werror] > drivers/gpu/drm/i915/gvt/opregion.c: In function ???intel_gvt_init_opregion???: > drivers/gpu/drm/i915/gvt/opregion.c:183:2: error: implicit declaration of function ???acpi_os_ioremap??? [-Werror=implicit-function-declaration] > > This avoids the problems by simply disallowing those configurations > in Kconfig. I'm sure it's possible to make the code more portable > and support building GVT without those options, but it might not be > useful to do so. > > Fixes: 4d60c5fd3f87 ("drm/i915/gvt: vGPU PCI configuration space virtualization") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > If the code is meant to work on 32-bit and non-ACPI kernels, please > treat this as a bug report and disregard the patch. > --- Thanks, Arnd. We have to depend on 64bit now and not require for ACPI, as we used one acpi function for opregion mem map which is not necessary, so I queued one 64bit dependence and another to remove acpi dependence for Daniel. > drivers/gpu/drm/i915/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index 6d4194288d11..1b9308284dde 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -84,6 +84,7 @@ config DRM_I915_USERPTR > config DRM_I915_GVT > bool "Enable Intel GVT-g graphics virtualization host support" > depends on DRM_I915 > + depends on 64BIT && ACPI > default n > help > Choose this option if you want to enable Intel GVT-g graphics > -- > 2.9.0 >
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 6d4194288d11..1b9308284dde 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -84,6 +84,7 @@ config DRM_I915_USERPTR config DRM_I915_GVT bool "Enable Intel GVT-g graphics virtualization host support" depends on DRM_I915 + depends on 64BIT && ACPI default n help Choose this option if you want to enable Intel GVT-g graphics
The newly added gvt code produces lots of serious warnings and errors when either built on 32-bit x86, or built with ACPI disabled, e.g. drivers/gpu/drm/i915/gvt/gtt.c: In function ‘read_pte64’: drivers/gpu/drm/i915/gvt/gtt.c:277:2: error: left shift count >= width of type [-Werror] drivers/gpu/drm/i915/gvt/gtt.c: In function ‘gen8_gtt_get_pfn’: drivers/gpu/drm/i915/gvt/gtt.c:360:3: error: left shift count >= width of type [-Werror] drivers/gpu/drm/i915/gvt/opregion.c: In function ‘intel_gvt_init_opregion’: drivers/gpu/drm/i915/gvt/opregion.c:183:2: error: implicit declaration of function ‘acpi_os_ioremap’ [-Werror=implicit-function-declaration] This avoids the problems by simply disallowing those configurations in Kconfig. I'm sure it's possible to make the code more portable and support building GVT without those options, but it might not be useful to do so. Fixes: 4d60c5fd3f87 ("drm/i915/gvt: vGPU PCI configuration space virtualization") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- If the code is meant to work on 32-bit and non-ACPI kernels, please treat this as a bug report and disregard the patch. --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+)