From patchwork Fri Oct 21 15:25:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9389541 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DABC3607F0 for ; Fri, 21 Oct 2016 15:40:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA2AD2A289 for ; Fri, 21 Oct 2016 15:40:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A8F60283E4; Fri, 21 Oct 2016 15:40:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1A9A12A285 for ; Fri, 21 Oct 2016 15:40:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D18FF6ED5A; Fri, 21 Oct 2016 15:40:34 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68B876ED5A; Fri, 21 Oct 2016 15:40:33 +0000 (UTC) Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue103) with ESMTPA (Nemesis) id 0MBIsH-1c7kb42du9-00AEWC; Fri, 21 Oct 2016 17:26:23 +0200 From: Arnd Bergmann To: Daniel Vetter , Jani Nikula Subject: [PATCH 1/2] drm/i915/gvt: add ACPI and 64BIT dependencies Date: Fri, 21 Oct 2016 17:25:49 +0200 Message-Id: <20161021152620.3324407-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 X-Provags-ID: V03:K0:haPabR3uF57r3g9O8MLf48j+W1OdTJJinxdPfG+AFjfoaX1iMG9 HWXBx78X+Wpy17F44qFJmEQL1CCF7ru/PcFkcqBjIJKi9LS62iPKN6PbPN4YltPQ/jC6uo7 s1xHnuQEUH6Bw1npdmsxR8bKoGKTW5R5bn2looTTbapAgR2O+nDW09GMxay1edtq9bGEsLa /063JOcrTO7LP6Gl5ZAEg== X-UI-Out-Filterresults: notjunk:1; V01:K0:YPzQHFhpXGw=:2pyPB1sJCbqQ+oaKN2WEHy XKrUZKtYy/5JzEPiiYOtyyK+3gjtqGOk8N8A1hbs/Q595UosDZCMhqraoJog96SIXSde6/vqi b0ZAEu0pzG8oztViWZrh2d2sE1qAQCIG86RgX6j8kyOvzP6UkJb3AknlMvE/UGzq6wWJXuzFW 8NloKms401j+hiqLDU0xvaE2aQP8y3JLrA2FCZFjBN4MSaINePLEw/FuTUaJuyPFw3rr9d/wi V2mmYoDcM9LNKHlsc87OW97iZIOHKxG67/483gzjkX5JXGYzV6in6skxfxtEdI6ASbnFlEf45 HGehljUwU6+z6ZchT2ChNvGeoJpxzG271qx5rI/HJZFu2WtjjUPTyUta0K9+IvLcnYNm5HfYf uukgks0gMQ+obiIEyZNP2deqtbMBih+fTViIvgPGgekzgGkZaM1YUIKa+adcSKaVPED1b2eS5 vkf1CuWiYeND3hgwwlqKJbmpMVQCD/lgiR1V5MR4vBsLgRJGWtPyBd5Xp9QqloQCXYfSoWjUK g/9OgEphA9lDTsrb2OIG6pmLE4vRRmyxgdPLTMHuaRsKnrMcwv8Yks3uxoDwcktYHKJSBV4YW TyYsVFU4KW6esX1fpsLkeko/cFL9I44WSd7qi0Vi6rjxSNGtllkeF/bYxMAvh7NgJAmPQZFT+ 3M9pGX9kI4D3xTxapI6QHDoRrY98XtpNxIhHD798CaT5+YgiItBBwOfrrBPBakOntcravFcIG fUKKYPKIp+x9yzNR Cc: Arnd Bergmann , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Zhi Wang , Andreas Ziegler X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The newly added gvt code produces lots of serious warnings and errors when either built on 32-bit x86, or built with ACPI disabled, e.g. drivers/gpu/drm/i915/gvt/gtt.c: In function ‘read_pte64’: drivers/gpu/drm/i915/gvt/gtt.c:277:2: error: left shift count >= width of type [-Werror] drivers/gpu/drm/i915/gvt/gtt.c: In function ‘gen8_gtt_get_pfn’: drivers/gpu/drm/i915/gvt/gtt.c:360:3: error: left shift count >= width of type [-Werror] drivers/gpu/drm/i915/gvt/opregion.c: In function ‘intel_gvt_init_opregion’: drivers/gpu/drm/i915/gvt/opregion.c:183:2: error: implicit declaration of function ‘acpi_os_ioremap’ [-Werror=implicit-function-declaration] This avoids the problems by simply disallowing those configurations in Kconfig. I'm sure it's possible to make the code more portable and support building GVT without those options, but it might not be useful to do so. Fixes: 4d60c5fd3f87 ("drm/i915/gvt: vGPU PCI configuration space virtualization") Signed-off-by: Arnd Bergmann --- If the code is meant to work on 32-bit and non-ACPI kernels, please treat this as a bug report and disregard the patch. --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 6d4194288d11..1b9308284dde 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -84,6 +84,7 @@ config DRM_I915_USERPTR config DRM_I915_GVT bool "Enable Intel GVT-g graphics virtualization host support" depends on DRM_I915 + depends on 64BIT && ACPI default n help Choose this option if you want to enable Intel GVT-g graphics