From patchwork Thu Feb 16 10:59:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Archit Taneja X-Patchwork-Id: 9576823 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4891A600C5 for ; Thu, 16 Feb 2017 10:59:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4069028548 for ; Thu, 16 Feb 2017 10:59:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3162028544; Thu, 16 Feb 2017 10:59:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A00B828544 for ; Thu, 16 Feb 2017 10:59:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D0F616E29D; Thu, 16 Feb 2017 10:59:11 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A9006E29D for ; Thu, 16 Feb 2017 10:59:10 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E387A60AA3; Thu, 16 Feb 2017 10:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1487242749; bh=+tyIfxbaoF9+Q29WI3lUCk3Neg34rWgjBy++rsC08yk=; h=From:To:Cc:Subject:Date:From; b=KswRFNW9m2DvgccFzQqtfFjDhqyBsKczXTcfkqh4KKEQYduozrB7Z0RU1rN9URLBz +EJEOjS1Y8MKjGYA/QI1YlwmCn/oAkt1MMLxha+a+YJQ2TiiQJk3geE4IPjxGc/uRH 5rnWAuj64lf7vsG2pGJtvAescvmh9b1WN3Oi83hU= Received: from localhost (unknown [202.46.23.61]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: architt@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8C99B60A55; Thu, 16 Feb 2017 10:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1487242749; bh=+tyIfxbaoF9+Q29WI3lUCk3Neg34rWgjBy++rsC08yk=; h=From:To:Cc:Subject:Date:From; b=KswRFNW9m2DvgccFzQqtfFjDhqyBsKczXTcfkqh4KKEQYduozrB7Z0RU1rN9URLBz +EJEOjS1Y8MKjGYA/QI1YlwmCn/oAkt1MMLxha+a+YJQ2TiiQJk3geE4IPjxGc/uRH 5rnWAuj64lf7vsG2pGJtvAescvmh9b1WN3Oi83hU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8C99B60A55 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org From: Archit Taneja To: robdclark@gmail.com Subject: [PATCH] drm/msm/dsi: Fix bug in dsi_mgr_phy_enable Date: Thu, 16 Feb 2017 16:29:04 +0530 Message-Id: <20170216105904.4478-1-architt@codeaurora.org> X-Mailer: git-send-email 2.11.0 Cc: linux-arm-msm@vger.kernel.org, dan.carpenter@oracle.com, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP A recent commit introduces a bug in dsi_mgr_phy_enable. In the non dual DSI mode, we reset the mdsi (master DSI) PHY. This isn't right since master and slave DSI exist only in dual DSI mode. For the normal mode of operation, we should simply reset the PHY of the DSI device (i.e. msm_dsi) corresponding to the current bridge. Usage of the wrong DSI pointer also resulted in a static checker warning. That too is resolved with this fix. Fixes: b62aa70a98c5 (drm/msm/dsi: Move PHY operations out of host) Reported-by: Dan Carpenter Signed-off-by: Archit Taneja Reviewed-by: Rob Clark --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index 921270ea6059..a879ffa534b4 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -171,7 +171,7 @@ dsi_mgr_phy_enable(int id, } } } else { - msm_dsi_host_reset_phy(mdsi->host); + msm_dsi_host_reset_phy(msm_dsi->host); ret = enable_phy(msm_dsi, src_pll_id, &shared_timings[id]); if (ret) return ret;