From patchwork Fri Mar 10 04:32:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 9614709 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4942D60415 for ; Fri, 10 Mar 2017 04:42:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C41B271E0 for ; Fri, 10 Mar 2017 04:42:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3108A27B13; Fri, 10 Mar 2017 04:42:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C33CF271E0 for ; Fri, 10 Mar 2017 04:42:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0912C89CBE; Fri, 10 Mar 2017 04:39:43 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40BE26ED83 for ; Fri, 10 Mar 2017 04:34:07 +0000 (UTC) Received: by mail-qk0-x233.google.com with SMTP id 1so151490253qkl.3 for ; Thu, 09 Mar 2017 20:34:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kdrimXQs/0vvBikM+18LhUgsp+KR29qz6Ch/VvqWz+0=; b=n6GK35TvoEr50gD8kl51KDW1Ky0rt5wJ/NEjme/v+V8CP6hXyp0BqHRmGyMLGemRYx uTsw5RjjO9YzGAeFjVlN7qRGqVi7LcBbwTpBs1DQWEIfBqcc7xLOE3vltO9KY+YmApGV dVd4jZcG6nxTjrA7tPhKPh/1eiC89AIhZl8fo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kdrimXQs/0vvBikM+18LhUgsp+KR29qz6Ch/VvqWz+0=; b=rrwssNZjIsOCQYaYSd6Vxa4RJxBUEw4zfhfRwlDVhSD8rk/7kdE1sh38ArKzBZqayp jBBZzMU29YqLwcRB/DhqlEyOE2G4ojuaiCnpON87V5wpGLYKiN+mhegteUZjH1pmJ4rx 0O9GcmbIT40S7j5UfCZ5COcO+sdmxG63wPFyG3akWybEOQ2WQ1BhLpEX40fOmh9pumhk 1zVt/ZPuFaEoxizxOmrB5sI6fyekvgllHqQK6RPAROmBwYK+N3ZBkRESpfrzf78QBbSS Q+gtARPVkex+x9aHtXTw1UoLIHhU+5YhEniTZSC/4g1M/7nbJk4ou3e+JkRbKjzFw4d+ cpXQ== X-Gm-Message-State: AFeK/H1JtspGFNsy+RukN+flcpsCY+3eaK46pfxrHkOdHC6cw/L/DAlG+TPPZOYqBT90739l X-Received: by 10.55.144.6 with SMTP id s6mr18595950qkd.140.1489120446457; Thu, 09 Mar 2017 20:34:06 -0800 (PST) Received: from boxwood.roam.corp.google.com (cpe-75-189-128-87.nc.res.rr.com. [75.189.128.87]) by smtp.gmail.com with ESMTPSA id n19sm5697731qtn.35.2017.03.09.20.34.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Mar 2017 20:34:05 -0800 (PST) From: Sean Paul To: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH 02/41] drm/rockchip: Get rid of some unnecessary code Date: Thu, 9 Mar 2017 23:32:17 -0500 Message-Id: <20170310043305.17216-3-seanpaul@chromium.org> X-Mailer: git-send-email 2.12.0.246.ga2ecc84866-goog In-Reply-To: <20170310043305.17216-1-seanpaul@chromium.org> References: <20170310043305.17216-1-seanpaul@chromium.org> Cc: Tomasz Figa , linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Tomasz Figa Current code implements prepare_fb and cleanup_fb callbacks only to grab/release fb references, which is already done by atomic framework when creating/destryoing plane state. Also there are some unused fields vop and vop_win structs. Let's remove these unused bits. Signed-off-by: Tomasz Figa Signed-off-by: Sean Paul Tested-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 2151e1cee4b4..0539afb6b7c8 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -108,9 +108,6 @@ struct vop { struct drm_device *drm_dev; bool is_enabled; - /* mutex vsync_ work */ - struct mutex vsync_mutex; - bool vsync_work_pending; struct completion dsp_hold_completion; /* protected by dev->event_lock */ @@ -1592,8 +1589,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data) spin_lock_init(&vop->reg_lock); spin_lock_init(&vop->irq_lock); - mutex_init(&vop->vsync_mutex); - ret = devm_request_irq(dev, vop->irq, vop_isr, IRQF_SHARED, dev_name(dev), vop); if (ret)