From patchwork Fri Mar 10 04:32:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 9614737 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DA39760415 for ; Fri, 10 Mar 2017 04:45:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CC4EA28678 for ; Fri, 10 Mar 2017 04:45:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C0E91286EF; Fri, 10 Mar 2017 04:45:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8F96B28678 for ; Fri, 10 Mar 2017 04:45:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 127D56ED83; Fri, 10 Mar 2017 04:44:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qk0-x231.google.com (mail-qk0-x231.google.com [IPv6:2607:f8b0:400d:c09::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id B90896ED86 for ; Fri, 10 Mar 2017 04:44:14 +0000 (UTC) Received: by mail-qk0-x231.google.com with SMTP id 1so151680127qkl.3 for ; Thu, 09 Mar 2017 20:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o13rbKYFIfASFo0oiINHYUND4hnOe+D26Thy4j1eZ60=; b=XVLlVeJ6yjNyrjH9aPGq0Cmpb0wtFlciN9GKqCu4grG4oyqn5MXHl3TcLrwZYuFemV iXWsqASr2NOlh704/nQG5d5zx0ed42f2XU2PtmMk2AaoqYYhIU2+6b2VuHf51kzU8bQt 0Fc+C24TCsJzyzUiq+g3YCiAOzO1v+H2CGJCY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o13rbKYFIfASFo0oiINHYUND4hnOe+D26Thy4j1eZ60=; b=t1CbVqjfSYUWjjTvC8oOfUt8KyoESeFG6Eoag0gyLzU1pDo21e4M3SVo4vzMbK/r2Z LATOWsZV+WXSagB/zvuv2ulAoNs+ObW8PlVerF/hcvk7POVocCJtHnY3mwQAUzv68LJ1 G25k5MRZv97pM1Qk0D4h078ZPD4+rinnKoDa5E4zKv3sScHOyONcKShUR0+oQngI85lp +HNARmQuhdJMDPZEGwyFPRXhZhNtLLMs6VRZeQ/uQZoPgq0xXT4hvUvIGSgYbXMqRNeQ 5LXxAG7BwO9QCWZGuvjBvWsuL46JTJxs8XYlFR9Rj1+eb7YBEnB3QJLp6G0SDMilDTYM Yj8A== X-Gm-Message-State: AMke39k4uuuTNr6ht/uDbjp7rzfOEQsQHq5s8b2AhbUC4AmjZ+SBfbhFK6z4c1yWAOXgl8dz X-Received: by 10.55.17.206 with SMTP id 75mr18443708qkr.156.1489120483231; Thu, 09 Mar 2017 20:34:43 -0800 (PST) Received: from boxwood.roam.corp.google.com (cpe-75-189-128-87.nc.res.rr.com. [75.189.128.87]) by smtp.gmail.com with ESMTPSA id n19sm5697731qtn.35.2017.03.09.20.34.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Mar 2017 20:34:42 -0800 (PST) From: Sean Paul To: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH 06/41] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind Date: Thu, 9 Mar 2017 23:32:21 -0500 Message-Id: <20170310043305.17216-7-seanpaul@chromium.org> X-Mailer: git-send-email 2.12.0.246.ga2ecc84866-goog In-Reply-To: <20170310043305.17216-1-seanpaul@chromium.org> References: <20170310043305.17216-1-seanpaul@chromium.org> MIME-Version: 1.0 Cc: zain wang , Lin Huang , Tomeu Vizoso , Douglas Anderson , Yakir Yang , =?UTF-8?q?St=C3=A9phane=20Marchesin?= , Caesar Wang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: zain wang The bridge does not need to be powered in analogix_dp_bind(), so remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() as well as their power-off counterparts. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Caesar Wang [the patch originally just removed the power_on portion, seanpaul removed the power off code as well as improved the commit message] Signed-off-by: Sean Paul Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index c26997afd3cf..f64592f52262 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1385,11 +1385,6 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, pm_runtime_enable(dev); - pm_runtime_get_sync(dev); - phy_power_on(dp->phy); - - analogix_dp_init_dp(dp); - ret = devm_request_threaded_irq(&pdev->dev, dp->irq, analogix_dp_hardirq, analogix_dp_irq_thread, @@ -1418,15 +1413,10 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, goto err_disable_pm_runtime; } - phy_power_off(dp->phy); - pm_runtime_put(dev); - return 0; err_disable_pm_runtime: - phy_power_off(dp->phy); - pm_runtime_put(dev); pm_runtime_disable(dev); return ret;