From patchwork Tue Apr 25 03:16:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9697517 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0AB536020A for ; Tue, 25 Apr 2017 03:59:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E56F428447 for ; Tue, 25 Apr 2017 03:59:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D9DDA28456; Tue, 25 Apr 2017 03:59:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A9A7028447 for ; Tue, 25 Apr 2017 03:59:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 854CF6E2D2; Tue, 25 Apr 2017 03:59:23 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BF6489DC1 for ; Tue, 25 Apr 2017 03:16:23 +0000 (UTC) Received: by mail-pf0-x243.google.com with SMTP id c198so7431460pfc.0 for ; Mon, 24 Apr 2017 20:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YFREqXPZoMbLDO8q7Wht/o01G6iGNtQvX5e/Bvr8SYs=; b=NGLwUxYotnumbRO0SxsVwZ6x+V80RR0SEWvus8C+YYqL4GJo2jLBiTTRtRniPA9WkB HmvWv/WQkLkSScrPreARBg8n0F5JQeANiXJzAGApy8DCR3+8u27PTP1rpal63BNypzaC Awtb4BdtoUOceuYQiK4Gq/xpG+k8DWSeffKdDMgZ0Ft84IAwH+2T53sRhlDJdmYUwz43 vdc3oz70qWBhZqOf30IqnKdwTucNKQOqYm6PzvG1ar1gNzcdwbDpCKLWYuS4MYz0vcXj cdi7HB61st55RcvEzfrLcZzdM0V0WpnpBuVeyTDPJ+X5azfphYFRTQg6bTEjN3QGyDZN oxrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YFREqXPZoMbLDO8q7Wht/o01G6iGNtQvX5e/Bvr8SYs=; b=kOSWaSb1RF2R9czyfdg+wxdOWLr9FYG8MujfCytTi6j2UfLoDrjDAjrx9Gr1PxcAAe W6flshjnkkgIDyfVcwJOuJJHWtTtHYVHnpBSEHyeIpSf1VVgRVr4QN/O8OGp4dF7qzNp RcMJZpwYXPZLRrxLk097Y2YYMmGdjhCm+p14s332873cNUSdU3YdawD1KPIt2hLqoci+ PM4V3Z247Dp6cIg8LjuRHi48afpA1wx0i3oT6l9s2Czpu6UJW7ulqqCwQjhYXbS5O+5a ZGOk8DOh0ASF00PjW7TizwtpkX2XSGY8XaiFvMLU0d3XXRPDU02axJbB8Xr6X28vaDnr rotA== X-Gm-Message-State: AN3rC/4TBUz2xOO9imOYWHr5bXqvkGbZTGt6ujbt9u5X7t6GARKBTHw5 pRyxUBR5IzTPxw== X-Received: by 10.99.185.66 with SMTP id v2mr26445737pgo.165.1493090182779; Mon, 24 Apr 2017 20:16:22 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id f62sm33064898pfb.84.2017.04.24.20.16.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Apr 2017 20:16:22 -0700 (PDT) From: Wei Yongjun To: Mark Yao , David Airlie , Heiko Stuebner , Chris Zhong Subject: [PATCH -next] drm/rockchip: cdn-dp: fix return value check in cdn_dp_probe() Date: Tue, 25 Apr 2017 03:16:16 +0000 Message-Id: <20170425031616.12664-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 25 Apr 2017 03:59:20 +0000 Cc: linux-rockchip@lists.infradead.org, Wei Yongjun , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix the retrn value check which testing the wrong variable in cdn_dp_probe(). Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index 9ab67a6..6a4a113 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -1198,7 +1198,7 @@ static int cdn_dp_probe(struct platform_device *pdev) continue; port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL); - if (!dp) + if (!port) return -ENOMEM; port->extcon = extcon;