Message ID | 20170515120215.28273-1-digetx@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <dri-devel-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 20792602B4 for <patchwork-dri-devel@patchwork.kernel.org>; Tue, 16 May 2017 00:53:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A303289E0 for <patchwork-dri-devel@patchwork.kernel.org>; Tue, 16 May 2017 00:53:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F3340289E4; Tue, 16 May 2017 00:53:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B00EE289E0 for <patchwork-dri-devel@patchwork.kernel.org>; Tue, 16 May 2017 00:53:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EDE46E2CB; Tue, 16 May 2017 00:52:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qt0-x244.google.com (mail-qt0-x244.google.com [IPv6:2607:f8b0:400d:c0d::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0450E6E1C7 for <dri-devel@lists.freedesktop.org>; Mon, 15 May 2017 12:02:51 +0000 (UTC) Received: by mail-qt0-x244.google.com with SMTP id l39so15052367qtb.1 for <dri-devel@lists.freedesktop.org>; Mon, 15 May 2017 05:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=YIewHn61n8aX9ikbsbn4yRlnZH7VhgKCrlXg5NIu9Lo=; b=ND5v8p087lR01MfFx3o6eaeK2KnuV9/zEYFZZhxPAIgKguAVGxRfL0+vfGGSVYyYjf nBKowMfonBFaVvz0Kpk1/3YZgHz++dhaW8nNv5VwnYcDVDY0llvYXGZtlhlAdtGLaWlu IIwhuhCz79YBSW+fSYVkPfI0AyelDABiN19e/1atbggt8ebE9g5ELfU0ApvvHRduTdKp 278yhhPgMrmH+yL9vpy4E6S1aP71ouWiYIl06MOqeu7PAV7N7inNop3W5t7qABehtXHo BQMtSOsXBs7ep8E7CjGadnTYRHucro8yHRvt7PO8FQVHVgxbBhrCyrv4pcj+QUxMNPhs zvQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YIewHn61n8aX9ikbsbn4yRlnZH7VhgKCrlXg5NIu9Lo=; b=SYvBtv4dgH7bWYSfgtWyfQnelNOp+RvyveYh7IDCk3CK8aBK/bf03Fg+uGNug83NeH hStGGfWJ3Rq9HCwle076fZeFrT+TKJXjIlv2syBsH7V5/qcgX7iXajAz2NEFpBBI61wv ry1i2OH1qDfb4rBgyVnEdN5Lv1P2GxdALxz3aVeetfS8zKhwzhT4dwt9GR4W2YZ7psPL uqasVr21b2HjLrpPXUcD0FesZURWjmhCYFC6GRSbgMzHk6itybPK1UXMwAJ6icFmCht0 HIlOOxvUXnWWiT8Akh0q5xAXtoROZ4VY19SPZwPmYKtTXBcLEoQIJg9Bz2X7RjrBQgUw 0jtQ== X-Gm-Message-State: AODbwcBY2JsqfEWyXgPoneW4tBzq6g0Yrt4rk67sqraQnbuHcQWuW4Tk X+LUvJLBWVRQZw== X-Received: by 10.25.77.79 with SMTP id a76mr1770688lfb.121.1494849770173; Mon, 15 May 2017 05:02:50 -0700 (PDT) Received: from localhost.localdomain (ppp109-252-91-175.pppoe.spdop.ru. [109.252.91.175]) by smtp.gmail.com with ESMTPSA id 8sm2147026lju.6.2017.05.15.05.02.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 May 2017 05:02:49 -0700 (PDT) From: Dmitry Osipenko <digetx@gmail.com> To: Thierry Reding <thierry.reding@gmail.com>, Mikko Perttunen <cyndis@kapsi.fi> Subject: [PATCH] gpu: host1x: Forbid RESTART opcode in the firewall Date: Mon, 15 May 2017 15:02:15 +0300 Message-Id: <20170515120215.28273-1-digetx@gmail.com> X-Mailer: git-send-email 2.13.0 X-Mailman-Approved-At: Tue, 16 May 2017 00:51:18 +0000 Cc: linux-tegra@vger.kernel.org, DRI Development <dri-devel@lists.freedesktop.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development <dri-devel.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/dri-devel> List-Post: <mailto:dri-devel@lists.freedesktop.org> List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index 8f0d43b8f9a6..d648748b3e74 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -493,7 +493,6 @@ static int validate(struct host1x_firewall *fw, struct host1x_job_gather *g) goto out; break; case 4: - case 5: case 14: break; default:
The RESTART opcode terminates the gather and restarts the CDMA fetch from a specified word << 2 relative to the CDMA start address. That shouldn't be allowed to be done by userspace. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/gpu/host1x/job.c | 1 - 1 file changed, 1 deletion(-)