From patchwork Fri Jun 2 11:07:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kernel test robot X-Patchwork-Id: 9762243 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 88A69602BF for ; Fri, 2 Jun 2017 11:08:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FEA7284FC for ; Fri, 2 Jun 2017 11:08:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4117328506; Fri, 2 Jun 2017 11:08:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 94816284FC for ; Fri, 2 Jun 2017 11:08:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FE4A6E0A1; Fri, 2 Jun 2017 11:08:33 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBD2E6E0A1 for ; Fri, 2 Jun 2017 11:08:31 +0000 (UTC) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jun 2017 04:08:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,284,1493708400"; d="scan'208";a="93966073" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by orsmga004.jf.intel.com with ESMTP; 02 Jun 2017 04:08:18 -0700 Received: from kbuild by bee with local (Exim 4.84_2) (envelope-from ) id 1dGkUp-000Jea-Mz; Fri, 02 Jun 2017 19:11:59 +0800 Date: Fri, 2 Jun 2017 19:07:30 +0800 From: kbuild test robot To: Boris Brezillon Subject: [PATCH] drm/bridge: fix odd_ptr_err.cocci warnings Message-ID: <20170602110728.GA18161@lkp-hsx03.lkp.intel.com> References: <201706021924.1vwA2TOY%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1496390360-7958-1-git-send-email-boris.brezillon@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Cc: Mark Rutland , devicetree@vger.kernel.org, Cyprian Wronka , Pawel Moll , Ian Campbell , Simon Hatliff , dri-devel@lists.freedesktop.org, Richard Sproul , Alan Douglas , Rob Herring , kbuild-all@01.org, Kumar Gala , Maxime Ripard , Thomas Petazzoni , Neil Webb X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP drivers/gpu/drm/bridge/cdns-dsi.c:980:5-11: inconsistent IS_ERR and PTR_ERR on line 981. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Boris Brezillon Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! cdns-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/bridge/cdns-dsi.c +++ b/drivers/gpu/drm/bridge/cdns-dsi.c @@ -978,7 +978,7 @@ static int cdns_dsi_drm_probe(struct pla dsi->sysclk = devm_clk_get(&pdev->dev, "sysclk"); if (IS_ERR(dsi->sysclk)) - return PTR_ERR(dsi->pclk); + return PTR_ERR(dsi->sysclk); irq = platform_get_irq(pdev, 0); if (irq < 0)