| Message ID | 20170609175401.40204-2-hverkuil@xs4all.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-06-09 19:54 GMT+02:00 Hans Verkuil <hverkuil@xs4all.nl>: > From: Hans Verkuil <hans.verkuil@cisco.com> > > Document common HDMI CEC bindings. Add this to the MAINTAINERS file > as well. > > Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Andrzej Hajda <a.hajda@samsung.com> > Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> > Cc: devicetree@vger.kernel.org > --- > Documentation/devicetree/bindings/media/cec.txt | 8 ++++++++ > MAINTAINERS | 1 + > 2 files changed, 9 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/cec.txt > > diff --git a/Documentation/devicetree/bindings/media/cec.txt b/Documentation/devicetree/bindings/media/cec.txt > new file mode 100644 > index 000000000000..22d7aae3d3d7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/cec.txt > @@ -0,0 +1,8 @@ > +Common bindings for HDMI CEC adapters > + > +- hdmi-phandle: phandle to the HDMI controller. > + > +- needs-hpd: if present the CEC support is only available when the HPD > + is high. Some boards only let the CEC pin through if the HPD is high, > + for example if there is a level converter that uses the HPD to power > + up or down. > diff --git a/MAINTAINERS b/MAINTAINERS > index 053c3bdd1fe5..4ac340d189a3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3137,6 +3137,7 @@ F: include/media/cec.h > F: include/media/cec-notifier.h > F: include/uapi/linux/cec.h > F: include/uapi/linux/cec-funcs.h > +F: Documentation/devicetree/bindings/media/cec.txt > > CELL BROADBAND ENGINE ARCHITECTURE > M: Arnd Bergmann <arnd@arndb.de> > -- > 2.11.0 > Looks good for me Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
On 06/09/2017 07:54 PM, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil@cisco.com> > > Document common HDMI CEC bindings. Add this to the MAINTAINERS file > as well. > > Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Documentation/devicetree/bindings/media/cec.txt | 8 ++++++++ > MAINTAINERS | 1 + > 2 files changed, 9 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/cec.txt > > diff --git a/Documentation/devicetree/bindings/media/cec.txt b/Documentation/devicetree/bindings/media/cec.txt > new file mode 100644 > index 000000000000..22d7aae3d3d7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/cec.txt > @@ -0,0 +1,8 @@ > +Common bindings for HDMI CEC adapters > + > +- hdmi-phandle: phandle to the HDMI controller. For a common property I would rather make it "hdmi-controller", this "-phandle" part feels like appending "_pointer" to variable names in C code. But since you are just rearranging existing documentation and Rob agrees with that I have no objections. > +- needs-hpd: if present the CEC support is only available when the HPD > + is high. Some boards only let the CEC pin through if the HPD is high, > + for example if there is a level converter that uses the HPD to power > + up or down. > diff --git a/MAINTAINERS b/MAINTAINERS > index 053c3bdd1fe5..4ac340d189a3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3137,6 +3137,7 @@ F: include/media/cec.h > F: include/media/cec-notifier.h > F: include/uapi/linux/cec.h > F: include/uapi/linux/cec-funcs.h > +F: Documentation/devicetree/bindings/media/cec.txt > > CELL BROADBAND ENGINE ARCHITECTURE > M: Arnd Bergmann <arnd@arndb.de -- Regards, Sylwester
On Fri, Jun 9, 2017 at 12:54 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote: > From: Hans Verkuil <hans.verkuil@cisco.com> > > Document common HDMI CEC bindings. Add this to the MAINTAINERS file > as well. > > Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Andrzej Hajda <a.hajda@samsung.com> > Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> > Cc: devicetree@vger.kernel.org > --- > Documentation/devicetree/bindings/media/cec.txt | 8 ++++++++ > MAINTAINERS | 1 + > 2 files changed, 9 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/cec.txt Reviewed-by: Rob Herring <robh@kernel.org> Thanks for doing this. Rob
diff --git a/Documentation/devicetree/bindings/media/cec.txt b/Documentation/devicetree/bindings/media/cec.txt new file mode 100644 index 000000000000..22d7aae3d3d7 --- /dev/null +++ b/Documentation/devicetree/bindings/media/cec.txt @@ -0,0 +1,8 @@ +Common bindings for HDMI CEC adapters + +- hdmi-phandle: phandle to the HDMI controller. + +- needs-hpd: if present the CEC support is only available when the HPD + is high. Some boards only let the CEC pin through if the HPD is high, + for example if there is a level converter that uses the HPD to power + up or down. diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bdd1fe5..4ac340d189a3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3137,6 +3137,7 @@ F: include/media/cec.h F: include/media/cec-notifier.h F: include/uapi/linux/cec.h F: include/uapi/linux/cec-funcs.h +F: Documentation/devicetree/bindings/media/cec.txt CELL BROADBAND ENGINE ARCHITECTURE M: Arnd Bergmann <arnd@arndb.de>