| Message ID | 20170620203125.555483-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Arnd, On Tue, Jun 20, 2017 at 10:30:38PM +0200, Arnd Bergmann wrote: > The last rework left behind two unused variables: > > drm/arm/hdlcd_crtc.c: In function 'hdlcd_plane_atomic_update': > drm/arm/hdlcd_crtc.c:264:13: warning: unused variable 'src_y' [-Wunused-variable] > drm/arm/hdlcd_crtc.c:264:6: warning: unused variable 'src_x' [-Wunused-variable] > > This removes them. Thanks for the patch! Acked-by: Liviu Dudau <liviu.dudau@arm.com> This is starting to get embarrassing :) I'm not sure why I didn't see the warnings when I did my builds, but I would like to make changes so that in the future I can catch situations like this. Do you change the flags of the default make multi_v7_defconfig? I will apply the patch to the HLDCD tree and send Dave an updated pull request. Best regards, Liviu > > Fixes: b2ae06ae9834 ("drm/arm: hdlcd: Use CMA helper for plane buffer address calculation") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/arm/hdlcd_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c > index 0128ebd318f5..d67b6f15e8b8 100644 > --- a/drivers/gpu/drm/arm/hdlcd_crtc.c > +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c > @@ -261,7 +261,7 @@ static void hdlcd_plane_atomic_update(struct drm_plane *plane, > { > struct drm_framebuffer *fb = plane->state->fb; > struct hdlcd_drm_private *hdlcd; > - u32 src_x, src_y, dest_h; > + u32 dest_h; > dma_addr_t scanout_start; > > if (!fb) > -- > 2.9.0 >
On Wed, Jun 21, 2017 at 10:16 AM, Liviu Dudau <liviu.dudau@arm.com> wrote: > Hi Arnd, > > On Tue, Jun 20, 2017 at 10:30:38PM +0200, Arnd Bergmann wrote: >> The last rework left behind two unused variables: >> >> drm/arm/hdlcd_crtc.c: In function 'hdlcd_plane_atomic_update': >> drm/arm/hdlcd_crtc.c:264:13: warning: unused variable 'src_y' [-Wunused-variable] >> drm/arm/hdlcd_crtc.c:264:6: warning: unused variable 'src_x' [-Wunused-variable] >> >> This removes them. > > Thanks for the patch! Acked-by: Liviu Dudau <liviu.dudau@arm.com> > > This is starting to get embarrassing :) I'm not sure why I didn't see the warnings when > I did my builds, but I would like to make changes so that in the future I can catch > situations like this. Do you change the flags of the default make multi_v7_defconfig? I mainly do randconfig testing, which catches a lot of bugs that you don't see in the defconfig build. My general recommendation is to build-test on ARM allmodconfig and x86 allmodconfig, and to ensure that all new code gets enabled with CONFIG_COMPILE_TEST in those builds. > I will apply the patch to the HLDCD tree and send Dave an updated pull request. Ok, thanks! Arnd
diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c index 0128ebd318f5..d67b6f15e8b8 100644 --- a/drivers/gpu/drm/arm/hdlcd_crtc.c +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c @@ -261,7 +261,7 @@ static void hdlcd_plane_atomic_update(struct drm_plane *plane, { struct drm_framebuffer *fb = plane->state->fb; struct hdlcd_drm_private *hdlcd; - u32 src_x, src_y, dest_h; + u32 dest_h; dma_addr_t scanout_start; if (!fb)
The last rework left behind two unused variables: drm/arm/hdlcd_crtc.c: In function 'hdlcd_plane_atomic_update': drm/arm/hdlcd_crtc.c:264:13: warning: unused variable 'src_y' [-Wunused-variable] drm/arm/hdlcd_crtc.c:264:6: warning: unused variable 'src_x' [-Wunused-variable] This removes them. Fixes: b2ae06ae9834 ("drm/arm: hdlcd: Use CMA helper for plane buffer address calculation") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/arm/hdlcd_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)