diff mbox

[1/2] drm/dp: Fix read pointer for drm_dp_downsteam_debug()

Message ID 20170720174532.23377-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson July 20, 2017, 5:45 p.m. UTC 
Pass in the array and not a pointer to the array to drm_dp_dpcd_read().

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/drm_dp_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jani Nikula July 21, 2017, 7:19 a.m. UTC | #1 
On Thu, 20 Jul 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Pass in the array and not a pointer to the array to drm_dp_dpcd_read().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/drm_dp_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 213fb837e1c4..1d9e30f0dbf8 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -591,7 +591,7 @@ void drm_dp_downstream_debug(struct seq_file *m,
>  		seq_printf(m, "\t\tHW: %d.%d\n",
>  			   (rev[0] & 0xf0) >> 4, rev[0] & 0xf);
>  
> -	len = drm_dp_dpcd_read(aux, DP_BRANCH_SW_REV, &rev, 2);
> +	len = drm_dp_dpcd_read(aux, DP_BRANCH_SW_REV, rev, 2);
>  	if (len > 0)
>  		seq_printf(m, "\t\tSW: %d.%d\n", rev[0], rev[1]);
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 213fb837e1c4..1d9e30f0dbf8 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -591,7 +591,7 @@  void drm_dp_downstream_debug(struct seq_file *m,
 		seq_printf(m, "\t\tHW: %d.%d\n",
 			   (rev[0] & 0xf0) >> 4, rev[0] & 0xf);
 
-	len = drm_dp_dpcd_read(aux, DP_BRANCH_SW_REV, &rev, 2);
+	len = drm_dp_dpcd_read(aux, DP_BRANCH_SW_REV, rev, 2);
 	if (len > 0)
 		seq_printf(m, "\t\tSW: %d.%d\n", rev[0], rev[1]);