| Message ID | 20170730134255.41fff297@endymion (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Jul 30, 2017 at 7:42 AM, Jean Delvare <jdelvare@suse.de> wrote: > Include a missing header to get rid of the following warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:65:6: warning: no previous prototype for ‘amdgpu_pm_acpi_event_handler’ [-Wmissing-prototypes] > void amdgpu_pm_acpi_event_handler(struct amdgpu_device *adev) > ^ > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> Applied. thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > --- linux-4.12.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c 2017-07-30 13:18:54.991917627 +0200 > +++ linux-4.12/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c 2017-07-30 13:26:16.786365654 +0200 > @@ -30,10 +30,10 @@ > #include <drm/drmP.h> > #include <drm/drm_crtc_helper.h> > #include "amdgpu.h" > +#include "amdgpu_pm.h" > #include "amd_acpi.h" > #include "atom.h" > > -extern void amdgpu_pm_acpi_event_handler(struct amdgpu_device *adev); > /* Call the ATIF method > */ > /** > --- linux-4.12.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h 2017-07-30 13:18:54.991917627 +0200 > +++ linux-4.12/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h 2017-07-30 13:26:16.787365666 +0200 > @@ -30,6 +30,7 @@ struct cg_flag_name > const char *name; > }; > > +void amdgpu_pm_acpi_event_handler(struct amdgpu_device *adev); > int amdgpu_pm_sysfs_init(struct amdgpu_device *adev); > void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev); > void amdgpu_pm_print_power_states(struct amdgpu_device *adev); > > > -- > Jean Delvare > SUSE L3 Support > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--- linux-4.12.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c 2017-07-30 13:18:54.991917627 +0200 +++ linux-4.12/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c 2017-07-30 13:26:16.786365654 +0200 @@ -30,10 +30,10 @@ #include <drm/drmP.h> #include <drm/drm_crtc_helper.h> #include "amdgpu.h" +#include "amdgpu_pm.h" #include "amd_acpi.h" #include "atom.h" -extern void amdgpu_pm_acpi_event_handler(struct amdgpu_device *adev); /* Call the ATIF method */ /** --- linux-4.12.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h 2017-07-30 13:18:54.991917627 +0200 +++ linux-4.12/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h 2017-07-30 13:26:16.787365666 +0200 @@ -30,6 +30,7 @@ struct cg_flag_name const char *name; }; +void amdgpu_pm_acpi_event_handler(struct amdgpu_device *adev); int amdgpu_pm_sysfs_init(struct amdgpu_device *adev); void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev); void amdgpu_pm_print_power_states(struct amdgpu_device *adev);
Include a missing header to get rid of the following warning: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:65:6: warning: no previous prototype for ‘amdgpu_pm_acpi_event_handler’ [-Wmissing-prototypes] void amdgpu_pm_acpi_event_handler(struct amdgpu_device *adev) ^ Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: "Christian König" <christian.koenig@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)