diff mbox

[2/2] drm/ttm: Remove needless 'extern' on functions in header.

Message ID 20170824104818.9973-2-tom.stdenis@amd.com (mailing list archive)
State New, archived
Headers show

Commit Message

StDenis, Tom Aug. 24, 2017, 10:48 a.m. UTC
Minor tidy up.

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
---
 include/drm/ttm/ttm_page_alloc.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Christian König Aug. 24, 2017, 11:53 a.m. UTC | #1
Am 24.08.2017 um 12:48 schrieb Tom St Denis:
> Minor tidy up.
>
> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>

Thanks and sorry that I thought you added this, I really need more sleep.

Patch is Reviewed-by: Christian König <christian.koenig@amd.com>.

Christian.

> ---
>   include/drm/ttm/ttm_page_alloc.h | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/drm/ttm/ttm_page_alloc.h b/include/drm/ttm/ttm_page_alloc.h
> index 4400c08169cd..19bdd907613c 100644
> --- a/include/drm/ttm/ttm_page_alloc.h
> +++ b/include/drm/ttm/ttm_page_alloc.h
> @@ -47,7 +47,7 @@ void ttm_page_alloc_fini(void);
>    *
>    * Add backing pages to all of @ttm
>    */
> -extern int ttm_pool_populate(struct ttm_tt *ttm);
> +int ttm_pool_populate(struct ttm_tt *ttm);
>   
>   /**
>    * ttm_pool_unpopulate:
> @@ -56,12 +56,12 @@ extern int ttm_pool_populate(struct ttm_tt *ttm);
>    *
>    * Free all pages of @ttm
>    */
> -extern void ttm_pool_unpopulate(struct ttm_tt *ttm);
> +void ttm_pool_unpopulate(struct ttm_tt *ttm);
>   
>   /**
>    * Output the state of pools to debugfs file
>    */
> -extern int ttm_page_alloc_debugfs(struct seq_file *m, void *data);
> +int ttm_page_alloc_debugfs(struct seq_file *m, void *data);
>   
>   
>   #if defined(CONFIG_SWIOTLB) || defined(CONFIG_INTEL_IOMMU)
> @@ -78,10 +78,10 @@ void ttm_dma_page_alloc_fini(void);
>   /**
>    * Output the state of pools to debugfs file
>    */
> -extern int ttm_dma_page_alloc_debugfs(struct seq_file *m, void *data);
> +int ttm_dma_page_alloc_debugfs(struct seq_file *m, void *data);
>   
> -extern int ttm_dma_populate(struct ttm_dma_tt *ttm_dma, struct device *dev);
> -extern void ttm_dma_unpopulate(struct ttm_dma_tt *ttm_dma, struct device *dev);
> +int ttm_dma_populate(struct ttm_dma_tt *ttm_dma, struct device *dev);
> +void ttm_dma_unpopulate(struct ttm_dma_tt *ttm_dma, struct device *dev);
>   
>   
>   /**
StDenis, Tom Aug. 24, 2017, 11:55 a.m. UTC | #2
On 24/08/17 07:53 AM, Christian König wrote:
> Am 24.08.2017 um 12:48 schrieb Tom St Denis:
>> Minor tidy up.
>>
>> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
> 
> Thanks and sorry that I thought you added this, I really need more sleep.
> 
> Patch is Reviewed-by: Christian König <christian.koenig@amd.com>.

No worries.  For a second there I thought I was writing patches too 
early for me :)

Should be an AMD rule that no patches before sun up in the summer... 
Alas in Winter here in Canada that'd cut productivity down to 20% hehehe.

Cheers,
Tom
diff mbox

Patch

diff --git a/include/drm/ttm/ttm_page_alloc.h b/include/drm/ttm/ttm_page_alloc.h
index 4400c08169cd..19bdd907613c 100644
--- a/include/drm/ttm/ttm_page_alloc.h
+++ b/include/drm/ttm/ttm_page_alloc.h
@@ -47,7 +47,7 @@  void ttm_page_alloc_fini(void);
  *
  * Add backing pages to all of @ttm
  */
-extern int ttm_pool_populate(struct ttm_tt *ttm);
+int ttm_pool_populate(struct ttm_tt *ttm);
 
 /**
  * ttm_pool_unpopulate:
@@ -56,12 +56,12 @@  extern int ttm_pool_populate(struct ttm_tt *ttm);
  *
  * Free all pages of @ttm
  */
-extern void ttm_pool_unpopulate(struct ttm_tt *ttm);
+void ttm_pool_unpopulate(struct ttm_tt *ttm);
 
 /**
  * Output the state of pools to debugfs file
  */
-extern int ttm_page_alloc_debugfs(struct seq_file *m, void *data);
+int ttm_page_alloc_debugfs(struct seq_file *m, void *data);
 
 
 #if defined(CONFIG_SWIOTLB) || defined(CONFIG_INTEL_IOMMU)
@@ -78,10 +78,10 @@  void ttm_dma_page_alloc_fini(void);
 /**
  * Output the state of pools to debugfs file
  */
-extern int ttm_dma_page_alloc_debugfs(struct seq_file *m, void *data);
+int ttm_dma_page_alloc_debugfs(struct seq_file *m, void *data);
 
-extern int ttm_dma_populate(struct ttm_dma_tt *ttm_dma, struct device *dev);
-extern void ttm_dma_unpopulate(struct ttm_dma_tt *ttm_dma, struct device *dev);
+int ttm_dma_populate(struct ttm_dma_tt *ttm_dma, struct device *dev);
+void ttm_dma_unpopulate(struct ttm_dma_tt *ttm_dma, struct device *dev);
 
 
 /**