| Message ID | 20170905121018.11477-1-lars@metafoo.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 5, 2017 at 5:10 AM, Lars-Peter Clausen <lars@metafoo.de> wrote: > Currently adv7511_get_modes() bails out early when no EDID could be > retrieved. This leaves the previous EDID in place, which is typically not > the intended behavior and might confuse applications. Instead the EDID > should be cleared when no EDID could be retrieved. > > All functions that are called after the EDID check handle the case where > the EDID is NULL just fine and exhibit the expected behavior, so just drop > the check. > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> No objections from me. Ran these on my HiKey board ontop of Linus's HEAD, and everything seemed ok. So for the whole patchset: Tested-by: John Stultz <john.stultz@linaro.org> thanks -john
On 09/05/2017 10:14 PM, John Stultz wrote: > On Tue, Sep 5, 2017 at 5:10 AM, Lars-Peter Clausen <lars@metafoo.de> wrote: >> Currently adv7511_get_modes() bails out early when no EDID could be >> retrieved. This leaves the previous EDID in place, which is typically not >> the intended behavior and might confuse applications. Instead the EDID >> should be cleared when no EDID could be retrieved. >> >> All functions that are called after the EDID check handle the case where >> the EDID is NULL just fine and exhibit the expected behavior, so just drop >> the check. >> >> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > > No objections from me. Ran these on my HiKey board ontop of Linus's > HEAD, and everything seemed ok. > > So for the whole patchset: > Tested-by: John Stultz <john.stultz@linaro.org> The set looks good to me too. I'll queue it to drm-misc-next in a few days. Thanks, Archit > > thanks > -john >
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index b2431aee7887..fb8f4cd29e15 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -591,8 +591,6 @@ static int adv7511_get_modes(struct adv7511 *adv7511, kfree(adv7511->edid); adv7511->edid = edid; - if (!edid) - return 0; drm_mode_connector_update_edid_property(connector, edid); count = drm_add_edid_modes(connector, edid);
Currently adv7511_get_modes() bails out early when no EDID could be retrieved. This leaves the previous EDID in place, which is typically not the intended behavior and might confuse applications. Instead the EDID should be cleared when no EDID could be retrieved. All functions that are called after the EDID check handle the case where the EDID is NULL just fine and exhibit the expected behavior, so just drop the check. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 -- 1 file changed, 2 deletions(-)