| Message ID | 20170908143218.9701-1-seanpaul@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 08, 2017 at 10:32:07AM -0400, Sean Paul wrote: > Now that we have the DRM_DEV_* variants, we should use them. > > Signed-off-by: Sean Paul <seanpaul@chromium.org> I think that's fairly ideal fodder for outreachy, assume we make sure the driver maintainer is ok with the resulting torrent of patches first :-) -Daniel > --- > Documentation/gpu/todo.rst | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 22af55d06ab8..e3b622094bf4 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -177,6 +177,17 @@ following drivers still use ``struct_mutex``: ``msm``, ``omapdrm`` and > > Contact: Daniel Vetter, respective driver maintainers > > +Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent > +---------------------------------------------------------------------------- > + > +For drivers which could have multiple instances, it is necessary to > +differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR > +don't do this, drivers used dev_info/warn/err to make this differentiation. We > +now have DRM_DEV_* variants of the drm print macros, so we can start to convert > +those drivers back to using drm-formwatted specific log messages. > + > +Contact: Sean Paul, Maintainer of the driver you plan to convert > + > Core refactorings > ================= > > -- > 2.14.1.581.gf28d330327-goog > > -- > To unsubscribe from this list: send the line "unsubscribe linux-doc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Sep 8, 2017 at 11:44 AM, Daniel Vetter <daniel@ffwll.ch> wrote: > On Fri, Sep 08, 2017 at 10:32:07AM -0400, Sean Paul wrote: >> Now that we have the DRM_DEV_* variants, we should use them. >> >> Signed-off-by: Sean Paul <seanpaul@chromium.org> > > I think that's fairly ideal fodder for outreachy, assume we make sure the > driver maintainer is ok with the resulting torrent of patches first :-) I'll happily review patches that convert rockchip. Sean > -Daniel > >> --- >> Documentation/gpu/todo.rst | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst >> index 22af55d06ab8..e3b622094bf4 100644 >> --- a/Documentation/gpu/todo.rst >> +++ b/Documentation/gpu/todo.rst >> @@ -177,6 +177,17 @@ following drivers still use ``struct_mutex``: ``msm``, ``omapdrm`` and >> >> Contact: Daniel Vetter, respective driver maintainers >> >> +Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent >> +---------------------------------------------------------------------------- >> + >> +For drivers which could have multiple instances, it is necessary to >> +differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR >> +don't do this, drivers used dev_info/warn/err to make this differentiation. We >> +now have DRM_DEV_* variants of the drm print macros, so we can start to convert >> +those drivers back to using drm-formwatted specific log messages. >> + >> +Contact: Sean Paul, Maintainer of the driver you plan to convert >> + >> Core refactorings >> ================= >> >> -- >> 2.14.1.581.gf28d330327-goog >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-doc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
On Fri, Sep 8, 2017 at 10:32 AM, Sean Paul <seanpaul@chromium.org> wrote: > Now that we have the DRM_DEV_* variants, we should use them. > > Signed-off-by: Sean Paul <seanpaul@chromium.org> Applied to -misc-next with danvet's R-b. Sean > --- > Documentation/gpu/todo.rst | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 22af55d06ab8..e3b622094bf4 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -177,6 +177,17 @@ following drivers still use ``struct_mutex``: ``msm``, ``omapdrm`` and > > Contact: Daniel Vetter, respective driver maintainers > > +Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent > +---------------------------------------------------------------------------- > + > +For drivers which could have multiple instances, it is necessary to > +differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR > +don't do this, drivers used dev_info/warn/err to make this differentiation. We > +now have DRM_DEV_* variants of the drm print macros, so we can start to convert > +those drivers back to using drm-formwatted specific log messages. > + > +Contact: Sean Paul, Maintainer of the driver you plan to convert > + > Core refactorings > ================= > > -- > 2.14.1.581.gf28d330327-goog >
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 22af55d06ab8..e3b622094bf4 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -177,6 +177,17 @@ following drivers still use ``struct_mutex``: ``msm``, ``omapdrm`` and Contact: Daniel Vetter, respective driver maintainers +Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent +---------------------------------------------------------------------------- + +For drivers which could have multiple instances, it is necessary to +differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR +don't do this, drivers used dev_info/warn/err to make this differentiation. We +now have DRM_DEV_* variants of the drm print macros, so we can start to convert +those drivers back to using drm-formwatted specific log messages. + +Contact: Sean Paul, Maintainer of the driver you plan to convert + Core refactorings =================
Now that we have the DRM_DEV_* variants, we should use them. Signed-off-by: Sean Paul <seanpaul@chromium.org> --- Documentation/gpu/todo.rst | 11 +++++++++++ 1 file changed, 11 insertions(+)