From patchwork Thu Sep 21 17:06:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 9964405 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C31766020C for ; Thu, 21 Sep 2017 17:07:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AF6C526538 for ; Thu, 21 Sep 2017 17:07:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A44582679B; Thu, 21 Sep 2017 17:07:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 627B326538 for ; Thu, 21 Sep 2017 17:07:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 01A596E8B2; Thu, 21 Sep 2017 17:07:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x22e.google.com (mail-pf0-x22e.google.com [IPv6:2607:f8b0:400e:c00::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43B536E8B2 for ; Thu, 21 Sep 2017 17:07:20 +0000 (UTC) Received: by mail-pf0-x22e.google.com with SMTP id e1so3517313pfk.1 for ; Thu, 21 Sep 2017 10:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qnmgk5r51uPZ1X9RUYiJRtNasG3VJnTyh7PjVk9iZBw=; b=I2yEGvL1z1mbw48K9TzgICgeiAxHqBbpZJjaps7N7CA6QDDwDTqBUTr8UWpkir0ra2 ErVtpCB+41dHiVWhUN4/F5ecThtnnfYRJF6N4VwvLFIjZW85hNv3VdwK34sd3DYRedHa Wq7Iu3NGik+Ueu0U2f+xLwKf0y3qAgxh8oZXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qnmgk5r51uPZ1X9RUYiJRtNasG3VJnTyh7PjVk9iZBw=; b=r0dLx0HZZsZi3Dh84+G8gCOBapCELXMvXgezGgyZ4+mkGEWW0J2STxgORILXsUXaEi WwJITOd5LDrtCtaeeZ4+gvo3odBJ9K7fBWy8MHpFuMC62yj+swfhTOhNnGXfXIprMGSQ weCxLmP/WyC7q/0CpIpegxGdSY2uO273QfyPQeaB/8vQC4Z55Hp7N1+Au9G5UI4jti3N tfoidnFh7irb3oM1H3ztjk8WZpKRtIH3DGJwYoHvIPNunFOECtiO++mXh0OU7fNayIaK ZXpFL+ASHdUy+f366z1/36HUIyINVENSWc6lTmmWtAF0sA+l4NbloZrP7IE7pErv4qYg pbLg== X-Gm-Message-State: AHPjjUizbXgcU+7rHP33BPPSrOrPQYhrlFXNs3Iw6nb4i4tDteT/lmwz QILxPo5t3L1pC6AYGO2MbdX3htQZ9aI= X-Google-Smtp-Source: AOwi7QDB8WrhliHjXTJAdz94qkXu48p/rH79L8FA0KXvp7/vnIQiL19q+G/GrWQEkyCSRBybAACVvg== X-Received: by 10.99.109.8 with SMTP id i8mr6510433pgc.412.1506013639565; Thu, 21 Sep 2017 10:07:19 -0700 (PDT) Received: from trickycodes.corp.google.com ([172.19.15.95]) by smtp.gmail.com with ESMTPSA id l86sm3317481pfg.155.2017.09.21.10.07.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Sep 2017 10:07:18 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH 05/10] drm/panel: otm8009a: Remove enabled state Date: Thu, 21 Sep 2017 10:06:16 -0700 Message-Id: <20170921170638.27031-6-seanpaul@chromium.org> X-Mailer: git-send-email 2.14.1.821.g8fa685d3b7-goog In-Reply-To: <20170921170638.27031-1-seanpaul@chromium.org> References: <20170921170638.27031-1-seanpaul@chromium.org> Cc: Thierry Reding X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP It's not necessary for atomic drivers, and drm_panel will WARN if the calls are unbalanced. Signed-off-by: Sean Paul --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c index c189cd6329c8..0a5898fd4502 100644 --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c @@ -63,7 +63,6 @@ struct otm8009a { struct backlight_device *bl_dev; struct gpio_desc *reset_gpio; bool prepared; - bool enabled; }; static const struct drm_display_mode default_mode = { @@ -243,9 +242,6 @@ static int otm8009a_disable(struct drm_panel *panel) struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); int ret; - if (!ctx->enabled) - return 0; /* This is not an issue so we return 0 here */ - /* Power off the backlight. Note: end-user still controls brightness */ ctx->bl_dev->props.power = FB_BLANK_POWERDOWN; ret = backlight_update_status(ctx->bl_dev); @@ -262,8 +258,6 @@ static int otm8009a_disable(struct drm_panel *panel) msleep(120); - ctx->enabled = false; - return 0; } @@ -316,15 +310,6 @@ static int otm8009a_prepare(struct drm_panel *panel) return 0; } -static int otm8009a_enable(struct drm_panel *panel) -{ - struct otm8009a *ctx = panel_to_otm8009a(panel); - - ctx->enabled = true; - - return 0; -} - static int otm8009a_get_modes(struct drm_panel *panel) { struct drm_display_mode *mode; @@ -352,7 +337,6 @@ static const struct drm_panel_funcs otm8009a_drm_funcs = { .disable = otm8009a_disable, .unprepare = otm8009a_unprepare, .prepare = otm8009a_prepare, - .enable = otm8009a_enable, .get_modes = otm8009a_get_modes, };