From patchwork Tue Oct 17 21:13:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10012873 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B12E7600CC for ; Tue, 17 Oct 2017 21:14:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1F1228A3C for ; Tue, 17 Oct 2017 21:14:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 94AF728A40; Tue, 17 Oct 2017 21:14:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4532828A3C for ; Tue, 17 Oct 2017 21:14:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 46F546E780; Tue, 17 Oct 2017 21:14:04 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BF126E77E for ; Tue, 17 Oct 2017 21:14:02 +0000 (UTC) Received: by mail-it0-x22c.google.com with SMTP id r127so3996056itb.5 for ; Tue, 17 Oct 2017 14:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=u0iOWVaIh6mlDTv2E4TZybKoUrMcZkerMEh0fD1qYrY=; b=dOE5bmkHDUGGezRQKUdkiQs8ow5omO//reStqiTtTGQvP6sLKvvo70ejxWwqbB+Fl9 NvjdLLdFgRxUxmuU+lyjC/FCcxIqAqxMfLi5tWLyNGKRZ4yUrjroNVJVEh1ljmi6hafs pQtP7QokClZJOlz4QuDCt3TkL03SNV77JmZbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=u0iOWVaIh6mlDTv2E4TZybKoUrMcZkerMEh0fD1qYrY=; b=PpYnWLQ/594o9P0UBEhb5nptwSQ9C40nMiMBcm+KvSso6vRMMOTjRK28uhx9t1d34o gaBr3780qA/TVN0tysdpgHjwgClHTBfgLwDo+gC6UK99293ace+Jknm4tieyZj5yEYBc yjg8aRNMn7AWGF/DMs1J77IPh2HOAuWLwuBinrGM2Yt+RkIYiWdORzMzJsEJpS0YHV4f t4Oglc7KZcJ75eHI7TbBlrSCE22fnq95rOQh1h8DkZfDAD4icl8DWaBkQToItp9H1Wv9 +ZEtw6H+G31u3EqTyiWNdG5waLOh62QfvcxS/KU89M+fkO0cB7+4po0kzfMNvfTAGq+T vJUg== X-Gm-Message-State: AMCzsaWUfD7zxPx+hbqjRUqp1IFkf7P5WaDhRpgLDw5tFEOJYyflCzNa Jmtb7sWKiOIg4QdFMkp2XvFHjIO3wdM= X-Google-Smtp-Source: ABhQp+QSUG8kQIc76iXM5nYOveuYf+7QaTM/U6aaNQsHIHUgkKUFeI17ecKiXa6ujoVb3F7CKr/e0w== X-Received: by 10.36.34.206 with SMTP id o197mr7770562ito.51.1508274841675; Tue, 17 Oct 2017 14:14:01 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:0:f685:3152:9ba1:429a]) by smtp.gmail.com with ESMTPSA id f2sm5220677ioj.73.2017.10.17.14.14.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Oct 2017 14:14:01 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH v3 05/12] drm/panel: lt070me05000: Remove enabled/prepared state Date: Tue, 17 Oct 2017 17:13:08 -0400 Message-Id: <20171017211321.7992-6-seanpaul@chromium.org> X-Mailer: git-send-email 2.15.0.rc1.287.g2b38de12cc-goog In-Reply-To: <20171017211321.7992-1-seanpaul@chromium.org> References: <20171017211321.7992-1-seanpaul@chromium.org> Cc: thierry.reding@gmail.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP They're not necessary for atomic drivers, and drm_panel will WARN if the calls are unbalanced. Signed-off-by: Sean Paul --- No changes since v1 drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c index 5b2340ef74ed..2f2455650258 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -50,9 +50,6 @@ struct jdi_panel { struct gpio_desc *dcdc_en_gpio; struct backlight_device *backlight; - bool prepared; - bool enabled; - const struct drm_display_mode *mode; }; @@ -189,14 +186,9 @@ static int jdi_panel_disable(struct drm_panel *panel) { struct jdi_panel *jdi = to_jdi_panel(panel); - if (!jdi->enabled) - return 0; - jdi->backlight->props.power = FB_BLANK_POWERDOWN; backlight_update_status(jdi->backlight); - jdi->enabled = false; - return 0; } @@ -206,9 +198,6 @@ static int jdi_panel_unprepare(struct drm_panel *panel) struct device *dev = &jdi->dsi->dev; int ret; - if (!jdi->prepared) - return 0; - jdi_panel_off(jdi); ret = regulator_bulk_disable(ARRAY_SIZE(jdi->supplies), jdi->supplies); @@ -221,8 +210,6 @@ static int jdi_panel_unprepare(struct drm_panel *panel) gpiod_set_value(jdi->dcdc_en_gpio, 0); - jdi->prepared = false; - return 0; } @@ -232,9 +219,6 @@ static int jdi_panel_prepare(struct drm_panel *panel) struct device *dev = &jdi->dsi->dev; int ret; - if (jdi->prepared) - return 0; - ret = regulator_bulk_enable(ARRAY_SIZE(jdi->supplies), jdi->supplies); if (ret < 0) { dev_err(dev, "regulator enable failed, %d\n", ret); @@ -264,8 +248,6 @@ static int jdi_panel_prepare(struct drm_panel *panel) goto poweroff; } - jdi->prepared = true; - return 0; poweroff: @@ -286,14 +268,9 @@ static int jdi_panel_enable(struct drm_panel *panel) { struct jdi_panel *jdi = to_jdi_panel(panel); - if (jdi->enabled) - return 0; - jdi->backlight->props.power = FB_BLANK_UNBLANK; backlight_update_status(jdi->backlight); - jdi->enabled = true; - return 0; }