From patchwork Mon Nov 27 17:21:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alex Deucher X-Patchwork-Id: 10077667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BFE9B602BC for ; Mon, 27 Nov 2017 17:21:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A195028A35 for ; Mon, 27 Nov 2017 17:21:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 965EB28CA3; Mon, 27 Nov 2017 17:21:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_WEB, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1458628A35 for ; Mon, 27 Nov 2017 17:21:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 43CF089B3B; Mon, 27 Nov 2017 17:21:26 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id AEFA66E021 for ; Mon, 27 Nov 2017 17:21:24 +0000 (UTC) Received: by mail-it0-x243.google.com with SMTP id m191so22245068itg.2 for ; Mon, 27 Nov 2017 09:21:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UOhKY2Tu50Y8ZK8bwKacGoEr2dYNoBCrHukAB2xDwE0=; b=IqIdBbbfuyUjVffvh6kCIcZ25PPiqIwWYapW0u3MDe3LaSx0pGr1ZYPuP6ExcyeQsu T9y3u50R1fYZs7gTnuif1KHMz0t9GkoHrVAK0bDwbYFSvIvfAqu+RONQW4PyXZASvRch XJ8uDaRUxDKXoQ6N58+MEYDy3Cpy4OcC1tGED8biBZkGeqjxEnA5n2qGglgob61+sLTr YiAkdaWhWehoCZLh8drI9/yVgAwQm6TvWRahw4yAyhQlA3U514aAHSWT3FHZ9w3AGuve 0YIGcgZ97gwqCukYLvcFWxibSulSERIvWu6d0PA+9QvsFlsXIWMjcME6s0Vl/V27aRXB g5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UOhKY2Tu50Y8ZK8bwKacGoEr2dYNoBCrHukAB2xDwE0=; b=rGi3tGduA9Kx90qQ/TpCGFxCobxyqDDpYp4HM2VWOaduwllc9fQP6kkGiTarjZyj5x s0ERCvgHUqxq+pNAXDg0NxIK8+4qhNyh2rSd+bNV2xSybqgfHrYCqfG9Jt9bfSrE+tqY Af3ko3jRdSmXJDcH4OLP85kkMMjcTP/n1e7VASbEzUfVaTn1AlHxUcWn9oC/7Tvj48kf Tj4AZ+3psrTKejEVckHu9Bk9mwW9j09+aKGBvGUXjrjAIy+KAH/qu5MFFpKqtruINrZx 54tpKs4ssPo1mj+D451ryNJFUGjJ2fTQqJx1llH/reMtUcL3F96vboeiYWsmYhuJdb00 bgIQ== X-Gm-Message-State: AJaThX4mDhxz1Qs3WA0IJTLUh4hrRWYAkzFvTIuJKpsVRZ2d6mNq/Unh L9kCzucJzDyeLpqd41vim/u6GQ== X-Google-Smtp-Source: AGs4zMaiYE3bJQ/ln2efaa9ggpXoik3l4DH3XrLRZV+LKFq91tU/G+QPT4eyIBnb9W2UK8tA2iqcTw== X-Received: by 10.36.77.143 with SMTP id l137mr29474453itb.50.1511803283790; Mon, 27 Nov 2017 09:21:23 -0800 (PST) Received: from localhost.localdomain ([165.204.55.251]) by smtp.gmail.com with ESMTPSA id w186sm7544375itd.12.2017.11.27.09.21.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Nov 2017 09:21:23 -0800 (PST) From: Alex Deucher X-Google-Original-From: Alex Deucher To: dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, helgaas@kernel.org Subject: [PATCH] PCI: use dev_info rather than dev_err for rom validation Date: Mon, 27 Nov 2017 12:21:10 -0500 Message-Id: <20171127172110.16699-1-alexander.deucher@amd.com> X-Mailer: git-send-email 2.13.6 Cc: Alex Deucher X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP On AMD GPUs, we use several mechanisms to fetch the vbios rom depending on the platform. We try to read the rom back via the rom BAR and fall back to other methods in some cases. This leads to spurious error messages from the pci rom code which are harmless in our case. This leads to bugs being files, etc. Change these to dev_info rather than dev_err to avoid that. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/pci/rom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c index b6edb187d160..7ab7c6bb17c6 100644 --- a/drivers/pci/rom.c +++ b/drivers/pci/rom.c @@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size) void __iomem *pds; /* Standard PCI ROMs start out with these bytes 55 AA */ if (readw(image) != 0xAA55) { - dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n", + dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n", readw(image)); break; } /* get the PCI data structure and check its "PCIR" signature */ pds = image + readw(image + 24); if (readl(pds) != 0x52494350) { - dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n", + dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n", readl(pds)); break; }