diff mbox

[v4,2/3] autotools: Include meson.build files in tarball

Message ID 20180105140252.mltvbczldsj5nbvz@imgtec.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Engestrom Jan. 5, 2018, 2:02 p.m. UTC
On Thursday, 2018-01-04 10:28:41 -0800, Dylan Baker wrote:
> Signed-off-by: Dylan Baker <dylan.c.baker@intel.com>

Do we really want to use autotools' `dist` to package libdrm once meson
has landed?
I would've though we would switch to meson and deprecate autotools right
away.

On that note, have we talked about how long we'll keep autotools around?
Since libdrm doesn't have a stable release schedule like mesa, it might
be best to count it in months. 3 months? 6 months? A year?

Once that's decided, I think something like this should also be committed
in this series:

----8<----
---->8----

> ---
>  Makefile.am | 30 +++++++++++++++++++++++++++++-
>  1 file changed, 29 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 7b86214..66f70ca 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -135,7 +135,35 @@ if HAVE_VMWGFX
>  klibdrminclude_HEADERS += $(LIBDRM_INCLUDE_VMWGFX_H_FILES)
>  endif
>  
> -EXTRA_DIST = include/drm/README
> +EXTRA_DIST = \
> +	include/drm/README \
> +	amdgpu/meson.build \
> +	etnaviv/meson.build \
> +	exynos/meson.build \
> +	freedreno/meson.build \
> +	intel/meson.build \
> +	libkms/meson.build \
> +	man/meson.build \
> +	nouveau/meson.build \
> +	omap/meson.build \
> +	radeon/meson.build \
> +	tests/amdgpu/meson.build \
> +	tests/etnaviv/meson.build \
> +	tests/exynos/meson.build \
> +	tests/kms/meson.build \
> +	tests/kmstest/meson.build \
> +	tests/modeprint/meson.build \
> +	tests/nouveau/meson.build \
> +	tests/proptest/meson.build \
> +	tests/radeon/meson.build \
> +	tests/tegra/meson.build \
> +	tests/util/meson.build \
> +	tests/vbltest/meson.build \
> +	tests/meson.build \
> +	vc4/meson.build \
> +	data/meson.build \
> +	meson.build \
> +	meson_options.txt
>  
>  copy-headers :
>  	cp -r $(kernel_source)/include/uapi/drm/*.h $(top_srcdir)/include/drm/
> -- 
> git-series 0.9.1

Comments

Dylan Baker Jan. 5, 2018, 6:53 p.m. UTC | #1
Quoting Eric Engestrom (2018-01-05 06:02:52)
> On Thursday, 2018-01-04 10:28:41 -0800, Dylan Baker wrote:
> > Signed-off-by: Dylan Baker <dylan.c.baker@intel.com>
> 
> Do we really want to use autotools' `dist` to package libdrm once meson
> has landed?
> I would've though we would switch to meson and deprecate autotools right
> away.

I think we should maintain the autotools build at least for a couple of
releases. It gives distros a little bit of time to iron out any problems they
have in their automation.

> 
> On that note, have we talked about how long we'll keep autotools around?
> Since libdrm doesn't have a stable release schedule like mesa, it might
> be best to count it in months. 3 months? 6 months? A year?

I think 3 months would probably be fine, but I'm okay with whatever people
decide is appropriate.

> 
> Once that's decided, I think something like this should also be committed
> in this series:
> 
> ----8<----
> diff --git a/configure.ac b/configure.ac
> index 35378b3384290f8e1e26..38660e13995988f65c2c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -587,3 +587,9 @@ echo "  Tegra API      $TEGRA"
>  echo "  VC4 API        $VC4"
>  echo "  Etnaviv API    $ETNAVIV"
>  echo ""
> +
> +echo "libdrm's autotools build is DEPRECATED"
> +echo ""
> +echo "Please read the instructions in the README to start using Meson"
> +echo "The autotools build system will be removed on the next release after 2018-XX-XX"
> +echo ""
> ---->8----
> 
> > ---
> >  Makefile.am | 30 +++++++++++++++++++++++++++++-
> >  1 file changed, 29 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 7b86214..66f70ca 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -135,7 +135,35 @@ if HAVE_VMWGFX
> >  klibdrminclude_HEADERS += $(LIBDRM_INCLUDE_VMWGFX_H_FILES)
> >  endif
> >  
> > -EXTRA_DIST = include/drm/README
> > +EXTRA_DIST = \
> > +     include/drm/README \
> > +     amdgpu/meson.build \
> > +     etnaviv/meson.build \
> > +     exynos/meson.build \
> > +     freedreno/meson.build \
> > +     intel/meson.build \
> > +     libkms/meson.build \
> > +     man/meson.build \
> > +     nouveau/meson.build \
> > +     omap/meson.build \
> > +     radeon/meson.build \
> > +     tests/amdgpu/meson.build \
> > +     tests/etnaviv/meson.build \
> > +     tests/exynos/meson.build \
> > +     tests/kms/meson.build \
> > +     tests/kmstest/meson.build \
> > +     tests/modeprint/meson.build \
> > +     tests/nouveau/meson.build \
> > +     tests/proptest/meson.build \
> > +     tests/radeon/meson.build \
> > +     tests/tegra/meson.build \
> > +     tests/util/meson.build \
> > +     tests/vbltest/meson.build \
> > +     tests/meson.build \
> > +     vc4/meson.build \
> > +     data/meson.build \
> > +     meson.build \
> > +     meson_options.txt
> >  
> >  copy-headers :
> >       cp -r $(kernel_source)/include/uapi/drm/*.h $(top_srcdir)/include/drm/
> > -- 
> > git-series 0.9.1
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index 35378b3384290f8e1e26..38660e13995988f65c2c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -587,3 +587,9 @@  echo "  Tegra API      $TEGRA"
 echo "  VC4 API        $VC4"
 echo "  Etnaviv API    $ETNAVIV"
 echo ""
+
+echo "libdrm's autotools build is DEPRECATED"
+echo ""
+echo "Please read the instructions in the README to start using Meson"
+echo "The autotools build system will be removed on the next release after 2018-XX-XX"
+echo ""