Message ID | 20180109020323.11852-3-net147@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <dri-devel-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5A2FE60223 for <patchwork-dri-devel@patchwork.kernel.org>; Tue, 9 Jan 2018 08:36:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A4B72879B for <patchwork-dri-devel@patchwork.kernel.org>; Tue, 9 Jan 2018 08:36:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3DC932889D; Tue, 9 Jan 2018 08:36:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D1D6F2879B for <patchwork-dri-devel@patchwork.kernel.org>; Tue, 9 Jan 2018 08:36:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B07C6E6C2; Tue, 9 Jan 2018 08:35:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 441746E06A for <dri-devel@lists.freedesktop.org>; Tue, 9 Jan 2018 02:03:39 +0000 (UTC) Received: by mail-pf0-x243.google.com with SMTP id 23so4751200pfp.3 for <dri-devel@lists.freedesktop.org>; Mon, 08 Jan 2018 18:03:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sVy0957OwxE+dTN9yzaeiHRI15CxCH6h2dNqmLSD6r0=; b=pWIZ63OTnFT9+B72B218FBcF7rGjq7Noay6YCUK+Z6cqYG9V1LWE6vEcQEG3lsigKL 2IKl22I3q912NEIulhDOlOYimELu7PTQZ4264GjPPY0QOEHL4sHNSwRAWT/tf8Y90wE7 Im8mTiJ3flrGfnef9jdMeVlrE3bq32narnkAoYNCfs5ixovHWsyTET2ExIrqQRGHiwdC rI7Jp1opMJP0Dn1GYrb3iszIS0/Vp4vJuaLa42Oh0S/fj2yosMaUbLRtMUpF2wSLZDJ0 UGvciW0FVgYYe1uksFL8BTlpAVoKRdu+2I1lgxBKwEprV1PyMSoSc8EyZ8zNOqlv8quA tvQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sVy0957OwxE+dTN9yzaeiHRI15CxCH6h2dNqmLSD6r0=; b=pWapui8T2Trw3wvC+MrG5cNQpZWW5/PLq6DOTzb9iordwmr69F3F6rcF3q3vEdKGF5 4kdF2GQIUVLmmluIv7aZlXcU7xnKN3V4q3kq8Ftz/+Qp74S97WBVgwyaQ8VFe2mwv70n iNkvc1Rlf7gkTBJ2DksnpZceZeAtBI4821m52oEUzkcyN2qigtMKY90ypULtaJWZbxAY Lw6xQdg4dpwvMrpYxyAVnVSQmtvRbs5DfzW8dXz2PCz7YGbR2h8W2woGHhJNe6mlzPp1 BIK7wWlgnR+sU1JznxomONVKfdYrTnIKs9gsNqfOyT5SzRmAaHXX9HPYsN6drJPwZVyO HJaQ== X-Gm-Message-State: AKwxytf4pE9nJjGTnHufNOmUYFi1reflgM0UpAYtXkdtB51IYR5btxrz 7K4ChzFHrFPTRYrZFY/kCsDE+BYH X-Google-Smtp-Source: ACJfBovAYrY8tQ/0/eFs/H0Kxd/BR0BdZq78cYhzCBuR30/yd6fHy+pTCl0+EujAFXfwOEvuLRjvGA== X-Received: by 10.98.224.205 with SMTP id d74mr182261pfm.56.1515463418776; Mon, 08 Jan 2018 18:03:38 -0800 (PST) Received: from 60-242-179-244.static.tpgi.com.au (60-242-179-244.static.tpgi.com.au. [60.242.179.244]) by smtp.gmail.com with ESMTPSA id y1sm23768366pgc.52.2018.01.08.18.03.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jan 2018 18:03:38 -0800 (PST) From: Jonathan Liu <net147@gmail.com> To: Maxime Ripard <maxime.ripard@free-electrons.com>, David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org> Subject: [PATCH v3 2/3] drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate Date: Tue, 9 Jan 2018 13:03:22 +1100 Message-Id: <20180109020323.11852-3-net147@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180109020323.11852-1-net147@gmail.com> References: <20180109020323.11852-1-net147@gmail.com> X-Mailman-Approved-At: Tue, 09 Jan 2018 08:35:43 +0000 Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Jonathan Liu <net147@gmail.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development <dri-devel.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/dri-devel> List-Post: <mailto:dri-devel@lists.freedesktop.org> List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index 4d235e5ea31c..88eeeaf34638 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c @@ -105,7 +105,7 @@ static int sun4i_tmds_determine_rate(struct clk_hw *hw, if (!best_parent || abs(rate - rounded / i) < abs(rate - best_parent / best_div)) { best_parent = rounded; - best_div = i; + best_div = j; } } }
best_div is set to i which corresponds to rate halving when it should be set to j which corresponds to the divider. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu <net147@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)