| Message ID | 20180208100906.30170-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Chris Wilson (2018-02-08 10:09:06) > sync_dump() is an unused, unexported, function that adds 64k to the > kernel image and doesn't even provide locking around the global array it > uses. > > add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-65734 (-65734) > Function old new delta > sync_dump 198 - -198 > sync_dump_buf 65536 - -65536 > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Gustavo Padovan <gustavo@padovan.org> I see the patch to remove the stubs was applied, but we still have this 64k unused buffer... -Chris > --- > drivers/dma-buf/sync_debug.c | 26 -------------------------- > drivers/dma-buf/sync_debug.h | 2 -- > 2 files changed, 28 deletions(-) > > diff --git a/drivers/dma-buf/sync_debug.c b/drivers/dma-buf/sync_debug.c > index c4c8ecb24aa9..d1caa9f060a1 100644 > --- a/drivers/dma-buf/sync_debug.c > +++ b/drivers/dma-buf/sync_debug.c > @@ -207,29 +207,3 @@ static __init int sync_debugfs_init(void) > return 0; > } > late_initcall(sync_debugfs_init); > - > -#define DUMP_CHUNK 256 > -static char sync_dump_buf[64 * 1024]; > -void sync_dump(void) > -{ > - struct seq_file s = { > - .buf = sync_dump_buf, > - .size = sizeof(sync_dump_buf) - 1, > - }; > - int i; > - > - sync_debugfs_show(&s, NULL); > - > - for (i = 0; i < s.count; i += DUMP_CHUNK) { > - if ((s.count - i) > DUMP_CHUNK) { > - char c = s.buf[i + DUMP_CHUNK]; > - > - s.buf[i + DUMP_CHUNK] = 0; > - pr_cont("%s", s.buf + i); > - s.buf[i + DUMP_CHUNK] = c; > - } else { > - s.buf[s.count] = 0; > - pr_cont("%s", s.buf + i); > - } > - } > -} > diff --git a/drivers/dma-buf/sync_debug.h b/drivers/dma-buf/sync_debug.h > index d615a89f774c..1fd4d9ab3c4a 100644 > --- a/drivers/dma-buf/sync_debug.h > +++ b/drivers/dma-buf/sync_debug.h > @@ -70,14 +70,12 @@ void sync_timeline_debug_add(struct sync_timeline *obj); > void sync_timeline_debug_remove(struct sync_timeline *obj); > void sync_file_debug_add(struct sync_file *fence); > void sync_file_debug_remove(struct sync_file *fence); > -void sync_dump(void); > > #else > # define sync_timeline_debug_add(obj) > # define sync_timeline_debug_remove(obj) > # define sync_file_debug_add(fence) > # define sync_file_debug_remove(fence) > -# define sync_dump() > #endif > > #endif /* _LINUX_SYNC_H */ > -- > 2.16.1 >
diff --git a/drivers/dma-buf/sync_debug.c b/drivers/dma-buf/sync_debug.c index c4c8ecb24aa9..d1caa9f060a1 100644 --- a/drivers/dma-buf/sync_debug.c +++ b/drivers/dma-buf/sync_debug.c @@ -207,29 +207,3 @@ static __init int sync_debugfs_init(void) return 0; } late_initcall(sync_debugfs_init); - -#define DUMP_CHUNK 256 -static char sync_dump_buf[64 * 1024]; -void sync_dump(void) -{ - struct seq_file s = { - .buf = sync_dump_buf, - .size = sizeof(sync_dump_buf) - 1, - }; - int i; - - sync_debugfs_show(&s, NULL); - - for (i = 0; i < s.count; i += DUMP_CHUNK) { - if ((s.count - i) > DUMP_CHUNK) { - char c = s.buf[i + DUMP_CHUNK]; - - s.buf[i + DUMP_CHUNK] = 0; - pr_cont("%s", s.buf + i); - s.buf[i + DUMP_CHUNK] = c; - } else { - s.buf[s.count] = 0; - pr_cont("%s", s.buf + i); - } - } -} diff --git a/drivers/dma-buf/sync_debug.h b/drivers/dma-buf/sync_debug.h index d615a89f774c..1fd4d9ab3c4a 100644 --- a/drivers/dma-buf/sync_debug.h +++ b/drivers/dma-buf/sync_debug.h @@ -70,14 +70,12 @@ void sync_timeline_debug_add(struct sync_timeline *obj); void sync_timeline_debug_remove(struct sync_timeline *obj); void sync_file_debug_add(struct sync_file *fence); void sync_file_debug_remove(struct sync_file *fence); -void sync_dump(void); #else # define sync_timeline_debug_add(obj) # define sync_timeline_debug_remove(obj) # define sync_file_debug_add(fence) # define sync_file_debug_remove(fence) -# define sync_dump() #endif #endif /* _LINUX_SYNC_H */
sync_dump() is an unused, unexported, function that adds 64k to the kernel image and doesn't even provide locking around the global array it uses. add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-65734 (-65734) Function old new delta sync_dump 198 - -198 sync_dump_buf 65536 - -65536 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Gustavo Padovan <gustavo@padovan.org> --- drivers/dma-buf/sync_debug.c | 26 -------------------------- drivers/dma-buf/sync_debug.h | 2 -- 2 files changed, 28 deletions(-)