From patchwork Sun Feb 11 10:38:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10211281 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0D73260236 for ; Sun, 11 Feb 2018 10:40:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EEDAF28A3F for ; Sun, 11 Feb 2018 10:40:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E257028BEE; Sun, 11 Feb 2018 10:40:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 666B728A3F for ; Sun, 11 Feb 2018 10:40:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ABB0F6E014; Sun, 11 Feb 2018 10:40:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80D0C6E014 for ; Sun, 11 Feb 2018 10:40:47 +0000 (UTC) Received: by mail-lf0-x243.google.com with SMTP id t79so16820989lfe.3 for ; Sun, 11 Feb 2018 02:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=GBUVKUpopqy97yabaUc8M84EnzgfnGDje/fuuOfjVXg=; b=UMANtwnD0Qr3/ViCYZtvXjop+6KHiO5CpLqTYyJ1K13Tm5HwgePRDlI45CvfcNRKEc Gm3cvr5K5rRIj0VCI/zJ61KEcVKX1mDrFI67DIJVPPylbywRd28ImCDZEuEq90AR6ibq B/46PcP86gdVeiWD6xCBIQH6OooNAtN95qoZ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GBUVKUpopqy97yabaUc8M84EnzgfnGDje/fuuOfjVXg=; b=EoDvUuKgYYA232Na8mELGT358A1lgZf/irFgtrhaVexdk4EotU6k2AZ6vjezgsFssP eVBWpSjnpg/FxULLBumrbeirZSpEwEr754rY0C9phztYSGwL7UkVN6vq+ZOQy/QNw0UJ P58Zs5p9yKVM6mrS5aXnvbZ3NsAFwbI5Wu9c6e2yKCoRsMb5nM1WCCfvit8wLPyhHtf/ JbJhGrT6I3zhTLVPo3Y9rCi3830ynP/QCYjdpm2Sips/2QeYwyDfbGOjKnTKH6KHPw+6 UhwdYRQCo5gyc20ZuebIrIYHFitCgJLe0Uv5mBVNxJCic7/2ENM5OhC5KwVY0d9z7els XvUA== X-Gm-Message-State: APf1xPCsamXDchDbWDyE9ZQBgGhTRXHdtgGj3fTWQZhCpwwYH671KP6Q BK3tjKW1BJZfD+tM8ccjp0EDqg== X-Google-Smtp-Source: AH8x225Z/NhfTEGhG5f7yHKrSodTwjK99NuSSOcQ9niq7vC9EajbbmrOHb89W3JauKgI5PYvZgOMIQ== X-Received: by 10.25.159.200 with SMTP id i191mr5047412lfe.84.1518345645806; Sun, 11 Feb 2018 02:40:45 -0800 (PST) Received: from localhost.localdomain (c-cb7471d5.014-348-6c756e10.cust.bredbandsbolaget.se. [213.113.116.203]) by smtp.gmail.com with ESMTPSA id b184sm1222623lfg.16.2018.02.11.02.40.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Feb 2018 02:40:44 -0800 (PST) From: Linus Walleij To: Thierry Reding , dri-devel@lists.freedesktop.org Subject: [PATCH v2] drm/panel: Fix ARM Versatile panel clocks Date: Sun, 11 Feb 2018 11:38:40 +0100 Message-Id: <20180211103840.18764-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.14.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP These clocks are in kHz not in Hz, oops. Fix it so my new bandwidth calculations patch starts working with these panels. Cc: Eric Anholt Signed-off-by: Linus Walleij Reviewed-by: Eric Anholt --- ChangeLog v1->v2: - The Epson clock was still wrong, off by one order of magnitude. It is now fixed. The only source of the actual frequency to use is the old fbdev driver, as there is no datasheet for this Epson panel that I can find, and it is set to 62500 kHz. --- drivers/gpu/drm/panel/panel-arm-versatile.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-arm-versatile.c b/drivers/gpu/drm/panel/panel-arm-versatile.c index 3930b4925b15..b428c4678106 100644 --- a/drivers/gpu/drm/panel/panel-arm-versatile.c +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c @@ -132,7 +132,7 @@ static const struct versatile_panel_type versatile_panels[] = { .width_mm = 79, .height_mm = 54, .mode = { - .clock = 10000000, + .clock = 10000, .hdisplay = 320, .hsync_start = 320 + 6, .hsync_end = 320 + 6 + 6, @@ -156,7 +156,7 @@ static const struct versatile_panel_type versatile_panels[] = { .width_mm = 171, .height_mm = 130, .mode = { - .clock = 25000000, + .clock = 25000, .hdisplay = 640, .hsync_start = 640 + 24, .hsync_end = 640 + 24 + 96, @@ -179,7 +179,7 @@ static const struct versatile_panel_type versatile_panels[] = { .width_mm = 34, .height_mm = 45, .mode = { - .clock = 625000000, + .clock = 62500, .hdisplay = 176, .hsync_start = 176 + 2, .hsync_end = 176 + 2 + 3, @@ -203,7 +203,7 @@ static const struct versatile_panel_type versatile_panels[] = { .width_mm = 37, .height_mm = 50, .mode = { - .clock = 5400000, + .clock = 5400, .hdisplay = 240, .hsync_start = 240 + 10, .hsync_end = 240 + 10 + 10,