diff mbox

staging: vboxvideo: remove ttm_pool_* wrappers

Message ID 20180222135427.66861-1-christian.koenig@amd.com (mailing list archive)
State New, archived
Headers show

Commit Message

Christian König Feb. 22, 2018, 1:54 p.m. UTC
TTM calls the default implementation now.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/staging/vboxvideo/vbox_ttm.c | 13 -------------
 1 file changed, 13 deletions(-)

Comments

Daniel Vetter Feb. 22, 2018, 4:03 p.m. UTC | #1
On Thu, Feb 22, 2018 at 02:54:27PM +0100, Christian König wrote:
> TTM calls the default implementation now.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Is there some sync requirement with drm trees? If so probably simplest if
you stuff this one into drm-misc.
-Daniel


> ---
>  drivers/staging/vboxvideo/vbox_ttm.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c
> index 2ea31589d773..c4b7a6b9abd5 100644
> --- a/drivers/staging/vboxvideo/vbox_ttm.c
> +++ b/drivers/staging/vboxvideo/vbox_ttm.c
> @@ -213,21 +213,8 @@ static struct ttm_tt *vbox_ttm_tt_create(struct ttm_bo_device *bdev,
>  	return tt;
>  }
>  
> -static int vbox_ttm_tt_populate(struct ttm_tt *ttm,
> -				struct ttm_operation_ctx *ctx)
> -{
> -	return ttm_pool_populate(ttm, ctx);
> -}
> -
> -static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)
> -{
> -	ttm_pool_unpopulate(ttm);
> -}
> -
>  static struct ttm_bo_driver vbox_bo_driver = {
>  	.ttm_tt_create = vbox_ttm_tt_create,
> -	.ttm_tt_populate = vbox_ttm_tt_populate,
> -	.ttm_tt_unpopulate = vbox_ttm_tt_unpopulate,
>  	.init_mem_type = vbox_bo_init_mem_type,
>  	.eviction_valuable = ttm_bo_eviction_valuable,
>  	.evict_flags = vbox_bo_evict_flags,
> -- 
> 2.14.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Christian König Feb. 23, 2018, 11:56 a.m. UTC | #2
Am 22.02.2018 um 17:03 schrieb Daniel Vetter:
> On Thu, Feb 22, 2018 at 02:54:27PM +0100, Christian König wrote:
>> TTM calls the default implementation now.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Is there some sync requirement with drm trees?

Yeah, that depends on some TTM changes.

> If so probably simplest if you stuff this one into drm-misc.

I think I rather push that with the TTM changes through 
amd-staging-drm-next.

Christian.

> -Daniel
>
>
>> ---
>>   drivers/staging/vboxvideo/vbox_ttm.c | 13 -------------
>>   1 file changed, 13 deletions(-)
>>
>> diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c
>> index 2ea31589d773..c4b7a6b9abd5 100644
>> --- a/drivers/staging/vboxvideo/vbox_ttm.c
>> +++ b/drivers/staging/vboxvideo/vbox_ttm.c
>> @@ -213,21 +213,8 @@ static struct ttm_tt *vbox_ttm_tt_create(struct ttm_bo_device *bdev,
>>   	return tt;
>>   }
>>   
>> -static int vbox_ttm_tt_populate(struct ttm_tt *ttm,
>> -				struct ttm_operation_ctx *ctx)
>> -{
>> -	return ttm_pool_populate(ttm, ctx);
>> -}
>> -
>> -static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)
>> -{
>> -	ttm_pool_unpopulate(ttm);
>> -}
>> -
>>   static struct ttm_bo_driver vbox_bo_driver = {
>>   	.ttm_tt_create = vbox_ttm_tt_create,
>> -	.ttm_tt_populate = vbox_ttm_tt_populate,
>> -	.ttm_tt_unpopulate = vbox_ttm_tt_unpopulate,
>>   	.init_mem_type = vbox_bo_init_mem_type,
>>   	.eviction_valuable = ttm_bo_eviction_valuable,
>>   	.evict_flags = vbox_bo_evict_flags,
>> -- 
>> 2.14.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c
index 2ea31589d773..c4b7a6b9abd5 100644
--- a/drivers/staging/vboxvideo/vbox_ttm.c
+++ b/drivers/staging/vboxvideo/vbox_ttm.c
@@ -213,21 +213,8 @@  static struct ttm_tt *vbox_ttm_tt_create(struct ttm_bo_device *bdev,
 	return tt;
 }
 
-static int vbox_ttm_tt_populate(struct ttm_tt *ttm,
-				struct ttm_operation_ctx *ctx)
-{
-	return ttm_pool_populate(ttm, ctx);
-}
-
-static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)
-{
-	ttm_pool_unpopulate(ttm);
-}
-
 static struct ttm_bo_driver vbox_bo_driver = {
 	.ttm_tt_create = vbox_ttm_tt_create,
-	.ttm_tt_populate = vbox_ttm_tt_populate,
-	.ttm_tt_unpopulate = vbox_ttm_tt_unpopulate,
 	.init_mem_type = vbox_bo_init_mem_type,
 	.eviction_valuable = ttm_bo_eviction_valuable,
 	.evict_flags = vbox_bo_evict_flags,