| Message ID | 20180328155340.2253343-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 28.03.2018 um 17:53 schrieb Arnd Bergmann: > Building amdkfd without MMU notifiers is broken: > > In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28: > drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type > > This adds the missing 'select MMU_NOTIFIER' line to make it build > cleanly all the time. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Christian König <christian.koenig@amd.com>, but I would wait on what Felix says to that. > --- > drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig > index ed2f06c9f346..5a26acb90e19 100644 > --- a/drivers/gpu/drm/amd/amdkfd/Kconfig > +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig > @@ -4,6 +4,7 @@ > > config HSA_AMD > tristate "HSA kernel driver for AMD GPU devices" > + select MMU_NOTIFIER > depends on DRM_AMDGPU && X86_64 > imply AMD_IOMMU_V2 > help
On 28 March 2018 at 18:04, Christian König <christian.koenig@amd.com> wrote: > Am 28.03.2018 um 17:53 schrieb Arnd Bergmann: >> >> Building amdkfd without MMU notifiers is broken: >> >> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28: >> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' >> has incomplete type >> >> This adds the missing 'select MMU_NOTIFIER' line to make it build >> cleanly all the time. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > Acked-by: Christian König <christian.koenig@amd.com>, but I would wait on > what Felix says to that. Tested-by: Anders Roxell <anders.roxell@linaro.org> Randy sent the same patch [1] and its still required. Cheers, Anders [1] https://patchwork.kernel.org/patch/10340885/ > > >> --- >> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig >> b/drivers/gpu/drm/amd/amdkfd/Kconfig >> index ed2f06c9f346..5a26acb90e19 100644 >> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig >> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig >> @@ -4,6 +4,7 @@ >> config HSA_AMD >> tristate "HSA kernel driver for AMD GPU devices" >> + select MMU_NOTIFIER >> depends on DRM_AMDGPU && X86_64 >> imply AMD_IOMMU_V2 >> help > >
On 2018-04-19 06:56 AM, Anders Roxell wrote: > On 28 March 2018 at 18:04, Christian König <christian.koenig@amd.com> wrote: >> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann: >>> Building amdkfd without MMU notifiers is broken: >>> >>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28: >>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' >>> has incomplete type >>> >>> This adds the missing 'select MMU_NOTIFIER' line to make it build >>> cleanly all the time. >>> >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> >> Acked-by: Christian König <christian.koenig@amd.com>, but I would wait on >> what Felix says to that. > Tested-by: Anders Roxell <anders.roxell@linaro.org> > > Randy sent the same patch [1] and its still required. > > Cheers, > Anders > [1] https://patchwork.kernel.org/patch/10340885/ Yes, looks good. I think this probably broke when we relaxed the dependency on iommuv2. Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> Regards, Felix > >> >>> --- >>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig >>> b/drivers/gpu/drm/amd/amdkfd/Kconfig >>> index ed2f06c9f346..5a26acb90e19 100644 >>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig >>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig >>> @@ -4,6 +4,7 @@ >>> config HSA_AMD >>> tristate "HSA kernel driver for AMD GPU devices" >>> + select MMU_NOTIFIER >>> depends on DRM_AMDGPU && X86_64 >>> imply AMD_IOMMU_V2 >>> help >>
Thanks, but I took Randy's patch as it was earlier in my email queue. Oded On Thu, Apr 19, 2018 at 8:47 PM, Felix Kuehling <felix.kuehling@amd.com> wrote: > On 2018-04-19 06:56 AM, Anders Roxell wrote: >> On 28 March 2018 at 18:04, Christian König <christian.koenig@amd.com> wrote: >>> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann: >>>> Building amdkfd without MMU notifiers is broken: >>>> >>>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28: >>>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' >>>> has incomplete type >>>> >>>> This adds the missing 'select MMU_NOTIFIER' line to make it build >>>> cleanly all the time. >>>> >>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >>> >>> Acked-by: Christian König <christian.koenig@amd.com>, but I would wait on >>> what Felix says to that. >> Tested-by: Anders Roxell <anders.roxell@linaro.org> >> >> Randy sent the same patch [1] and its still required. >> >> Cheers, >> Anders >> [1] https://patchwork.kernel.org/patch/10340885/ > Yes, looks good. I think this probably broke when we relaxed the > dependency on iommuv2. > > Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> > > Regards, > Felix > > >> >>> >>>> --- >>>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig >>>> b/drivers/gpu/drm/amd/amdkfd/Kconfig >>>> index ed2f06c9f346..5a26acb90e19 100644 >>>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig >>>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig >>>> @@ -4,6 +4,7 @@ >>>> config HSA_AMD >>>> tristate "HSA kernel driver for AMD GPU devices" >>>> + select MMU_NOTIFIER >>>> depends on DRM_AMDGPU && X86_64 >>>> imply AMD_IOMMU_V2 >>>> help >>> >
diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig index ed2f06c9f346..5a26acb90e19 100644 --- a/drivers/gpu/drm/amd/amdkfd/Kconfig +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig @@ -4,6 +4,7 @@ config HSA_AMD tristate "HSA kernel driver for AMD GPU devices" + select MMU_NOTIFIER depends on DRM_AMDGPU && X86_64 imply AMD_IOMMU_V2 help
Building amdkfd without MMU notifiers is broken: In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28: drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type This adds the missing 'select MMU_NOTIFIER' line to make it build cleanly all the time. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + 1 file changed, 1 insertion(+)