From patchwork Mon Apr 23 09:54:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 10358829 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D985C60225 for ; Tue, 24 Apr 2018 07:39:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD70028D1D for ; Tue, 24 Apr 2018 07:39:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C22E228D23; Tue, 24 Apr 2018 07:39:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CB9AE28D1D for ; Tue, 24 Apr 2018 07:39:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A21A06E397; Tue, 24 Apr 2018 07:36:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 699DF89CF7 for ; Mon, 23 Apr 2018 09:55:11 +0000 (UTC) Received: by mail-pg0-x241.google.com with SMTP id m21so5045641pgv.8 for ; Mon, 23 Apr 2018 02:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=89t6yfovgfVEKttzGSNTeT8XYJpZfZ/gWoAZJgCZWRo=; b=uymp8BfK92vjtsMQq3FaiESgrmNSrRS6OBjuaGwWtDoGgMAAI+C31bog4w3wlJW9Sp J+ZNCpAMZpwOHDMnb/+mBAmkytzjrYh0q6onzoX9P7+j/lt8mQsX0WJw/+qXvYfsfc5y n9JmtEG3B0fEjG1dmhgvMJwu2I6TBheVTkUa/uXj+xb21QlZrZBCvie5hCQwnJ1XA+Yb Y3nt4b7YNAMBkcbrDiUPytk5W+dVMIs1CgHtvgbVD68KhBzu07xnmYUQWGU8SmqOSrYj qe4ihxHy4ohPltW4t8PXOGWh1G/vv3OAJmotBveqgyv8CoBKsBzi3+kNC3fZzb4OYUT4 RlmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=89t6yfovgfVEKttzGSNTeT8XYJpZfZ/gWoAZJgCZWRo=; b=q2tXTsrWxoObZ0D+Fy2332NTFpj4fe5CCBho/0Zw6f5XCm/c0MstO9z68WbjQI2mVy 1bOCyAYkrCslkt9Wi8TDxUHWfwvHNgPiA3o+ulneO+1fRrT1s3aUCyLbZ9N2dlJvMTt1 fYUKABF8tfWPKeYRk+v2ej/jS/5xfkEExbh8aO7wAqoy6RTwEBm8qXLlK7cfZUuw9Jqs ltw7/yr8qVjEF/7Lv0btOf8xBWS+8oBHUfq51965Nu/HOiYIimkVtOMKY+JqCb7vyzHX rjBXzHjSXM4zMt1Td4I2wGzhdWr0ogfoo4aLg0XXM4Ye3z8nKpcFYX+L9SX/+D9Vw0Re GIsw== X-Gm-Message-State: ALQs6tDSHo0TRMVPi2RFERPlQzlceq4vf+JvhrMzH20CK5QHbYrsamKl Nl3tcwKsIYbF+r8HzVGbOtE= X-Google-Smtp-Source: AIpwx4/fArOBzuGUzjC76nPv8vmMC8Nufd+DNk22hMcnhkIAy6WT9BJqYhNHfx7FIInL7Kp3KpQGVw== X-Received: by 10.99.60.71 with SMTP id i7mr7165123pgn.254.1524477311185; Mon, 23 Apr 2018 02:55:11 -0700 (PDT) Received: from localhost.localdomain (ppp109-252-91-130.pppoe.spdop.ru. [109.252.91.130]) by smtp.gmail.com with ESMTPSA id u27sm23478852pfk.100.2018.04.23.02.55.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Apr 2018 02:55:10 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding Subject: [PATCH v1] gpu: host1x: Fix dma_free_wc() argument in the error path Date: Mon, 23 Apr 2018 12:54:56 +0300 Message-Id: <20180423095456.16697-1-digetx@gmail.com> X-Mailer: git-send-email 2.17.0 X-Mailman-Approved-At: Tue, 24 Apr 2018 07:34:39 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mikko Perttunen MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP If IOVA allocation or IOMMU mapping fails, dma_free_wc() is invoked with size=0 because of a typo, that triggers "kernel BUG at mm/vmalloc.c:124!". Signed-off-by: Dmitry Osipenko --- drivers/gpu/host1x/cdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/cdma.c b/drivers/gpu/host1x/cdma.c index 93df28228721..0724122afeac 100644 --- a/drivers/gpu/host1x/cdma.c +++ b/drivers/gpu/host1x/cdma.c @@ -127,7 +127,7 @@ static int host1x_pushbuffer_init(struct push_buffer *pb) iommu_free_iova: __free_iova(&host1x->iova, alloc); iommu_free_mem: - dma_free_wc(host1x->dev, pb->alloc_size, pb->mapped, pb->phys); + dma_free_wc(host1x->dev, size, pb->mapped, pb->phys); return err; }