| Message ID | 20180424153942.2526-1-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Apr 24, 2018 at 9:09 PM, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > The symbol 'rcar_du_of_init' is defined by the rcar_du_of module header, > but it is not included by the C implementation. > > Include the header to correctly define the function prototypes. > > Fixes the following warning: > > linux/drivers/gpu/drm/rcar-du/rcar_du_of.c:319:13: > warning: symbol 'rcar_du_of_init' was not declared. Should it be static? > CC drivers/gpu/drm/rcar-du/rcar_du_of.o > > Fixes: 81c0e3dd8292 ("drm: rcar-du: Fix legacy DT to create LVDS encoder nodes") > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Vaishali Thakkar <vthakkar@vaishalithakkar.in> > --- > drivers/gpu/drm/rcar-du/rcar_du_of.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of.c b/drivers/gpu/drm/rcar-du/rcar_du_of.c > index 68a0b82cb17e..afef69669bb4 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_of.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c > @@ -18,6 +18,7 @@ > > #include "rcar_du_crtc.h" > #include "rcar_du_drv.h" > +#include "rcar_du_of.h" > > /* ----------------------------------------------------------------------------- > * Generic Overlay Handling > -- > 2.17.0 >
Hi Kieran,
I love your patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Kieran-Bingham/drm-rcar-du-of-Include-header-to-define-prototypes/20180425-062015
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64
All errors (new ones prefixed by >>):
>> drivers/gpu//drm/rcar-du/rcar_du_of.c:320:13: error: redefinition of 'rcar_du_of_init'
void __init rcar_du_of_init(const struct of_device_id *of_ids)
^~~~~~~~~~~~~~~
In file included from drivers/gpu//drm/rcar-du/rcar_du_of.c:21:0:
drivers/gpu//drm/rcar-du/rcar_du_of.h:17:20: note: previous definition of 'rcar_du_of_init' was here
static inline void rcar_du_of_init(const struct of_device_id *of_ids) { }
^~~~~~~~~~~~~~~
vim +/rcar_du_of_init +320 drivers/gpu//drm/rcar-du/rcar_du_of.c
81c0e3dd Laurent Pinchart 2018-01-10 319
81c0e3dd Laurent Pinchart 2018-01-10 @320 void __init rcar_du_of_init(const struct of_device_id *of_ids)
:::::: The code at line 320 was first introduced by commit
:::::: 81c0e3dd82927064a2f56a31a0974a0d110fcdb0 drm: rcar-du: Fix legacy DT to create LVDS encoder nodes
:::::: TO: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
:::::: CC: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Kieran, Thank you for the patch. On Tuesday, 24 April 2018 18:39:42 EEST Kieran Bingham wrote: > The symbol 'rcar_du_of_init' is defined by the rcar_du_of module header, > but it is not included by the C implementation. > > Include the header to correctly define the function prototypes. > > Fixes the following warning: > > linux/drivers/gpu/drm/rcar-du/rcar_du_of.c:319:13: > warning: symbol 'rcar_du_of_init' was not declared. Should it be static? > CC drivers/gpu/drm/rcar-du/rcar_du_of.o > > Fixes: 81c0e3dd8292 ("drm: rcar-du: Fix legacy DT to create LVDS encoder > nodes") Signed-off-by: Kieran Bingham > <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> and applied to my tree. > --- > drivers/gpu/drm/rcar-du/rcar_du_of.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of.c > b/drivers/gpu/drm/rcar-du/rcar_du_of.c index 68a0b82cb17e..afef69669bb4 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_of.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c > @@ -18,6 +18,7 @@ > > #include "rcar_du_crtc.h" > #include "rcar_du_drv.h" > +#include "rcar_du_of.h" > > /* > --------------------------------------------------------------------------- > -- * Generic Overlay Handling
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of.c b/drivers/gpu/drm/rcar-du/rcar_du_of.c index 68a0b82cb17e..afef69669bb4 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_of.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c @@ -18,6 +18,7 @@ #include "rcar_du_crtc.h" #include "rcar_du_drv.h" +#include "rcar_du_of.h" /* ----------------------------------------------------------------------------- * Generic Overlay Handling
The symbol 'rcar_du_of_init' is defined by the rcar_du_of module header, but it is not included by the C implementation. Include the header to correctly define the function prototypes. Fixes the following warning: linux/drivers/gpu/drm/rcar-du/rcar_du_of.c:319:13: warning: symbol 'rcar_du_of_init' was not declared. Should it be static? CC drivers/gpu/drm/rcar-du/rcar_du_of.o Fixes: 81c0e3dd8292 ("drm: rcar-du: Fix legacy DT to create LVDS encoder nodes") Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_du_of.c | 1 + 1 file changed, 1 insertion(+)