From patchwork Thu Apr 26 08:24:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Hellstrom X-Patchwork-Id: 10364911 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 305EF601BE for ; Thu, 26 Apr 2018 08:24:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23C5329084 for ; Thu, 26 Apr 2018 08:24:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 18A3829087; Thu, 26 Apr 2018 08:24:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C754629084 for ; Thu, 26 Apr 2018 08:24:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B30B6E6A5; Thu, 26 Apr 2018 08:24:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0083.outbound.protection.outlook.com [104.47.34.83]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E4C76E6A5 for ; Thu, 26 Apr 2018 08:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onevmw.onmicrosoft.com; s=selector1-vmware-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WUQrEDFr4xfAE9/Je0a6jAI1HLV1L7zi5TxFss2B8mc=; b=mC6rLvp6H2CNIuMaN/c4s4J4Kv/xmuqaBkWTupV2l5YY7kH9+jfi7oMmbj4zFEKvXDV2+Ul2VIHD3cFBk5Z2jEsFvPB0/6tpSQzXQiKjx6A9YrPXf3G2tkHntXyb5sj39FOC05wuOLCYN73TACduAzxVRQ3Ah5Z0yLWkm+6MMgs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=thellstrom@vmware.com; Received: from localhost.localdomain.localdomain (155.4.205.56) by SN6PR05MB4591.namprd05.prod.outlook.com (2603:10b6:805:38::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.735.5; Thu, 26 Apr 2018 08:24:47 +0000 From: Thomas Hellstrom To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/2] drm/vmwgfx: Fix a buffer object leak Date: Thu, 26 Apr 2018 10:24:08 +0200 Message-Id: <20180426082408.2602-2-thellstrom@vmware.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180426082408.2602-1-thellstrom@vmware.com> References: <20180426082408.2602-1-thellstrom@vmware.com> MIME-Version: 1.0 X-Originating-IP: [155.4.205.56] X-ClientProxiedBy: HE1PR0301CA0004.eurprd03.prod.outlook.com (2603:10a6:3:76::14) To SN6PR05MB4591.namprd05.prod.outlook.com (2603:10b6:805:38::25) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN6PR05MB4591; X-Microsoft-Exchange-Diagnostics: 1; SN6PR05MB4591; 3:8LyZjz5RLE7ea0tc7d4v2zpZapiEcxuF7NoormPBhDbDIACZdikLo++zfhJPf8y02S8T78wBA1h79N+Scmj2fqQFMsIZGtG1iZ2QoZfwy1o/ehCgFNfNfgdrfGNQ+KgwSPlFdSlJwmDu/vXssBNi4uW0o+NUJPflYMkIRloopgi223i2Yow8iYbwI+ALK2qsikcXveoM+hGPL9DmICQj8IYyTFz95jAxtrPNfRZGhfayFBa2hHAC/6pBIYJ5d0NY; 25:WF6y64ZdISiTc2p9+cJtmGwEwnRTaXBTvGtcCJOaR1y0AZvTb/UJXoehXgUFdgOaHtj99rcBNL4vIg/5uEMe9CyI6FV4NMu4tW2qAY9CGJTEFoAxziIZG24d60HuAV2vQz4jQ7q89jW+JbkJSmnnWzewPC8Az9iVPwzEDNX8MSr7ujhtvIDbPhSBEU3C9NbK7tqWt0Ric5KPTWrFcy1WRJ+HMImRK6wFxrh7Y4xY82c+lDpL6t1Akbpgu/7hzTlwvk8TWRHnLzdQbg9yFyi80/DsrvpqGrD0sNlew8LyJkhmjNLhdOuuDVhu2JMkRI3lKNtU44XHOk8Sbfxnj2MKkA==; 31:nVYMKeRKmCbFW1y5R8AbeCiqISfY1yiLVgN9bhv59DHdWkGEbIvTUdWtUdYSrxHUYRpzBb6SnmS/wNzxsaTGO9Sj5ff+dXZwMvAYZrnZNL/Xk1uP2974qNpc0Kn1msxlrPCJi24lCP5kCmHipGqqwV0mfjkuZTewJ0cILP7m9w/yuEeU+Yb/ZI5r2MbsCS/60eFsYxj51OUR9gJeQ0rDx9zMqny5gJB4mCUC67Lzmrc= X-MS-TrafficTypeDiagnostic: SN6PR05MB4591: X-Microsoft-Exchange-Diagnostics: 1; SN6PR05MB4591; 20:U9H1gwH27N12asWSF9dWpBiPB4Co3rk+aIAhgb49Z2tkuMl65YaFXqtLMYwWi6vSmuUcLiw/hbElYaNNdGaMTWPB0j9ncAOrm1swPIcVNMep8iQOblt54TKnDce+1ccLmYWMXqR99+zbLP2xGIk3FJz8AQukDt5mRYOjasLIiEWHQD50NP5J4flXyNYI0lv/y8WVQkjTS5VsFqunqOGTPBIgvP8+kM7SrLEVlJpOuF73Ozits3RHtmTvD2VcC/4iwSc5miOETXMjeA2MWeQYKJ/91Lgx3Ia7WSmlTS7CgJbN1N2sFa8MAMOkaandPb8MvsY7YQ/6OUB8D5GLLia3QVI5rsDY25JXt8U/rHNTlR+DOT23dQyqByamEqbo1PZKuItTDkVhaevkb++YwtNFq3BJNi38PRABxnx0CsRqSThXweRaoJQobPvVdm8FHGYR9IgTCN7m30thIyavOnqSe3H58WD6yCEjeC3xglvzykvotQ0MYBoL+S3TVpL9VqUt; 4:TZveW55B20rt9LDQooOfEiVKCSfdNDDkycoJFZ7DCbR6G7GAR+an3v+/XtJhKoUkzOGY+hvjeO06uLp6YlJCRs0D7J8SrsgWZbt7Gn4dM/jKauZNg6DWmPWE3su1Zs1GJwjViikIl9+hvrYwj0jiTgp01c4PZkgDYa9tIx/9WXx5OWjBzYCN55QMG+/Nt7P+pJks/4jpLqFb1gJxQS6ECZprGDThObjpoT+m/SgpAfDZ3u1z08lxDgtkF7MankUQ1BSwpp1CKTiQgSCVZAkbMdmqGFcoETawO8XMIR/7oDVuXE9YplVyCSebbUziBl3cNowgBlbRcNh9QcS/Q2WGnwgMRdNnNBaUYCwQ6qjOCDw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150)(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231232)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:SN6PR05MB4591; BCL:0; PCL:0; RULEID:; SRVR:SN6PR05MB4591; X-Forefront-PRVS: 0654257CF5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(366004)(396003)(376002)(39380400002)(346002)(39860400002)(199004)(189003)(1076002)(2361001)(6486002)(97736004)(53936002)(6512007)(105586002)(106356001)(5660300001)(956004)(2906002)(50466002)(3846002)(6116002)(25786009)(2351001)(48376002)(476003)(2616005)(486006)(305945005)(11346002)(76176011)(446003)(186003)(16526019)(26005)(478600001)(52116002)(6506007)(51416003)(86362001)(386003)(81166006)(47776003)(81156014)(575784001)(4326008)(8676002)(36756003)(68736007)(66066001)(6666003)(7736002)(316002)(6916009)(50226002)(8936002)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR05MB4591; H:localhost.localdomain.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR05MB4591; 23:D+xKm3/5Gj31PjAZNaYUbcLgazDqIUVjb9/KZ5ZMv?= =?us-ascii?Q?thp0G8R96QJFgyowjty2ZSKNf+4nExVRf5ToVloDV8Ej09WjnF0/aH0O+mGJ?= =?us-ascii?Q?BAn4ql48B/UemUbjld3wi6j4OY/NKd8s0EMZICgh7O8hNnZQuZZT+zSL3KXc?= =?us-ascii?Q?yh8Q87FQxKbNoWlhitWNORzTZ/JAvcb2h6LkJsZy2vDzr2Pdscf739ArR2uw?= =?us-ascii?Q?2PnCx7Y8UZSMb1RcMjNnSWUZ0OXpSsQ5Kqwq9mWwlTVf/sVJtyTFz9rewPXU?= =?us-ascii?Q?wD0X0osxpvuGE0SwQA6s+gXMt4hxGwbQjo6q0ISEHQ/UuitZUWg9abcIqEZc?= =?us-ascii?Q?XAA0hiPUSV3UWI0wGMLpBcjIsqioPK4LQAGSCH3QMzh2chM7ZAAGpbrsH5xJ?= =?us-ascii?Q?T1FxI4QdHye1V9ZJdaRj1bvrD4sW8yNtIyj08pMin+HZcFoWaYLuyq/ZkKhH?= =?us-ascii?Q?yCWiykPWxGXLDjheBUpYHbMzzSkK5KH5F3LrYLkiiyXwaWQ/05K8GeJx5UYj?= =?us-ascii?Q?jtujxt8IpvPCIAfsu0ep5/8HBUHnsmdYdB59UbgPOMWnFrnwfEk/2aCft61q?= =?us-ascii?Q?6IdAZRzvOJqqi9Nj27JmSQ4Nas0qSG2fr5cCYXkN0G14njl29CC1ZP5SXZFm?= =?us-ascii?Q?NCNiwsZLImh+qKkr0G8JTHMD/vXzQ3bLB2Bg+gN912cDkJY6miIc5dAlbrBA?= =?us-ascii?Q?3X9Z3/2Y7//MKKlAF+prcq+DHb7rP2OAEV/AXEeXFH7d1imXJgqJl8Zam9Tc?= =?us-ascii?Q?NvYY4JUIzpT+QsXeeJhL/aOZSAYaJnDegRbTpBT3708ZsZ08lfNYHUnPaolQ?= =?us-ascii?Q?HpjpgWxNjeBqcBKsGmvG2lpyvZ30iA6kQ6L2u4qWQHE+A0JgB2OJ2vPiYwcA?= =?us-ascii?Q?UcmfKcq9PmAzvBcOjLW5VvCPW8o7nLYxP31AhPG3fRx2ATKnUIalDLDeOg8H?= =?us-ascii?Q?DYctoJmfOe/O6adbH+h7O8i5Ee4rRzVvRzp8XekvkKzJm8LlEKGQA9KcThAq?= =?us-ascii?Q?wVJ+xhb+QWBUbXyjfvJNiMB1/f+FF1b8f6dKSbi4OKHu8U7Po6qk2IMEe1v9?= =?us-ascii?Q?3NkaEhWk9nV7dPBGOU6S5pM8TTRXFoflAF8mwJuqRdkYv5FgHeTwjU7wSSvw?= =?us-ascii?Q?8UOpPzb36GYgR6F6UphF8778xDUwHTn6/YdT9WpjoAIvNn7nxSOY6wLfCNKK?= =?us-ascii?Q?Z3eAIRKgEHK+CicMHEQjjLtmba9jCnk2A6bSW8DaObfm6h+GHwzArk9huvHu?= =?us-ascii?Q?dyY49m9bkRW93FOZY6Snj68+1d9MOSVnw0VftVx?= X-Microsoft-Antispam-Message-Info: Mim69pn43PdBp+dxHPtJrQR7ycPcnEjg/+HN7XtuCW4dI6nivH5BsmVMPaUBNO3VVKIIIL+hCc4mN/DJFpJNVBgR8OYuDgGKu2gFDILc9+gw8WUeVREu4DXO0JRMBWt6zCPspgyyyH6I1vT2bFmssXXMtRl3U/K7g0in2BSH6Zl91rT3btetkbv8C0l0R/qk X-Microsoft-Exchange-Diagnostics: 1; SN6PR05MB4591; 6:o/eb/gGKYSRkgJgtfWLy/TxFsdZCyGPyX/+r/DIctePIm4zt/+1bIBlMsjoekKUDlOZ2/9YOC8N2QetxgJGd5TSV0UbhnM4x7byGZNBS4EF8A7+wM9basvqFudYJi7aIWJCFKJTWak6Rs9pfqvreyLqdTQzx6ciJ6EOLZWcmDKjZxwIyk57wI2Njom1na9FmGRJKIrNaM+VZJHzWkyCKBqQPBnQWaf8g5MidHebFMZZ70/zcUCXjjZG3+SxYBfDwd6buDKpMwpbOU7gBHJIrPm4lnNxJmHxKjNodAzs/29nItwVtZ2LXKxGoD924UhunQSevy0R9iaumBFomnvI7Xi7UYd2vkBxiUhbDMnJVc+1kp44J7NL9wJhajsqKX1/Gi5CCjdsuqyNrAF8VnKX+z/YjmBjGJ8MeyJMAov5Cy8UG09BrmvLR2hOteQy0aqqK6KNZAJQKreOSBkG8jMz38w==; 5:0OhM93ZCNSE50orMXSIQ8iwOIdkAU9gbwH7StiBg1WYNOLzpJBHbqxco5Uo2g50h1iq4+mLqyhSD1LVyP2Bwor0CXnr3dVb4V9h4GOUsrS6T/+e9eLX8ckwhEZaQixxT17+Ird42ZgS1H2pfQXHkgYDWJoM7u9gAKkrV03omZy0=; 24:IjIeFb4++JrqH2SLLf+/BtYfcl3VEG3lP1cSZrdVKlx7xk6BLUDJ/Uf7wprDgKYGWOme8cEdbXXyL2bJwxCVGrnXCgp/aZa64+JcEjFvOSA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN6PR05MB4591; 7:9ImZ+l4G1END2ECTYQCppSPpmOP8PmYAUmWfPNuLUJNmQVLvKDEmAE+y1f3QJkjnGqbXyLXekS1S8zM8FxPitZYDgFBLFufELZjkKUVHlvDwC531A1QMpm/bWFzaLB2tJndcIiNDCpaXrj33cANn6N1vSv9wQVp3MPtLdL1IzMBpt8l+a5Fgos6ZlTr8MsthTyCtFMwpmiNI6Hre3+tmgmyjsmn2N2sYml7Jw1PFZck44JqS1sPQKy8h6wVuxy94; 20:ybKJ9J51eWULkC2UkFfnNeaiK6b7sRMMon+q1Li6+gWZbTLGm+6C3ZG9K+ycotVjDmOCeJHdOPxL5Wsr5JunZxfXoYw31K1S1HYFJV0Q2QEsvw8TtrWIJFe+8rL+st0JIt05ALITWww7BiIcHSnfzCLe9MqlrzuMakPAHub2R0o= X-MS-Office365-Filtering-Correlation-Id: b169eb7a-45f3-48c4-d4b9-08d5ab4f2c9a X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2018 08:24:47.0184 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b169eb7a-45f3-48c4-d4b9-08d5ab4f2c9a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB4591 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Hellstrom , stable@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP A buffer object leak was introduced when fixing a premature buffer object release. Fix this. Cc: Fixes: 73a88250b709 ("Fix a destoy-while-held mutex problem.") Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat Reviewed-by: Sinclair Yeh --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index aacc9307ab0b..96fd7a03d2f8 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -2595,6 +2595,7 @@ void vmw_kms_helper_resource_finish(struct vmw_validation_ctx *ctx, vmw_kms_helper_buffer_finish(res->dev_priv, NULL, ctx->buf, out_fence, NULL); + vmw_dmabuf_unreference(&ctx->buf); vmw_resource_unreserve(res, false, NULL, 0); mutex_unlock(&res->dev_priv->cmdbuf_mutex); }