| Message ID | 20180430114058.5061-2-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 30, 2018 at 05:10:38PM +0530, Jagan Teki wrote: > Allwinner A64 has DE2 CCU which is similar to H3/H5 SoC. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, May 2, 2018 at 12:16 AM, Rob Herring <robh@kernel.org> wrote: > On Mon, Apr 30, 2018 at 05:10:38PM +0530, Jagan Teki wrote: >> Allwinner A64 has DE2 CCU which is similar to H3/H5 SoC. >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> --- >> Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 + >> 1 file changed, 1 insertion(+) > > Reviewed-by: Rob Herring <robh@kernel.org> Hi Rob, Do we need to add this if it's just a soc-specific compatible we add in the device tree to future proof things in case we discover quirks later on? AFAIK we haven't been doing this, and this is likely to create some confusion, because they aren't actually mentioned anywhere in the driver. ChenYu
On Tue, May 1, 2018 at 11:19 AM, Chen-Yu Tsai <wens@csie.org> wrote: > On Wed, May 2, 2018 at 12:16 AM, Rob Herring <robh@kernel.org> wrote: >> On Mon, Apr 30, 2018 at 05:10:38PM +0530, Jagan Teki wrote: >>> Allwinner A64 has DE2 CCU which is similar to H3/H5 SoC. >>> >>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >>> --- >>> Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 + >>> 1 file changed, 1 insertion(+) >> >> Reviewed-by: Rob Herring <robh@kernel.org> > > Hi Rob, > > Do we need to add this if it's just a soc-specific compatible > we add in the device tree to future proof things in case we > discover quirks later on? Yes, but the fallbacks should be documented too as I found in the rest of the series. > AFAIK we haven't been doing this, and this is likely to create > some confusion, because they aren't actually mentioned anywhere > in the driver. The binding doc needs to written such that compatible can be validated to contain the correct set of strings. We can't do that now with free form text, but when we move to a schema we will. Rob
diff --git a/Documentation/devicetree/bindings/clock/sun8i-de2.txt b/Documentation/devicetree/bindings/clock/sun8i-de2.txt index f2fa87c4765c..7f425bc0e820 100644 --- a/Documentation/devicetree/bindings/clock/sun8i-de2.txt +++ b/Documentation/devicetree/bindings/clock/sun8i-de2.txt @@ -7,6 +7,7 @@ Required properties : - "allwinner,sun8i-h3-de2-clk" - "allwinner,sun8i-v3s-de2-clk" - "allwinner,sun50i-h5-de2-clk" + - "allwinner,sun50i-a64-de2-clk" - reg: Must contain the registers base address and length - clocks: phandle to the clocks feeding the display engine subsystem.
Allwinner A64 has DE2 CCU which is similar to H3/H5 SoC. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 + 1 file changed, 1 insertion(+)