| Message ID | 20180525155030.3667352-8-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
+Thierry Hi Arnd, On Fri, 25 May 2018 17:50:15 +0200 Arnd Bergmann <arnd@arndb.de> wrote: > These two functions are unused in some configurations, and using __maybe_unused > is the easiest way to shut up the harmless warnings: > > drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error: 'cdns_dsi_suspend' defined but not used [-Werror=unused-function] > static int cdns_dsi_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~ > drivers/gpu/drm/bridge/cdns-dsi.c:1340:12: error: 'cdns_dsi_resume' defined but not used [-Werror=unused-function] > static int cdns_dsi_resume(struct device *dev) > > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Hm, I thought such a patch had already been applied by Thierry [1]. [1]https://www.spinics.net/lists/dri-devel/msg174363.html > --- > drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c > index c255fc3e1be5..f2d43f24acfb 100644 > --- a/drivers/gpu/drm/bridge/cdns-dsi.c > +++ b/drivers/gpu/drm/bridge/cdns-dsi.c > @@ -1337,7 +1337,7 @@ static const struct mipi_dsi_host_ops cdns_dsi_ops = { > .transfer = cdns_dsi_transfer, > }; > > -static int cdns_dsi_resume(struct device *dev) > +static int __maybe_unused cdns_dsi_resume(struct device *dev) > { > struct cdns_dsi *dsi = dev_get_drvdata(dev); > > @@ -1350,7 +1350,7 @@ static int cdns_dsi_resume(struct device *dev) > return 0; > } > > -static int cdns_dsi_suspend(struct device *dev) > +static int __maybe_unused cdns_dsi_suspend(struct device *dev) > { > struct cdns_dsi *dsi = dev_get_drvdata(dev); >
On Mon, May 28, 2018 at 04:32:43PM +0200, Boris Brezillon wrote: > +Thierry > > Hi Arnd, > > On Fri, 25 May 2018 17:50:15 +0200 > Arnd Bergmann <arnd@arndb.de> wrote: > > > These two functions are unused in some configurations, and using __maybe_unused > > is the easiest way to shut up the harmless warnings: > > > > drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error: 'cdns_dsi_suspend' defined but not used [-Werror=unused-function] > > static int cdns_dsi_suspend(struct device *dev) > > ^~~~~~~~~~~~~~~~ > > drivers/gpu/drm/bridge/cdns-dsi.c:1340:12: error: 'cdns_dsi_resume' defined but not used [-Werror=unused-function] > > static int cdns_dsi_resume(struct device *dev) > > > > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Hm, I thought such a patch had already been applied by Thierry [1]. > > [1]https://www.spinics.net/lists/dri-devel/msg174363.html Yeah, that's in drm-misc-next, but didn't seem to have made it into linux-next until today. Thierry
diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c index c255fc3e1be5..f2d43f24acfb 100644 --- a/drivers/gpu/drm/bridge/cdns-dsi.c +++ b/drivers/gpu/drm/bridge/cdns-dsi.c @@ -1337,7 +1337,7 @@ static const struct mipi_dsi_host_ops cdns_dsi_ops = { .transfer = cdns_dsi_transfer, }; -static int cdns_dsi_resume(struct device *dev) +static int __maybe_unused cdns_dsi_resume(struct device *dev) { struct cdns_dsi *dsi = dev_get_drvdata(dev); @@ -1350,7 +1350,7 @@ static int cdns_dsi_resume(struct device *dev) return 0; } -static int cdns_dsi_suspend(struct device *dev) +static int __maybe_unused cdns_dsi_suspend(struct device *dev) { struct cdns_dsi *dsi = dev_get_drvdata(dev);
These two functions are unused in some configurations, and using __maybe_unused is the easiest way to shut up the harmless warnings: drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error: 'cdns_dsi_suspend' defined but not used [-Werror=unused-function] static int cdns_dsi_suspend(struct device *dev) ^~~~~~~~~~~~~~~~ drivers/gpu/drm/bridge/cdns-dsi.c:1340:12: error: 'cdns_dsi_resume' defined but not used [-Werror=unused-function] static int cdns_dsi_resume(struct device *dev) Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)