From patchwork Wed May 30 21:49:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10440025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2B0D0601D3 for ; Wed, 30 May 2018 21:55:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C78228A67 for ; Wed, 30 May 2018 21:55:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10A2129612; Wed, 30 May 2018 21:55:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B50E528A67 for ; Wed, 30 May 2018 21:55:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 19CB46E069; Wed, 30 May 2018 21:55:03 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00D226E069 for ; Wed, 30 May 2018 21:55:01 +0000 (UTC) Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0LtBwl-1gKwzH1Xcx-012t93; Wed, 30 May 2018 23:49:40 +0200 From: Arnd Bergmann To: Tomi Valkeinen , Bartlomiej Zolnierkiewicz Subject: [PATCH] fb_omap: add gpiolib dependency Date: Wed, 30 May 2018 23:49:22 +0200 Message-Id: <20180530214938.1073749-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:G8HuF+dSRxo43ZgzxicXS+Sgtw5RiZhb/HGNBdCbp1PIc9WWrt3 ZfFNtnOqrHJTAlAh31z3Rle9evAUJ43+w4i5UzniCFuFmp3lNTFjuAQUJ0apBPIorlQZMFa njSV3jPEOCg3JrzDRZ0l3lZluDZju1vmfmyPGrD/arH1UF4W1tij7rSqWky7AxAUTmlfued sYIcPTBO/3AjpnT9RUGHA== X-UI-Out-Filterresults: notjunk:1; V01:K0:1cYPpNrbUdM=:oTPUxGE+xh5b9vbvUsSjLT SfA9VAACtoJlXsSzbOJG6ykrY/6cp07J3a8mh28+qVMKHFZPSiZ+842pP78IimKoZdkr5eXro M/gbSou15+EVNAbdG/we+SwnX/ESGfbJ20W7KwmVwBtYJyLJpScTMmcE/bsyI6JOn/xu63txl Z1JndFE41k0HCgVjHy8yaRyeNWS7LmJ0mKNIiF1SttYySyr0UiwX2nRV6XeMuxvvQbzTgrYGk PyZzpfX7mP9iA5uwOC4fD/rWnmFuYSEy5z3iuhjXliZ/kO7BLLvJjapSJqdJYvHsM31k6SUYh ZPDhY4hn9LS2qepW99RL6S0ahkJ7JNx8DW7XZsdfHD5a0I3mXryKeA9Rk7fqNTPfGH1H9HFOb OMg1O/7jICAhhU4kulfuXQYPobRQWjv73MWRuCvhEpvZb7uK7AfkEuV/bCCrjUhiXba8CyyZy K/Za/tPkNrUMkkT1xIsf5lPX4PBJs+p+VpLhaH7gTABTcmHt9iCjvSgwPJ79YU5y0TRc68tfT lPP4hDfhaNBl8uX6j3DlgN5sbbk31uP7QqdttOzJtq9whrLYxRtgnY9ZU6kvuVvWjvzBedcwg XICsp8sAqIm9q8ro/383bXWclsZMZh+P83ZuX+fEWWJiLtBMvFWTeTO/iyVFs8wqaOi254PrE J/U2gEAmOV1EtTvvWVGTdcIi44/kGqYy1g0Zr6jputDt0qlidpu8jHUE3Ii0L9TujUw4= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Arnd Bergmann , linux-kernel@vger.kernel.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Building the omap sub-drivers when CONFIG_GPIOLIB is disabled causes lots of build failures, either from using gpiolib interfaces, or from including the wrong headers: drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_enable': drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:101:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_enable': drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:86:2: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_probe_pdata': drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:189:23: error: implicit declaration of function 'gpio_to_desc'; did you mean 'irq_to_desc'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_probe_of': drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:210:9: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c: In function 'sharp_ls_enable': drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c:120:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c: In function 'lb035q02_enable': drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c:170:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: In function 'hdmi_probe_of': drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:584:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c: In function 'hdmi_probe_of': drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:554:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] Rather than fixing up each one individually, this just marks all of it as depending on GPIOLIB. Signed-off-by: Arnd Bergmann --- drivers/video/fbdev/omap2/omapfb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..3bf154e676d1 100644 --- a/drivers/video/fbdev/omap2/omapfb/Kconfig +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig @@ -5,6 +5,7 @@ menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB depends on DRM_OMAP = n + depends on GPIOLIB select FB_OMAP2_DSS select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3