From patchwork Tue Jun 5 13:54:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 10448369 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3B2066053F for ; Tue, 5 Jun 2018 13:54:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B56B294EE for ; Tue, 5 Jun 2018 13:54:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 20152294F0; Tue, 5 Jun 2018 13:54:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C8D08294EE for ; Tue, 5 Jun 2018 13:54:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 98C966EDDA; Tue, 5 Jun 2018 13:54:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id A41A56EDDA for ; Tue, 5 Jun 2018 13:54:35 +0000 (UTC) Received: by mail-wr0-x243.google.com with SMTP id d8-v6so2546966wro.4 for ; Tue, 05 Jun 2018 06:54:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LX5Ax/A7QrfEjVy8tdEiGXI2NPjRkDiNrXaHP/an6n8=; b=jmqxvsD0D7kuonLNYmBveZa4qD5fTo5TH59YGvUqhA4M0S+gZEVXw+4oR/bYIIyvDQ ZSuRiNAntk70f89wA2E2reodQcPhYBQFpC5NAtKmxP6OhGP60DAg5VqggvadaBk4iv8r Eobcl86kTcE+XkBfyI0irZ557U6ZxtHR49oSZBoJrKxKGuwVtGgwrpunbrHc5h6N/tY3 1D85dntBH1As8OTUF2TQ5QqsQXbCr0C/mw3t+8kbvMcPol6rg/IczMcMatIBd7goMrQ0 Lvl1hGStkupqiPOWlazqogZjBztS+g3nXTDLVpRahIuqfLqZejsfL1DN/pdbLdeYrzjI RXfw== X-Gm-Message-State: APt69E1R0Hag9FsvOQyH1d2DYnzGnD14P6L4h/l7GIJ495c5tlIDMyno YbKoP3ONqV95WJgjXlK2FpPW+93j+OT1lA== X-Google-Smtp-Source: ADUXVKLYQXDUzefywpkhIgdfWvuoqPjMydTvXhik/9353eAj2B4j95uTRvyCRsPvkMCO2QTLwaMK5g== X-Received: by 2002:adf:d08b:: with SMTP id y11-v6mr2317032wrh.152.1528206874331; Tue, 05 Jun 2018 06:54:34 -0700 (PDT) Received: from lmecxl0911.lme.st.com (bol62-h02-176-179-166-238.dsl.sta.abo.bbox.fr. [176.179.166.238]) by smtp.gmail.com with ESMTPSA id o53-v6sm76797785wrc.96.2018.06.05.06.54.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Jun 2018 06:54:33 -0700 (PDT) From: Benjamin Gaignard To: gustavo@padovan.org, maarten.lankhorst@linux.intel.com, seanpaul@chromium.org, airlied@linux.ie, vincent.abriou@st.com Subject: [PATCH v1 7/7] drm: sti: remove the last call to debugfs Date: Tue, 5 Jun 2018 15:54:07 +0200 Message-Id: <20180605135407.20214-8-benjamin.gaignard@linaro.org> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20180605135407.20214-1-benjamin.gaignard@linaro.org> References: <20180605135407.20214-1-benjamin.gaignard@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Thanks to all the hooks in drm structure, custom debugfs could be removed of sti driver. Signed-off-by: Benjamin Gaignard Reviewed-by: Philippe Cornu --- drivers/gpu/drm/sti/sti_drv.c | 50 ------------------------------------------- 1 file changed, 50 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index 90c46b49c931..95b0ac4d819c 100644 --- a/drivers/gpu/drm/sti/sti_drv.c +++ b/drivers/gpu/drm/sti/sti_drv.c @@ -7,7 +7,6 @@ #include #include -#include #include #include #include @@ -72,53 +71,6 @@ static int sti_drm_fps_set(void *data, u64 val) DEFINE_SIMPLE_ATTRIBUTE(sti_drm_fps_fops, sti_drm_fps_get, sti_drm_fps_set, "%llu\n"); -static int sti_drm_fps_dbg_show(struct seq_file *s, void *data) -{ - struct drm_info_node *node = s->private; - struct drm_device *dev = node->minor->dev; - struct drm_plane *p; - - list_for_each_entry(p, &dev->mode_config.plane_list, head) { - struct sti_plane *plane = to_sti_plane(p); - - seq_printf(s, "%s%s\n", - plane->fps_info.fps_str, - plane->fps_info.fips_str); - } - - return 0; -} - -static struct drm_info_list sti_drm_dbg_list[] = { - {"fps_get", sti_drm_fps_dbg_show, 0}, -}; - -static int sti_drm_dbg_init(struct drm_minor *minor) -{ - struct dentry *dentry; - int ret; - - ret = drm_debugfs_create_files(sti_drm_dbg_list, - ARRAY_SIZE(sti_drm_dbg_list), - minor->debugfs_root, minor); - if (ret) - goto err; - - dentry = debugfs_create_file("fps_show", S_IRUGO | S_IWUSR, - minor->debugfs_root, minor->dev, - &sti_drm_fps_fops); - if (!dentry) { - ret = -ENOMEM; - goto err; - } - - DRM_INFO("%s: debugfs installed\n", DRIVER_NAME); - return 0; -err: - DRM_ERROR("%s: cannot install debugfs\n", DRIVER_NAME); - return ret; -} - static const struct drm_mode_config_funcs sti_mode_config_funcs = { .fb_create = drm_gem_fb_create, .output_poll_changed = drm_fb_helper_output_poll_changed, @@ -167,8 +119,6 @@ static struct drm_driver sti_driver = { .gem_prime_vunmap = drm_gem_cma_prime_vunmap, .gem_prime_mmap = drm_gem_cma_prime_mmap, - .debugfs_init = sti_drm_dbg_init, - .name = DRIVER_NAME, .desc = DRIVER_DESC, .date = DRIVER_DATE,